From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A8DC77B7E for ; Thu, 25 May 2023 20:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B182900006; Thu, 25 May 2023 16:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66305900002; Thu, 25 May 2023 16:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52A46900006; Thu, 25 May 2023 16:53:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 42C05900002 for ; Thu, 25 May 2023 16:53:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 071C31A0BBF for ; Thu, 25 May 2023 20:53:38 +0000 (UTC) X-FDA: 80829978516.12.3A37D34 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 2EE3414000A for ; Thu, 25 May 2023 20:53:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=PRDb4uH8; spf=pass (imf09.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685048016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e72vGCwhPoa8gN25X6qmdDXVUsdWWJFQx8MjqDcoGDA=; b=XwCiLTRG6jJTdkYJKvow92QEzkfSoYcPRtIjPCHfpQdvHlJyLdcWdcxL0MF9OjzEqEN2/7 V88Xk8WC6fnqiyZkz3xXjVqa1HyklwW9907QhQrT2cp7BpMdLs5SdoX4gab/CO54DF4iH/ 2M8MK6Gq1FIxC6fQND9lw7MyNUr5vCk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685048016; a=rsa-sha256; cv=none; b=Owt7j825Dcrw6DyzFSqj+4rrarSLaIpOdZGo1li3AfQOFIePupLu3YwFc0wkqKYRQyPRcc 4vDfvrD4tmxIC1l0od2n4qZ7xuua4Epfc0o8xOOwz7cw3ETGCAnduXmGkaw5tlV+j4om3I 96H6eR6zNCUjOfmfDE/o28OZLr/frJU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=PRDb4uH8; spf=pass (imf09.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-56187339d6eso2628047b3.2 for ; Thu, 25 May 2023 13:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685048015; x=1687640015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e72vGCwhPoa8gN25X6qmdDXVUsdWWJFQx8MjqDcoGDA=; b=PRDb4uH8g3Vv6gZWsZ1gkHY+ANMWnqtSqEQNi+t68NKJyRAPGtGIjXS+o6ABKHZ7yv q51K7Vr8Q1brsvSZQkdt4WeLJo6vXr04Grr6RxGrB/PY5E3pp1cBQWvGni0wb9TWYIbM 5FWOkPlw4M42rE2TxcMBGldDhB3WLqb55j0CqgwQEW0TmVHxxCeHx2Zs7VLCqGumlN8c PmQWTAjBOIMu7fHadjtAjQF7IDQQLa3x/OUyFY2aJiBpGADt0K07OCNxrHer3KqiVV69 GxawL7cJdKwcX3ZUAGYa8EVBTKoLWza/yXtntrwGkP8KyxHL6U40gF5XovIoxt2V2Fr9 5Wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685048015; x=1687640015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e72vGCwhPoa8gN25X6qmdDXVUsdWWJFQx8MjqDcoGDA=; b=TLY0pOuUk/bm9n6yBYUU4bIKAI8IU9dt78ralKsX0VzwBDv0uqRbrRToLfudjY98Bw Acl9+ohrye05NcUmEXRnFW/pRvqMZl36a1j7a7RS5yldzvwW4BxPhunE6n945Rplud8V RaKpnf9psXUDCa0LnawtunyO/0apP5ODa2T3ilHvmpjERdPDEp+gYTkg1MPbq27BEBrs E5kjrO7JH1EEia6Wmkb5paFdi/mc9DmhXoxkNhFfpKfpL0vGuWXBWy81PlZg9FBiNlpP k4mvANbk4XPgp67OPL8+qW6najspjEMy3aKCSgaT2J7lY2C1EttL0RZBJuQgBP5p/HG5 nEzw== X-Gm-Message-State: AC+VfDzWH0QPIYI0Bt5RqZ7gnA8PykPPRa8+y/KK2EaLLAWCsS44VSVl lWZL8DwaLRcmNlgf26Jq/9u5FdnMhrLrXnt9IOg= X-Google-Smtp-Source: ACHHUZ6an6zID91jt8f3LQ4QGAvFJ9u++x53xf0fSCLXe0WivFCmGXJlgIcqvJgo7KICituWVYFJf3qgdSw5/O75Zdg= X-Received: by 2002:a81:4810:0:b0:55a:84c9:e952 with SMTP id v16-20020a814810000000b0055a84c9e952mr1013445ywa.17.1685048014974; Thu, 25 May 2023 13:53:34 -0700 (PDT) MIME-Version: 1.0 References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-6-vishal.moola@gmail.com> <20230525090956.GX4967@kernel.org> <20230525202537.GA4967@kernel.org> In-Reply-To: <20230525202537.GA4967@kernel.org> From: Vishal Moola Date: Thu, 25 May 2023 13:53:24 -0700 Message-ID: Subject: Re: [PATCH v2 05/34] mm: add utility functions for ptdesc To: Mike Rapoport Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 795cra3se3ohaz4x4ueo366aqbcx5i4y X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2EE3414000A X-Rspam-User: X-HE-Tag: 1685048015-523480 X-HE-Meta: U2FsdGVkX19XfkWhv4TSeQBnw+eKpIoewa4QIbda2OHood/IyotGc2i6VpHf41GZgErXEAe1XFJA3iSRceO3QHux5Zl9PagRIgKRntCdGdT34IfYsGauBMWcL1xt67oIQYJhpTFB9QHDzWpWGhHvkObTEwJf/BBBqhTDpmmc/LVE2U/y8YOIHynsfGDtaU2wFp4njD4rFi7MYrmih4vI+0eY3wQjNwXdOmmk2dIc5fDGd9E9fvRCjKmt9DQmQLfWjQ/TqWQn9ypAPr7iS0ssHKjBH889r3bNoiXEtsqiE4Rj02DHtvFtfjWNuTgGD/iw8nXnp9oGBdQ2QLSwjnFM5k8sJno97X8wIeK27lHfBK7kW6MEY9Bu09PEnSfoPQnyfN9ssQMy6OHClMYVR+0IkXQzFxLX2YJAJg+7OEYsIhHngw5n1092YapDLwWfg3LZ/niOR1e80Y0+IpmM352enSnmh6FgEmipRCMfvEp3EpCzVGgWSzjvNoAm6C8UXJqOc0gfz44ViWlaBa9u/i5l8jUVR9SXMvCjWEMDIywbOtnfXDRQUsvnF8mO7KW0iHklC0YSUusN026zhGEpYlw79d7YZquOcrhwnKpqmxJ7kUCJFNjn0NKpU3hD7SNGONC4YiESfVsW6AxUmErVZ28PP5c/Yw1mlB/y2cW9SQFrbB3jx49Y25t/4/WXIFjnrOLw7UXV+BAfIXUdC2DggUI6Y9RwXOfzjnh0Zca9NHbeS+ViOmF098+e3YBeR089pgujt862YSFt0nHIY3lYvIocfHqZLWM96siRNjpyQv1EMAHEfTUxKt5tz8IWYKO3BZQSFVyYkiXGmmemnoPpq/z5FaagGSGls1jgppTTiGzkkh+2Acxi+RtnN0R8/e0j5WsVx9qaJCkd9gE9dmqPbDTSPgCCT7uI3A/1bGhOII6AYTFfr1zztmzOKbvakOaJR5qREGptwhGlTtvwZQHngm+ Tcc2Wg5F KuJgyP1vFacF8o1NqEKCMbTU5kY+wstgqRCDBA/uRsiZoVuZN4Smc0SicQpZ4vhLRkIA8qgVsBK/Xd9wY7/nBAqEwCYff0ZOpDAadLrSfLq0nJ9s83ugUDeGJepW5vbs/tCd7WzoMefD5D0TGZE98MxFSDtOy8CNfNBn7ymEUkDa7TagZd36nB+k1V2GBL4RAdJldQsV3haUZ6xqVOZYkYEYv6NBOnOSlAXXJ0JMoVXzlFkzA4OjsnSTK/1wNISzDzXKa3DHC1nYqDwPwRRqX0xPgS9zcxtxagI5QfHmNotSrYxF2uyauMff4PhVTGADUGJ4LVajzFpWKCCvJn5XIfFyxvFjt2sJBlLNW0nYBQFTgfy+ZsBVm8mt7aj0gNdl+y6sbplTaQrmY33bKVuToGq4viSE6UTLqkDbfN66Te2oAW8dS732LC7OnhETNtzjo3SNG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 1:26=E2=80=AFPM Mike Rapoport wro= te: > > On Thu, May 25, 2023 at 11:04:28AM -0700, Vishal Moola wrote: > > On Thu, May 25, 2023 at 2:10=E2=80=AFAM Mike Rapoport = wrote: > > > > + > > > > +static inline struct ptdesc *ptdesc_alloc(gfp_t gfp, unsigned int = order) > > > > +{ > > > > + struct page *page =3D alloc_pages(gfp | __GFP_COMP, order); > > > > + > > > > + return page_ptdesc(page); > > > > +} > > > > + > > > > +static inline void ptdesc_free(struct ptdesc *pt) > > > > +{ > > > > + struct page *page =3D ptdesc_page(pt); > > > > + > > > > + __free_pages(page, compound_order(page)); > > > > +} > > > > > > The ptdesc_{alloc,free} API does not sound right to me. The name > > > ptdesc_alloc() implies the allocation of the ptdesc itself, rather th= an > > > allocation of page table page. The same goes for free. > > > > I'm not sure I see the difference. Could you elaborate? > > I read ptdesc_alloc() as "allocate a ptdesc" rather than as "allocate a > page for page table and return ptdesc pointing to that page". Seems very > confusing to me already and it will be even more confusion when we'll sta= rt > allocating actual ptdescs. Hmm, I see what you're saying. I'm envisioning this function evolving into one that allocates a ptdesc later. I don't see why we would need to have bo= th a page table page AND ptdesc at any point, but that may be a lack of knowledg= e from my part. I was thinking later, if necessary, we could make another function (only to be used internally) to allocate page table pages.