From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DA0CD37A9 for ; Tue, 3 Sep 2024 17:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19E868D01B3; Tue, 3 Sep 2024 13:35:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12A278D018A; Tue, 3 Sep 2024 13:35:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA7D8D01B3; Tue, 3 Sep 2024 13:35:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C2D7C8D018A for ; Tue, 3 Sep 2024 13:35:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4761340750 for ; Tue, 3 Sep 2024 17:35:25 +0000 (UTC) X-FDA: 82524128610.29.EFC29F0 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 745E640005 for ; Tue, 3 Sep 2024 17:35:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nBYgfyb0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725384816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j0CW8rhLDFUaQ71X8gGMvzqTFZUTuOYdHKvSZuUSgKg=; b=4oturATNE8jKEcI71o4189vLf1Q7NpZAv+in4vOcoaJkQQtYXy6aOn2OP1KEu2vnOkwaUf OmUHyqS/Uoo28sl3gb2C2t0Th0MUCQBMRFNjFhJT5Xfi+5iNsxb8BxtVyKXvrcxBtbQvO6 6zW/2hwzSfEaEbRphf+D4DJ19F9TMpg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725384816; a=rsa-sha256; cv=none; b=LdZLiXEpZkzuEKCDgs7Ta7Ih0xc48AMxwtf2a7ufubJ1M7V3KrYUsuh89nXV8Q4S73Vq3a 46+gM9+ePVSrD1U0/+K6cY1tdeZGJLGGJ+1czX81ehw1V3mpLamiPe9M8d0HlwVeXY6tvE aWNscVZ9CKBOeQBwdE6XnPZV1O+5U0c= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nBYgfyb0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c260b19f71so2264225a12.1 for ; Tue, 03 Sep 2024 10:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725384921; x=1725989721; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j0CW8rhLDFUaQ71X8gGMvzqTFZUTuOYdHKvSZuUSgKg=; b=nBYgfyb0EP7Qc+qUKYDsshxQGoFpxwKRPZ+SqrbVsYJj6k5V+Elgof8YQ8KIDG9st+ uWwF/suA8ksUyJVZuwjW1FhSZtDfCNg8RBiSLCidz10AFmbydKq0KnkU2kS7zvuvUgwp 6JHGLfGRc1OKrBO35vqElwgnaO6CkwOQDp4Xsprl8vYT4evA1rtOAQlcB+oY3qVIa04C 4TeEOeTcCbXS5E6C5hfJ0n2OuMnSgqvQlcEisksuiHXFRhAsLwQpUTaro7+Wkteo4IAu NpKgoEWV0Hh6ZW7c9puFmRbu3OamoGMRRLecwIZDhKuvMnoAZhaBwf2rW8lu78yxb93T ddDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725384921; x=1725989721; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j0CW8rhLDFUaQ71X8gGMvzqTFZUTuOYdHKvSZuUSgKg=; b=Zx3aMd2A4+v7JFLuGg5Nwm9E/kGIwnVyxKPNE7SMnuXCA3uy7WJ+YWBmKH/rOGzTDt hum4/hFdN8pm1eAWQwUeb2M5nzXYUtpGrbhEDpc1R+Vaa4eW7qBExWMixhrbOMubY8RP lql9pV2MOx+fvv3Kxiyih0+kozttoQmn844EPd9xPApnrijcOZuBwRzPiSPMAQge+fgK Hg83k7SuhZj/TDvj08vVvOujcSMvLSGqFKHxodtxpQuIi0xE1UXWoIJTZs4Dum8VB3B9 fsgODK88xdcBfYZprat+0Y/P+vrtTFFom5+TwUEbOVj2vxnHgyVM2xEqviI0s7RpfY7O HWvQ== X-Forwarded-Encrypted: i=1; AJvYcCXv5/JI1/7BYFxVrnz/eKHkphoCQ89ww7toMfxEh5oRZU/UppedxFIES6Z2fPQf9g06qTRYys4+0w==@kvack.org X-Gm-Message-State: AOJu0Yxw2lOkCJNinaiJXmTcupLIBXEkaU7WOZD1Myui9H+AOAroDJvW kLWeIq+ZmqgX4wJCSsX6t1ZGLX7gDmVZxmPIejr94q06tk1IkP2QrYRfUXgYNid+ByO7onU8RF2 zKmA/ei/Mr6msEJlYW7y6ZJDFfos= X-Google-Smtp-Source: AGHT+IGu5gblqbaozzhufThg/mHSRVx/NXnG34ZnNs6Ee6bJLangyPU8DmwziVvYVnfPWEKpUV/Il8jyWlPB3vFdtmI= X-Received: by 2002:a05:6402:26d2:b0:5c2:1298:35ee with SMTP id 4fb4d7f45d1cf-5c243724727mr7664368a12.2.1725384920570; Tue, 03 Sep 2024 10:35:20 -0700 (PDT) MIME-Version: 1.0 References: <20240806022143.3924396-1-alexs@kernel.org> <20240806022311.3924442-1-alexs@kernel.org> <20240806123213.2a747a8321bdf452b3307fa9@linux-foundation.org> <20240807051754.GA428000@google.com> <20240814060354.GC8686@google.com> <66ce5eed.170a0220.387c4d.276d@mx.google.com> <20240903032003.GB9738@google.com> In-Reply-To: <20240903032003.GB9738@google.com> From: Vishal Moola Date: Tue, 3 Sep 2024 10:35:09 -0700 Message-ID: Subject: Re: [PATCH v5 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Sergey Senozhatsky Cc: Matthew Wilcox , Yosry Ahmed , Andrew Morton , alexs@kernel.org, Vitaly Wool , Miaohe Lin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, david@redhat.com, 42.hyeyoo@gmail.com, nphamcs@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 745E640005 X-Stat-Signature: e6qcsgm8dmymbsk8csduo53eqzmgypne X-Rspam-User: X-HE-Tag: 1725384922-429485 X-HE-Meta: U2FsdGVkX18n8B5uRwpaI0RC9+c7l0WIRFqKyQ8Vtx6IVW9KIq2xr1OgBmVezQOFzGSArp/FAqZBAmM7cRkBF62eYtdKZnHySYpHd0xHq+v8rfT0+ENm204/C9sSM/YUoKeDn3bwDwCaD3nZJv/aqxUubFPF4jMDGSXUHOSH9Ossgq9cvOwceZ+WwKIDEHuHJNQo2YqeRdgMV0lhGUfdDr6QC4UDhv4ebasa3t1TFmyCHbBbWw4YUrN7fRiSgggk78NOMNxwQnhcrvp0Y6uVWmsuZgZipRL1n+ZFm3QFQi9wP/RdjbRbc5C0jLm9eR3pMq08EUv1qb0lsx4sZfL6B2LWn8yIT5tN9VNcsCbpmcAHE4GZrT4zQEcQf0o/rgo2+HxQxkL9S5IrLzhxh/DX3MDEuJJcmrae9AUsHwSPto0y3fA1lSCHRdpID40aCqLPVCOpu7vt8cCGyDsdq5FNiA5zLXjA0MlnpvSQxfQJZnHt4bmrTJYhTzI/MIlj8o0+H9QL8GgpiiiVJW3W5i6mb7yz6PK8FxtebqE3MQqv555/n0M1we1CAIa1esF1mg/fr9NnCUDNiB1QOkJyQ/PfhrMtkeR47w17X5jroaDu2D3ei8eEIjzxN6giq2yNimVY4+HEthbzOXBO0/gsngy75kabqFFG/qJShXbSCIsna2EPsnDkY8ArX1Gu6AMO5daWTmVos50Y8OGlYpsvjaVe1N/lZrXvfDtN9h9roWiFtclbBqaDCcaOcn/FfZNPd7F0fHsSgk2l7vT6KNFa66+F1nW10ufdLpHM24pLPsrwHu38rm+FwiRWD3RUg7A/Nar9n+qz/zE1S0iDyQZ+I+YDxrOW0BcAia4puTS8S6dxztJId7yQFOLrMH7rEFFxjcfj4jQz7uS0pE4si8K7rX90N856kotxrp5GaCvIHopdv3+ajUtSIg1xF8wcZbgy/cbixqDNUSisjavcbvyyD2z 1AFPcTGA 11ij/OT2mwLS75bbkgG0b8aHQh3U+C8QQ8fZVG4uKhDPuuzBUbdbx/OZUAY9GNRro6/3AhuCYsb88XRcH6+7fxAUTQyDYe04qMtw6QvJI1Ij0OOhHdM5yz0MYWac8oezI8GDD/+TagQ8WIEoFdbmKhSoSojuvt1F4qaOAepJVkIz+Y4EowwODqv6TXIgEi7jGFzzMJl/grbGH2GQYF3LwF/xNL46aDcWDQCVDx5INC+GmEGA0Js3aEJv5hb5uhQ95qfCxZ96jEaORkWD5aGWRWWYZjId0nVUwCkiDHHqtv/5IJWorCCiL9HUVYA/4xiIl/wAaiuyGS+PklcMjpMo3/rJvbN+yQWS5m2exhXLxnjXw+FsFAZYwu6u9GXW8TtmHMlLYQ1EEgXDZnxHkH2HCmNKSoPTpOGGZdn5bo5QyBXMKxRH4/RC6hoMExpQJ2YIP2wgz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 8:20=E2=80=AFPM Sergey Senozhatsky wrote: > > On (24/08/27 16:19), Vishal Moola wrote: > > > > Or should we aim to leave zsmalloc as it is currently implemented? > > > > Is this really an option? Yup. That would be similar to your initial suggestion: zpdescs would be a wrapper around struct page and we "chain zpdesc-s together to form a zspage= ". Although, we may as well aim for an improved implementation of zsmalloc (if= at all possible) since implementing the zpdesc wrapper requires us to modify a good chunk of code anyways. That way zsmalloc gets direct wins for its user= s on top of shrinking struct page as Matthew described before. I believe you would be a better judge of whether or not any improvements are feasible (and worth the effort).