From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3E0C352A1 for ; Wed, 7 Dec 2022 02:44:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44F5D8E0003; Tue, 6 Dec 2022 21:44:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FFD28E0001; Tue, 6 Dec 2022 21:44:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE7F8E0003; Tue, 6 Dec 2022 21:44:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2086F8E0001 for ; Tue, 6 Dec 2022 21:44:09 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E2622403B0 for ; Wed, 7 Dec 2022 02:44:08 +0000 (UTC) X-FDA: 80213965776.23.A336B9D Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 9EF6C140004 for ; Wed, 7 Dec 2022 02:44:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FzBv8eon; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670381048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KbXxDs8qKafWAR7bqMoI00ZpTS2+CW/S/4T/0IodwXQ=; b=GOrFL403WHk5lRR/Y46UlQuP8JKL9gcINBnDAYeUBLujBlQqM0kYSvpr/1ENnrZKihx5LY qX4senw5jJa9ghUgIw9A19Q1xZnJPNVt2m5vOG1eutOc24CxQt9MpudzBAUuJ6kIJliVlY rmrvFKm4kQlbRfquZqgP8MBL9JKJdsQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FzBv8eon; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670381048; a=rsa-sha256; cv=none; b=W1PZUQ4XczKlvMWQeHOKMsJJSP25TiM3Vevdf1lDeWw6dbxADrU5s6rnZshr1wGjR7OhnZ AqyJwN2f9GEL/pIz4FOmpJi5tOwKLf81zJK57rcfjtlIL1gt8WPcwEhnv2O+Jjyy6lzDbs j2Oh9TzpuqnHGZRKFXx23FDuaBZH/50= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-3f15a6f72d0so66718637b3.1 for ; Tue, 06 Dec 2022 18:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KbXxDs8qKafWAR7bqMoI00ZpTS2+CW/S/4T/0IodwXQ=; b=FzBv8eonOeeQZyfeURr9aLopxT7FxdLDbDtjyt7834bRLjztrdyk7RY71F91+2l+81 eQlarU87dp3oo39ZemUgu6mxVoqK4m9b7o2xWVYga1nnzgjDqIDmtZ/BjrDDtSjzXqF6 DHpBi5+La4ZijX2hpvpN7zHEf0mcepIXJVoZHDG5FI5ujCgsq/79szOiNEim5qrm9Be+ kRfTpHT6LLpQgS9xD4/HNINLlwMtC0HShoMHIf0IzLe/c7tjA0BID+C7jOjD5eWna+TJ qJdmYX6S34JJhGGif3AGmQ+n2y+1A+o7U5IQr2R3xxRH1eHladqu6EudTtyS/sSZQOpZ ZPjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KbXxDs8qKafWAR7bqMoI00ZpTS2+CW/S/4T/0IodwXQ=; b=J0jsj+Z5bttq/+q2y8NXOHF0JhDchOR/VsA/Abm994jyiva6ZIlyPDpgNI55mGeg1Y 02TvO9UgTQkhUbVKP9XwmU2Dn0PzA3YTrJk9iUTIuJcTQNrvDTXYpLcwyJWyVmkidfg3 OlpGHaGjL16pZl+/H7a1zIOQZmrtoYo0pgKweFAs4MoZaXuP5PZLbhRuMx+yfNcVFC/6 Ohhe6fnpMIVFCVkOkJXCgSX/rfy+ebrTdmc89GKs5eQZDne6oohpR7qcXgIvJfKvad87 VusaLRp2US+ntxj0FckY+MGLtpCHBnzpMHYLMnH7qvkRar+l6022HyL8LIPSxgagiCkV KPjA== X-Gm-Message-State: ANoB5plUjl0a9SWhndYkGI7qrOK6HlUYCrDuOQMzGkJyutZv7JlhiU/1 JQHuQ1N7f8cP+DRRGtXJGs01PJI5eqd1pdQy2/w= X-Google-Smtp-Source: AA0mqf4nu3gyaTzemasNgoy5PmsN4M8Y7wPhavQsBkWj7i7B2+81sTF+qDRAcFC1mOjutUIGU53ODw9WfmNgSMaQIDU= X-Received: by 2002:a0d:cb93:0:b0:3e4:5d25:d33f with SMTP id n141-20020a0dcb93000000b003e45d25d33fmr17233968ywd.190.1670381047765; Tue, 06 Dec 2022 18:44:07 -0800 (PST) MIME-Version: 1.0 References: <20221207002158.418789-3-vishal.moola@gmail.com> <20221207005624.146281-1-sj@kernel.org> In-Reply-To: <20221207005624.146281-1-sj@kernel.org> From: Vishal Moola Date: Tue, 6 Dec 2022 18:43:57 -0800 Message-ID: Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() to use folios To: SeongJae Park Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [4.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.128.172:from]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; BAYES_HAM(-0.00)[38.80%]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; TAGGED_FROM(0.00)[]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 9EF6C140004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nhwghc16twd1te411ynidyurmd513id8 X-HE-Tag: 1670381048-339943 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 6, 2022 at 4:56 PM SeongJae Park wrote: > > Hi Vishal, > > > Thank you for this patch. > > Nit pick. Could we please replace 'damon:' on the subject with 'mm/damon:' to > look more consistent with other DAMON patches? Thanks for looking over this patch! I'll make the subject mm/damon in a v2. > On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" wrote: > > > This change replaces 2 calls to compound_head() with one. > > I guess you mean _compound_head() calls in page_folio() that called from > mark_page_accessed() and folio_mark_accessed(). However, deactivate_page() > calls page_folio() anyway, so this patch doesn't reduce the number of calls to > one but keep the number, correct? Am I missing something? If I'm not, I'd > like to clean up the wording. The 2 calls I was referring to were from mark_page_accessed() and put_page(). As you've noticed, deactivate_page() still calls page_folio() here :). > > This is in preparation for the conversion of deactivate_page() to > > deactivate_folio(). > > I think folio_deactivate() might be a more consistent naming. What do you > think? I do like the name folio_deactivate() better than deactivate_folio(), I'll change that in v2 as well.