From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A5CCD1284 for ; Tue, 2 Apr 2024 15:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 985ED6B0082; Tue, 2 Apr 2024 11:55:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91E096B0083; Tue, 2 Apr 2024 11:55:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F646B0082; Tue, 2 Apr 2024 11:55:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 50F766B0083 for ; Tue, 2 Apr 2024 11:55:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C84001A0739 for ; Tue, 2 Apr 2024 15:55:03 +0000 (UTC) X-FDA: 81965040486.12.CDE3400 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf21.hostedemail.com (Postfix) with ESMTP id 4CBE21C0005; Tue, 2 Apr 2024 15:55:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UEBorewJ; spf=pass (imf21.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712073301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZmjL0/8sZK7haw7M72Eo2rYTS5WWFvl8Tyo4r32sEZU=; b=hDwMJ4mL92mwIIGX7W9MqCijBwggtjo8yp7W6wiRQ1H+1fBVRBaSVwiUqNGJvbd+e/JqxF /UNJBdLkfkWgjZXqpTSyZZaJjheqDYNffJPMF/lwMByQevJhlX+T89X4dzRd4tFT+JKJFU jCkpOwlnfybnNVjWYHFJ18ujoWJx8ps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712073301; a=rsa-sha256; cv=none; b=V74ZMTAvATYJrIkN2NCjiJl7JsTSVQk3tmr5efbP0PGaU0SeGV2OgzwPV5RyYQBDIo0l2u LKVwZwAx+w/N3e2HI8YFNlT6DwCmVpa91PSZKAjzMrkGvH1rsZZjjAI8DH5xXzjhXDkkeH c8cFuywEchQJ4bQkNrPFzl5dTmPPvlc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UEBorewJ; spf=pass (imf21.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dcbd1d4904dso4947306276.3; Tue, 02 Apr 2024 08:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712073300; x=1712678100; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZmjL0/8sZK7haw7M72Eo2rYTS5WWFvl8Tyo4r32sEZU=; b=UEBorewJ7Phof0eA09fon51PbO6Pq9ZjfugO8zoXWRzs/wX0ooD9uvSwb77vsJ1atw peXf//4MvPbEAdbmjQQIhaNUGs1DWE8eg0mq5Jl7stUO+K1oeUAUp28rUrBjErGI+XCh qwL30txsxufMnl1EXHBpSHAD2fk1RiLqCkZmslqcTrbI3htR7xhCvs9ihu99TNBm6Tu3 3r7/StuUpXlFzRkeAQSFkViK845QD4RBrSx3kWhfpEijSRgaC3YyFhS/faVWe8FcF7SX 2k+FHHjCoH5fFZk/6Qcg7j31AAGgDo3XSPulC5zgv6lw4YwsTK9rpRdrNYJ39ViaG8S/ Mn7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712073300; x=1712678100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZmjL0/8sZK7haw7M72Eo2rYTS5WWFvl8Tyo4r32sEZU=; b=puEcwOKbStE/aPxmMsZM4gfRpjSpuc82QzzyJipL6vGrCASkzRPACcWUUzSvhI1wMm 1btRVuD+scBtJAWO5gb8NsGIykwaeY8L9P/y9omr1RIVyqUyHDPkgyCfc4O5zXjE3E/F MhY9v0HFzscHnBeodPd0nt9zU4sJ8Wwv/SZUMw2p3vtk3GIOYjR/RseCmzN3Y0DCOAKE I90ux6VbQyzuRPxv4HmDAV9Nsm34jB188hMQ5U3ljd54gPHkHrAuHe+2tFqodIvGCP6+ 3x3irmjRMZOi/rXH+BRkrLeWJNNlOBu7n/y6WZ9lSVBEPYjEkghZSeywgd3+07qbGhLe rQcQ== X-Forwarded-Encrypted: i=1; AJvYcCVDdOCoXy0CCwfd5H/jUgH0HpqxGrRIybRh4X5kgGrt4AhLwJO3lGQnuOFxW05EjbMymTnAhiJ38TAjcQH/x7Z9hvOcCjM1qw/EXfvzpjAOgnGYEnAyfvscpT2ozMORTNyr1RyDezzw X-Gm-Message-State: AOJu0Yw9G59pHRFBNo405e4yK1SvS4PhR31m3VRfUXHvEp7VTqbvc/58 wXSgcrfksvZYxQoSW82zwq28XV4wlhOTppmwYgLI5/+AOo/WN6uL0s48XvHmu5o9Budv2Iq+bXM G1EtXnf6mpfz8J8ytEwyIjtHMJDg= X-Google-Smtp-Source: AGHT+IFSwuJ+MGJ73LzyCWn1zVg13sJL3Y2sTBYi6p0IYaA4W2WBQGsp6J3zMhCvOO6+qR8WujSPOIsPMOtnzhWK2cg= X-Received: by 2002:a25:8045:0:b0:dc6:bd4c:b119 with SMTP id a5-20020a258045000000b00dc6bd4cb119mr12094038ybn.55.1712073300403; Tue, 02 Apr 2024 08:55:00 -0700 (PDT) MIME-Version: 1.0 References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-3-wangkefeng.wang@huawei.com> <9200de40-aee5-4aee-9b78-4b93e3442d5f@huawei.com> In-Reply-To: <9200de40-aee5-4aee-9b78-4b93e3442d5f@huawei.com> From: Vishal Moola Date: Tue, 2 Apr 2024 08:54:48 -0700 Message-ID: Subject: Re: [PATCH v1 02/11] mm: migrate_device: use more folio in __migrate_device_pages() To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, Zi Yan , Jiaqi Yan , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 4mhkoyuyztunbqu4mg4esdk5k9mzaawx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4CBE21C0005 X-Rspam-User: X-HE-Tag: 1712073301-3877 X-HE-Meta: U2FsdGVkX1/oY9FdhTqeShyDcM0cx+ShVVos04EqYyk+lXlnoT0EYkIu6XD+sSC1wmFLCM+ejEeTWewiB4q4Qw2J6Jr8KSmpD0D56eVYxsGk3jyEzbYfUgychDqB8DShRHXwwPtdBR8htV3y+WMprbdapo4FgZELXrCKfNBZ4J8h5XcCMvjMX/bTFkpMjifwo9vJPUJvqLG4HUmVUc4/a/pDM+siC7gdbyXA7f+v/1IUFpPFyf6IpxmLwMmADzVbFlmJK6wkZ01Ly0ecV6LVtv+rCDMrPJIfjSZ12tOoioZgd7IAmjQRCoC7zUDtoEWD5f/XY1Du3yQ6Np2/s5mbfM+zXCkoKRouv0fZ8kaRb04BaVcdv1K3cYRNvegGT0Y+tV5v5PhrUAx/tZPrcqqYoNWjNlHgKH+tEaJBEuRZB4USmLlQ2SZhiASdv7uzIUH69qpXO3J2yyw6fl3mQnAec4RakyLbwW3dSk+h+14Th9ii7uAYdQyWOhsFRkkk5qA84BCLGPlycJpGDbWIcCRFsLG8j4aVcdkx79srY+Ujysxnc3iIrHHuilDidbvHv272JvvEaAp0cGLeYpQ75IjgzyQvWqqm/O29xSYhmaujRaDjHuVSUmRP+A1ZRjRwoQT12Ng55HD3/BGWYRzhfY29NDIO7qXtu96oMOHAd7gg34vzEi7Y/CAuq+yFqJlSkjnDWO/drb2YCc/OWMedSToiYFhihgSY+BJpYZ+11lHPseRb1FtL24A9JQIlxGZLJyxQRGfVda2MFOy9V64a0P9Rhl72dOinEpBRXNCem+9cdDmkFviqmBaxHeUdyyzKl6jPS065Vpph+BzJg8aNAx/aitwlUJWrlkvuXisLKP/vZC1YIG3WNIeVI8/DNWWkaNxvMmQNHWAp+0r8jtpMyOCzL22eL8o7SA2+Sj+cYy8KM7SImavnEKdLRgs9URZW/sv6gpR8zKXYEG9ZEnAZbR+ YR+RNZX7 qU1vvUgl6NcJ+0nCGDGCNvZ+d/nt2Tx4lG3IMzFBA+5CmP28xhvZNwTQv0KPyOLccngW2Ffn/eH1VHm1Jr0rGWvNwHKk4AlSdlFyEsbmbK92MWYFop7p2Lkyjl72zuv9MzwL2ofH+kgUEaFzltVgPE2x/uEJosSgbgg4i6+GECXSre7/bZFkdvnuP0+H+BU4RBNPqdY7ezxBoSycQyrofFMil9sVLp+eM4j8dC4NsA5cOPYDCheQec8NrF+0aJwePL+McwUebEdfppswJtdvm8+0FcQxgf0oDRjg1+/OHLws1vLRBzXJ7GK46DOhCHLW26hQ9FdZE2JHciZFpfv4rk/1oJdClxpSp5xLOjkFNoY1tD8yZv818YnG5SdEGOk+PxEF4FFGcXqf8JtpFp8bXcOkTX/w0JqMjrJ0i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 1, 2024 at 11:21=E2=80=AFPM Kefeng Wang wrote: > > > > On 2024/4/2 2:22, Vishal Moola wrote: > > On Thu, Mar 21, 2024 at 11:27:38AM +0800, Kefeng Wang wrote: > >> > >> if (!newpage) { > >> @@ -728,14 +729,13 @@ static void __migrate_device_pages(unsigned long= *src_pfns, > >> continue; > >> } > >> > >> - mapping =3D page_mapping(page); > >> + newfolio =3D page_folio(newpage); > > > > You could save another compound_head() call by passing the folio throug= h > > to migrate_vma_insert_page() and make it migrate_vma_insert_folio(), > > since its already converted to use folios. > > Sure, but let's do it later, we could convert more functions in > migrate_device.c to use folios, thanks for your review, do you Makes sense to me. This patch looks fine to me: Reviewed-by: Vishal Moola (Oracle) > mind to help to review other patches, hope that the poison recover > from migrate folio was merged firstly. I'll take a look at it, I'm not too familiar with how that code works just yet. > > > >> + folio =3D page_folio(page); > >> + mapping =3D folio_mapping(folio); > >> > >