From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F03C67871 for ; Mon, 24 Oct 2022 19:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56803940009; Mon, 24 Oct 2022 15:31:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5214D940007; Mon, 24 Oct 2022 15:31:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DE2D940009; Mon, 24 Oct 2022 15:31:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2A72D940007 for ; Mon, 24 Oct 2022 15:31:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E6BE7A0AE9 for ; Mon, 24 Oct 2022 19:31:22 +0000 (UTC) X-FDA: 80056836804.20.5EC59BB Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf14.hostedemail.com (Postfix) with ESMTP id 91A0C100033 for ; Mon, 24 Oct 2022 19:31:22 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id n130so12111617yba.10 for ; Mon, 24 Oct 2022 12:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ewURVtEZDzlu0i+gVIVlIwdo2AKdKjYywGZcJK82PeY=; b=pvb2n989P4g452NhPl3a7ovLcs0nrAlug6GLmwQOWVXp8sZf4hJMVc75J+1AdeaR5B jTPfEsL3DxRnXGA7sUdDXsbNz9yiIRbkdJnpbTPKyuqZjCtxmSrHQ8G13WCC1Iuw5z+o sb4RzMo24wxwjit5EZW/pEDJsdJvyK01K/zuT64THd3AukYqfUeJn+21U43e4WOGV7AE TRjlBL3V1r6EQNYSf744jlDgboUSn44k7FA4sUf3fJvYekNs22FOZgtNlymJimDJwZ6+ t25uP2Y+j8/iUSZasJ8p1q+kJXQcLGIToESALHyDssHFEsfrxGDSk2to5cSEMGM1zWKn AmIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ewURVtEZDzlu0i+gVIVlIwdo2AKdKjYywGZcJK82PeY=; b=MEt7qdokRuSMzXkX5scEXShlzanyDn0t3vvBJRGxrqNAsKysvmba+/PWpCwuuTvfbj PMJuBcSUiMQs61SGbzLJIiCrgsDjnoLPU6GVUDq9kdbj6aafddLZXfOXsrXJWiOH7mrX sdBQThiD1I+PPAMcfA54AFlFVEz08nc/JofBF9ltkPWCDHrJxg8eNN37AuXB/JuWbRS5 1tho/YWAJ1iaiZvh3vX+BMD3fTclNT0e1ItHOhj5X1wUsUMuBEFB6FNRon52xvlLN3Si 1ED2cn5DYY7TmT1p7AGWu+tz55GXkcf6VF3Z3HpoAzGRb5mFsR7/LfYNWPAvik6Ea+UJ KS0w== X-Gm-Message-State: ACrzQf0f5G/O2iqFlp5qLieD9t/LbIW3EZ4pqrfGei4K+jtFmSlU3har 4nvDUT3MCy7FSf/XVGruRBMHdb2VhXDPwyEX+BM= X-Google-Smtp-Source: AMsMyM6B6fNnp2prURoNrQAhN6Lbp6rH2u1B/iqqAEW6OHySGJ/tzUiCXpuF8+v7sMB52Tmf+g8Xaw+7Yytz7WdTgT4= X-Received: by 2002:a25:3bd0:0:b0:6ca:6428:ac94 with SMTP id i199-20020a253bd0000000b006ca6428ac94mr16397507yba.462.1666639881517; Mon, 24 Oct 2022 12:31:21 -0700 (PDT) MIME-Version: 1.0 References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-12-vishal.moola@gmail.com> In-Reply-To: <20221017202451.4951-12-vishal.moola@gmail.com> From: Vishal Moola Date: Mon, 24 Oct 2022 12:31:10 -0700 Message-ID: Subject: Re: [PATCH v3 11/23] f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, jaegeuk@kernel.org, chao@kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666639882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ewURVtEZDzlu0i+gVIVlIwdo2AKdKjYywGZcJK82PeY=; b=1B19yvBQaiLNhpo0rDlZix40q3UP/SvMMU7BJt3ONLFpNcNw/TVZOICOftQrQl31UOWIcK qRrP97lgzO4BPfnd7M7E+KD4n+sSG2Ok9YqccwfjI4NVYS3VDi6EiNAIRwF6K5uY/ot+z/ bfeW3zs1FzVGdmVvzvKSih0/c+vhyQI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pvb2n989; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666639882; a=rsa-sha256; cv=none; b=GGXviWr/d1E1VXZ8ur9GaiqSx8eGNoAR1FjsIET0tpHvS35hyOJih2gaeLB1GFIt4aBxgZ Iv23jMCcE4kaFrAcnrh5L/UVCNV/ZMF6CUj/gUIXmGsmIC5Sq9FjW+14H5o2JCdCmSiX0W Qx70XZ7IT/d56/uAuFh1Tem+KdR4uWw= X-Rspamd-Queue-Id: 91A0C100033 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pvb2n989; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: qk8k5ftd9cejayunpbyxqtaxog6gsqrd X-HE-Tag: 1666639882-271424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 17, 2022 at 1:25 PM Vishal Moola (Oracle) wrote: > > Convert function to use a folio_batch instead of pagevec. This is in > preparation for the removal of find_get_pages_range_tag(). > > Signed-off-by: Vishal Moola (Oracle) > --- > fs/f2fs/node.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 983572f23896..e8b72336c096 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1728,12 +1728,12 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > unsigned int *seq_id) > { > pgoff_t index; > - struct pagevec pvec; > + struct folio_batch fbatch; > int ret = 0; > struct page *last_page = NULL; > bool marked = false; > nid_t ino = inode->i_ino; > - int nr_pages; > + int nr_folios; > int nwritten = 0; > > if (atomic) { > @@ -1742,20 +1742,21 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > return PTR_ERR_OR_ZERO(last_page); > } > retry: > - pagevec_init(&pvec); > + folio_batch_init(&fbatch); > index = 0; > > - while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index, > - PAGECACHE_TAG_DIRTY))) { > + while ((nr_folios = filemap_get_folios_tag(NODE_MAPPING(sbi), &index, > + (pgoff_t)-1, PAGECACHE_TAG_DIRTY, > + &fbatch))) { > int i; > > - for (i = 0; i < nr_pages; i++) { > - struct page *page = pvec.pages[i]; > + for (i = 0; i < nr_folios; i++) { > + struct page *page = &fbatch.folios[i]->page; > bool submitted = false; > > if (unlikely(f2fs_cp_error(sbi))) { > f2fs_put_page(last_page, 0); > - pagevec_release(&pvec); > + folio_batch_release(&fbatch); > ret = -EIO; > goto out; > } > @@ -1821,7 +1822,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, > break; > } > } > - pagevec_release(&pvec); > + folio_batch_release(&fbatch); > cond_resched(); > > if (ret || marked) > -- > 2.36.1 > Following up on these f2fs patches (11/23, 12/23, 13/23, 14/23, 15/23, 16/23). Does anyone have time to review them this week?