From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAA9C02192 for ; Mon, 3 Feb 2025 19:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A62B280002; Mon, 3 Feb 2025 14:23:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95543280001; Mon, 3 Feb 2025 14:23:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D98280002; Mon, 3 Feb 2025 14:23:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64DC5280001 for ; Mon, 3 Feb 2025 14:23:22 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 18CFF1A03BA for ; Mon, 3 Feb 2025 19:23:22 +0000 (UTC) X-FDA: 83079607044.24.2D1D236 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 37A1B20013 for ; Mon, 3 Feb 2025 19:23:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="J/ZIUnuK"; spf=pass (imf13.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738610600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RDFXv1F5Ks9LCWQoNvJmEupSyk0aucGYvgHW1w2j/sM=; b=fiihNXsyjF8C5KMRlLcOZWDw1/7co4rr50TrsX23GGzwHcosv3czaokHvUrLD5saj1D+tW i1kQOXfcyL4UZ7sqhrsVr0wr6V1ap9/dqVesNydmkSnX3cy+3bVZiUPae+BynXkjbuIbys Jv7P76ZFu5S4YfxmQ7yrtWvBTQPhZ6Q= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="J/ZIUnuK"; spf=pass (imf13.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738610600; a=rsa-sha256; cv=none; b=hZMjgNS8OTWzfUIDJBHNKlIsXHe12cPcrJtcM0C3dAiVT2iVfAQ4P88xjeaUT5Y/6C+//Q ZcWLmEzXxEcxEFzlLJTMOoRT66ssVv/Gkoj9RvT7iA/j48L0da+H6wCHuE2PTagCNYpu/E ryBKwfVL6umyu9n/NbmPlI/nu/W5Ni8= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5dca4521b95so3486092a12.0 for ; Mon, 03 Feb 2025 11:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738610598; x=1739215398; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RDFXv1F5Ks9LCWQoNvJmEupSyk0aucGYvgHW1w2j/sM=; b=J/ZIUnuKSraHcZrXHH2vQdaXSYj7E+J65hUO8bMSTerMqk3u2abLfjdiUugqO+6d8m FogZE/S2KyU7wh4x4QdVNptmvKuw1HhX8jCxJ6czNe1z7iN0IelAgrM00tuhR7vJ3Deq tMdWmzK6yAYdTnC5XUCGUcVaTjtQY8iuMamVOCDhMhIop1/BjJSwVI6JYN7zivIOAWLN RkRxT53PSQFcVdoMJNqjXJJbEBjJo2EC3/zc75NShbp8/4FZWMN4A89olGpIiZF88TCT V3hDMx8JKopNBycIzKfSuE0jQ7ddtpfNkyluA1wCoc3Lff2plq3uMGIWoRiK5DezmsPi rp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738610598; x=1739215398; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RDFXv1F5Ks9LCWQoNvJmEupSyk0aucGYvgHW1w2j/sM=; b=qGMmUckZysRpTwP6JaN8efWkfETeqxh+CAoxyNnaP5f1Eom3BN1kESb15PVCxeuP2c R6lmTPVhReyW3Memk/eHi0F8PJHHD6V2NEmQIebhuVstOIrYgrMFyPdFnlSvYHWEeLyh tidFqwCknxW9Kk+ZmTPtGFt7yDJ2ZbgODfrwuFfXPR3XppludkTQpwOyiZ50aMFxFV8o KRquagaGXGpuzbST2RtEVAP5oKVq3ZpKbpYiPvFlCAyS9jiN9E18/8IVLgaU1wd9fvh1 Oefslbz6FLtVRdr/C/lebm0BmcM2KiARoc8BKaSXwpH4pIR6ls0Xvyr7b1egKegfIXHR DAjg== X-Forwarded-Encrypted: i=1; AJvYcCUg4DmUN9/rk5NqkDe73riDa+QsQbSuG1YI4gbGk98L52sV/59lEFlccswaZvXweneCt+DmCBDXVg==@kvack.org X-Gm-Message-State: AOJu0YwRGN8FhS05O17HqAwi0kOzRp3VyJEXjyUqAK8PAk6OsraiTOQM 9og35z3KtNaMroFyEFAMOc6B9NR7peZBWy0Bw4yGlUu9km+4Pu2YO9cUivTfJFvaRMm6d2yHkav rUadoQOTldEpm4onZ6JlPzHN8yA0= X-Gm-Gg: ASbGnctLlUGh+WhEi5gpu7HJP24UeUBAmYt4HuqGqWcLz44naUYBThXrLTHvStvM9J0 NTAoILQVBJxVBl4Xd+lUxThndFbyI36a5pCBRHLUVSaCbXUZyjjNe5b73entmPlRjKnCVdKc= X-Google-Smtp-Source: AGHT+IEYt+RS4nPclH5WXXjLRmq1WCNXZslhmWAX2Lei07l7NVa+K3GfS4WPsttonT3lvcR+jg3QGIJquw1G4gDT5AA= X-Received: by 2002:a05:6402:2390:b0:5dc:72e1:63ee with SMTP id 4fb4d7f45d1cf-5dc72e1647cmr16326070a12.6.1738610598400; Mon, 03 Feb 2025 11:23:18 -0800 (PST) MIME-Version: 1.0 References: <20250131001806.92349-1-vishal.moola@gmail.com> <20250131001806.92349-2-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Mon, 3 Feb 2025 11:23:07 -0800 X-Gm-Features: AWEUYZkX3o6SMugA9aoozPCgNgPCXrMAXYJeYiZLUbTCFY8OHuBfzWm38XDwmC4 Message-ID: Subject: Re: [PATCH 1/2] mm/vmalloc: Introduce vmap_file() To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 37A1B20013 X-Stat-Signature: 99jewscwwhdrgsxasb7y4bifzikifxn5 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738610599-887411 X-HE-Meta: U2FsdGVkX182oOibXi2uY9Y6+WwumM7gPQ8oA/mE/Hl+d0/SObnZhDfMldlHcYoQmrOufp9NSHYbegHp6JN1PXVIyiEQyR+CGJ3qPQ8JW1iDvPeUwlnfzv6GA8R2IP/wfoas1v1b5l+ZklhGEf7WXRJrK/CvVZHl2H9OIjlmhI0Tn8PcnuMeY8BGQQSvmduSFtRVl6KzNV2ELnyDrkdK5woMoioL85IfM7KFOgdG/2AlA8bnp/yKbuE/GMw7LksXN9ma6C3YfzVShWMXJwgFubDTJbLzhv6IEU4FAvPJ4lHxFf0xTU2GKOB8ko8LyMqGwIZojWYZMRpwaipn+EOaDArT8Jv+ItxSM3pCK2jrPWGWSdl/F2sveP0Qm7i7w7mvf5lTwPlZ0gi1jcQJKIEMTg0RPf1cACjlcCG6Mp+o8Uw99J1SxVeNP56QIDDn4LeGUSXVXhDojubdGdbl64yo52d88guooV8IPu4HEW13WLye+aYmv5dRWq8bG4FtwJHUmpU/2heXoVrCc0vEioUtaLkpjWj1V6O+KWJ9fJ0p0t1LoPqIil6wJzvJmMr2l353qmlL8ZCy0DulIeDBvPG7YGWIjY8obfweA42pLcmEtr7UKOPCvpcqx1bBLIlKejiGgn5Fmknt8QJj9JHjWZjzpRgD5XaBJOxXJn6sfIG36Gf2iFNLP0DQavWuIcRJjtALY9zgZ/h7o9d0L9TfXb4OuXZVwWezkWRojwvefYLWUN7f9fHmsUyMLSWW/SWLWS1A/yxvybbEgYQ/fDqMhVyeo1W2SWLgy/BI9N6eCdfgL2B3rNUP8d0Y4Gbwv4Ls9S+9HDVWavGo/dHpzdwiDsAPBKMaW4tkGfjrmisZI6ynWU7lCL03J2biS2pvb15V3UV+cBXYbqDDfSdpYDrW5NoJNxjQ8AKSI1+8PX7//U5a8HdKxRr+cP4Sae3mtlIy857zkrxVAlIs07B4U4/kb1D wJAMeyNF 4YjZNNwjkLur+OhYs2i8aRGecA0smjgoyqhNlS5HXo5AFd7p9b/Ozuz9bKsviMC2OYGrrRAMiXFxOU6ujciOmTYarZzWz25+baCpL0E5wxG4bBGyACrc+bU3BMuMmdMQPM6Wqpqg6HE8DO+I5w+xXkKjaZICZSdMJ6pJnarcVX0gZT2ZrsjtOi3oMAnww4L3QBpIcE8QYOtZHFyL2kfRQO03MQRaeSSjSVbZk9owJRQVcK/Gce6UPkLKGbvCJPAPET0r1xKDFW55mPepNPQJoUo3RX4xTDYtHbxM6vChKmV6HTD7mOZuVqF83ZLon+vTepspaL9bTOZKW3FMZsMLmg8tR6in43JEMgvCV6jBDMUAsf1pr7Sv7AyvLNVGteHnqScl1mZl/TqlEYy7TgdEVPx7b3oamKwJjdhwQ5yzqrgJUavaLFygQlLaJ3CSwoOz6rf7TYTltKT2wWrnWHjDZ7BTYILe3WD/uEcob X-Bogosity: Ham, tests=bogofilter, spamicity=0.014258, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 11:09=E2=80=AFPM Christoph Hellwig wrote: > > On Thu, Jan 30, 2025 at 04:18:05PM -0800, Vishal Moola (Oracle) wrote: > > + rcu_read_lock(); > > + xas_for_each(&xas, folio, last) { > > This only maps folios currently in the page cache, which makes it > usefull for everything except ramfs-style purely in-memory file systems. > I.e. for the shmem use case in the second patch it fails to swap in > swapped out tmpfs folios. Ah, I see. I can drop that patch then. Its primary purpose was to provide a user for vmap_file(). As you've pointed out, that won't work with tmpfs or anon pages. I'll hold off on a v2 until there are better usecases for vmap_file(). > > +EXPORT_SYMBOL(vmap_file); > > EXPORT_SYMBOL_GPL for any advances vmalloc-layer functionality, please. Ok, I'll keep that in mind in the future.