From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A289C7EE29 for ; Thu, 25 May 2023 17:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBFFB900003; Thu, 25 May 2023 13:12:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B70E7900002; Thu, 25 May 2023 13:12:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3943900003; Thu, 25 May 2023 13:12:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9229A900002 for ; Thu, 25 May 2023 13:12:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E3EC801FA for ; Thu, 25 May 2023 17:12:28 +0000 (UTC) X-FDA: 80829421176.29.9BBA8C6 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 6E3C51C001B for ; Thu, 25 May 2023 17:12:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hlN2P2+4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685034746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H8r4ODEq2+fLCDOwkU0I9uMZzQGsmacbN0I7clioZxg=; b=Rj6CcQZ2G0SUtVVwup46Ep1rCNc0ml14G5m4rNuLbmh87faCxIeceTZeriWaMFqE52zG4S Ar3TC1zxxtKvkTBPahgqj/dKFvrttlzS1tutDtGMSQIgdWJMSmKU8M/GOWMFu0hp1HQPVx mO+sUck2Iu7VD7hnDzLnpxOxgjnVbAE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hlN2P2+4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685034746; a=rsa-sha256; cv=none; b=ja/bK+2lTiHFLBxx5qheiioF841BmPN3Ff+pywiXKcZGXDUwhJJVdHv8NhAcUoEL/W+dVY Y/hEFyNM46lMWaeNiTHAshxA2X3hxagrBRbQLM2SuTPO+n5FXyjDYxs4jnEE12leElt12F DPpBgh25iZEBUO9/fdbJSlcXhfv6OM8= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-19edebe85adso969319fac.2 for ; Thu, 25 May 2023 10:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685034745; x=1687626745; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H8r4ODEq2+fLCDOwkU0I9uMZzQGsmacbN0I7clioZxg=; b=hlN2P2+4u+i/qYY499lGWAoyNY/dboRXOhJznjo9Nm7b8P8cZFR+c+0fCkL2rW25CD +hZ5J0+Ex4V3ScR/Xe/US44TDdlNVBI/xdsG40Ua1AXHZ442jMGry74GV2BfJq0J5IYV u7lelVrP8y0maLYqq75TrtqE6TS9ejRf7OJtZV90tVtzTBQB8gLHvCfhdBCn30nX09L2 ck5ghpRGKOeV6W36JYgZ3HGXIa/8ueDRuLasr3XHrrQINIR3LY+3Qk5dm5YcGu7+Oweg Z/YZFzs6cf7vI3ciL7ceyYyXeS7nwrYpgRm5g9mSuxHdlnBWIXgAoNtf5095aMXhJIqs nB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685034745; x=1687626745; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H8r4ODEq2+fLCDOwkU0I9uMZzQGsmacbN0I7clioZxg=; b=PeOM1PZea+i+/Yq0TxfzKtLzQHHhOTwoj6Sqib9pm7Ojy/guem9Na2xMizICJh2jw7 4QNNuTM9GFE05IFoW4pY8iWxWTCB99e3TleJCAWNMpB5p5CVx24NUe982aEq+PfXVyPe 0XjnYKy2FXeKBa0WhCSCYPZMLA/zDnxbgRisptQ+zjWk4nuX784X0lK/xl9urG2q5BHK GFtt15AFKXDObpaBZJ941w94DHiOGQ2lFRV3Wv0+57hDwvsE8btLeSTI7+YnGemfSah+ jvEk/b+H+CRLazhaX7JzfVuyKxt4MdevxBr1w3f4ktEmtgQayrF2ouHDVdp1j3KXoDWc JjFg== X-Gm-Message-State: AC+VfDx+pM1Jbm/hNZgo+q6s8epUjv9mZvS15s9yaR+Z16Hnvu1JgYSh 1PDuHU5jYPt2sagpsT0izv8KCKME7TvPlEsotOE= X-Google-Smtp-Source: ACHHUZ7vTuIkb3AY2emRZbpynC4n929WANyhiAk9Z8pBe93X++8c36ksUYj3vhKz06//2+LG6F86/hC/ahr56+n93g0= X-Received: by 2002:a05:6871:505:b0:19a:1694:f03f with SMTP id s5-20020a056871050500b0019a1694f03fmr1875889oal.47.1685034745319; Thu, 25 May 2023 10:12:25 -0700 (PDT) MIME-Version: 1.0 References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-3-vishal.moola@gmail.com> <20230525085819.GW4967@kernel.org> In-Reply-To: <20230525085819.GW4967@kernel.org> From: Vishal Moola Date: Thu, 25 May 2023 10:12:14 -0700 Message-ID: Subject: Re: [PATCH v2 02/34] s390: Use _pt_s390_gaddr for gmap address tracking To: Mike Rapoport Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, David Hildenbrand , Claudio Imbrenda Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6E3C51C001B X-Stat-Signature: d46zre6xcq6kopbnwgwmcpmh7x1rchix X-Rspam-User: X-HE-Tag: 1685034746-626899 X-HE-Meta: U2FsdGVkX1/2IRN9c7TS6dtATLW+HHM3O2a1W5rEWFqk9caCDwGccGNkJC8s5wdfnvEwFRaCtfxQy6RVkzEV/hhQy7EJdxY+ODun0ZEr8r6qfbD6I1Pr0gnVrkl/g/2Kh4H+35IYvFdIz/9R8spYbcG8zF+UtPp1vvyPml5jD2m5BFbA+w+xqOFx3LiElvy463JHqFOTLsWioTojKtsPzi1xevIEaql0KEP2dXJSpoqa0XvvdgodAPNwHB6uyQpucg0Hoc90dOFcVpE1QQwifMDSqD8uEtBbdR1c584dANG1YH/ebcKWJXgRkaAM3u7e9dGDDqeLqFnVK4BDxNawV3n8wjLmLMeievTI5qRduuvu3nR1vl4cfSPL8afQWriNcA4Rk3MnMZWDz1xQ/zM5ycZ4K6RYOamKn4y/sbbbghGFo5cxvm98/SWc9tg+v26Wmv+c43M8RuoxJBoOAXY1liadSmjYZZITiMTrkBaNa9Tly+VS1FbcAQ4Bp5FWXCDAB0GVYwRiRCyJtqdx7t4XA/rLMghZvE6A68N6O8LZToCaUImkI9PNDxCqH3h67QRAPJxihDoBv69gYK9b4JXoztMTGnQIWZRiXid5iSbQbzdGFoBMmAIv9OUWa9Np/SacKPY3BrFm3kPxxBxn6z4odEul/ePczviuZhCXZMYPTlbi0nrtjOwQcFab7dZdW9SrgMtkScV6YMoH8UoLO3PaaLCE2sQyC3cl13oddTX4Y4jiMFllegBp8T050/ydcFRNBmI5umieloUsoTFxq+EQX6Q8Ulxxit0eOwY/M176qyCSKYVQDmJEAmUKnXwLjId5eXHbRyPEfE7wTR1PAsHFsL0niXMIQJKk2ExgRaZ1l7y4gJ5Uzwtg4UuohZXdVDjBgPSqNzyfY6ZwUOguJYAmPCUF8UoImkRvkggvUhPEBVlSRDfhy99ASnVyDoATFtnW6WerJxWxImS/BYhJrq9 fPeHv1C3 tVU/KHZ7OxlKN2FGCOWpP7gq2VFo5DaSBezz5WcLdwZdXcyC6CUcsavdgqsdfyPKSAs2nNp/ip+xtANxOmlBVuGSWFvb+v2YTJSL7DbXCpgG+wLWxeqAwa20jpZNOgPnogXfHhu81OLQgHQ0mtqW5mhsJTJ8E033VYExYyifUQIfwQ0HygOO1VzrfrLhP5H8YqPn6qtMrrfUlBxluVlcDdp3CE34WCU86vwFwJrSryCzjplDC9gOXdqB9rjn9WONJ2AxF2XQkl/fxb96xLGgva9cga63xYRplLGkRS1cHCsoK5JRazMAoJCVXSscE4ySqvW8aTLT4FlsGJ9ZgANbs1BLZ0Ir2m8elGP6rg+DUxcFzQdSludljXa627s7HmfEwTlafs8NhEjRgh/lWLProJTIiGd7da9Y5GCKc5dbXVVK20nYQpCbagl1ptAXjiQ7Qpi1BwLQcgzqUwS4iO/ENRnMrCBZxpe95CBOkIhBtlM8j1TEPNfICcCpXXxo0vFJchykfPprHnrzVC+3qxbyQUjwGPzDZ3HZZj+HH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 1:58=E2=80=AFAM Mike Rapoport wro= te: > > On Mon, May 01, 2023 at 12:27:57PM -0700, Vishal Moola (Oracle) wrote: > > s390 uses page->index to keep track of page tables for the guest addres= s > > space. In an attempt to consolidate the usage of page fields in s390, > > replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. > > > > This will help with the splitting of struct ptdesc from struct page, as > > well as allow s390 to use _pt_frag_refcount for fragmented page table > > tracking. > > > > Since page->_pt_s390_gaddr aliases with mapping, ensure its set to NULL > > before freeing the pages as well. > > Wouldn't it be easier to use _pt_pad_1 which is aliased with lru and that > does not seem to be used by page tables at all? I initially thought the same, but s390 page tables use lru.