From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9B0EB64D9 for ; Tue, 27 Jun 2023 17:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 606DE8D0002; Tue, 27 Jun 2023 13:52:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5900B8D0001; Tue, 27 Jun 2023 13:52:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40A4F8D0002; Tue, 27 Jun 2023 13:52:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2E52B8D0001 for ; Tue, 27 Jun 2023 13:52:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EB5861C894F for ; Tue, 27 Jun 2023 17:52:13 +0000 (UTC) X-FDA: 80949271746.22.34CE39A Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 04D4440024 for ; Tue, 27 Jun 2023 17:52:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="jU0XSQm/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687888332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ya0gjT04wvrkPEwxsIo0SrjOZFrw43ACMJ5aI2sBKGs=; b=L0dcyukB/XGNYBwfpGevm24YB56fiFi4ULyLQ1Eg+DUWRpLYTvWQlEfc5gxM5O55QDcwYM o3srs3B84mrtac5gyWxerMoWNktzti2kN28ghxGRgGpSgfvuGvmR/zZWY3YEhuPJIclixR T3EWe+jxzjoaHj9Qo3gZJaSTXafnmg8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="jU0XSQm/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687888332; a=rsa-sha256; cv=none; b=RYOEP9H76UWOAeuYJpglNxOceAtsX5ZKQeW2vqDbRY+ww6Nr77sm7EtBCGP85PU76W1JQK H0bxP/sw3AB6q61Wdl5nSOitxedXVJk+HQVaPV3NHy2gq8SimhoBwq4GgA4jpQfSyFNfO7 4DKtBKs9+KDu/qf1VTFoPHscoYQfk1k= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6b71cdb47e1so4267004a34.2 for ; Tue, 27 Jun 2023 10:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687888331; x=1690480331; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ya0gjT04wvrkPEwxsIo0SrjOZFrw43ACMJ5aI2sBKGs=; b=jU0XSQm/UgQNqhqQcjqaxOHJKL3Tu8GM/GwEobHZGDkP+x8DVdgSjRkU85h/Lj/+te oZwK4Q1yO37Pzbn1i7oZRsd+yfivOXZX9DLv/iX+OOzSZ/17s4ytR4cUrCKbaq8ScVjb y4NBy98BQyt8WGI73+o5s1aq7cUaSdPW95ULfQ6FlPkdUprfA5PQkMvKjJsZAGVBcKqi qlieckJVpQyRqbWlQMoi71Q4k95ldkAZz69rpAi1h8kLQ3wxt3idqYMSWF1Mqn3mJooy Rs2GGbK0m2G7LUgnIAcus/1X+0dgeX1Usy3dZ/2MF2ihQvsHs5fE8nG3/WrSESAbmo+3 LPFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687888331; x=1690480331; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ya0gjT04wvrkPEwxsIo0SrjOZFrw43ACMJ5aI2sBKGs=; b=ON5c+8MPpEYWSSggLT40yrbk1m7vIy4S6JQ4Qw7KsPfPQAGNsJ7zjZGnme3jIvEsdj gPskEluotzNNCpfL6lFzUnMqL6LcWl+bk8dO7DDEM3rJTcG5KOCtACs8wdo1p/8Xpsgj wLyQ0UDB626S7p7QhCrTD3cF8laktQ+DC4wOn/uhrsjBOUZYKeTbLZnJ5otQNd6B1Mfj oEclXDBn2PEZlMzrn2aVR1OfdL2pD8pslNlWBeMATBVqrEGnInT4ZN80eV5XvZA5hI+F oTeHVIoe/IIT14vc8W2o+ckjPXHM0opPehM+QnEYlfFyEOS8gNt5al8COULkXddq9gz9 zlsQ== X-Gm-Message-State: AC+VfDwYVM4W7xA2HAM6/I0StJXF9ETSYpyK+5y/xYjLoSAywvteUlOV gumzTf4K0hoR3jtfjuwSdt9UervCeHAfdv4O7dI= X-Google-Smtp-Source: ACHHUZ60PXVLGXFjCZbPL4+H89P+QaultgII2fPTXJpRhifF/y6voZRlslPkfFetToA56imkT1WhjHNqMU1RYiBUm6M= X-Received: by 2002:a05:6359:d23:b0:133:a55:7e26 with SMTP id gp35-20020a0563590d2300b001330a557e26mr5444430rwb.7.1687888330839; Tue, 27 Jun 2023 10:52:10 -0700 (PDT) MIME-Version: 1.0 References: <20230627031431.29653-1-vishal.moola@gmail.com> <20230627031431.29653-4-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Tue, 27 Jun 2023 10:51:59 -0700 Message-ID: Subject: Re: [PATCH v6 03/33] pgtable: Create struct ptdesc To: Peter Xu Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 04D4440024 X-Stat-Signature: ope5h4h9yygow3gna7fpn49z41yjk8ph X-HE-Tag: 1687888331-858249 X-HE-Meta: U2FsdGVkX1/VPfbIyBqz5kOhP/Awr6R6BpyLblD9L07mXKH2t1MYXMUKg2/dz/zq1EvUE7MJDUS6ouZEzYlHp/okbGdXH5obezikEbWcuCn8wCtHkG6vcQtO/rF7EZzW90kfj1OzHqJN4zV/hhpwp9qMoLWNgh3tNZlFh3fgRkMSnd2dZRaKqsIJpEuEW2FOCHK2872GKNAq3IRGFutfvtwNsbYam6ErOCXxmTzVDnlXKkKSiFAUcnSBNB0rJYdNh2uVKZtKEDRYDB9uiWPkVCi6oyfiH8/yxjt4bJlCl47bu8mI60WMuV3Za9yT8QGawyAox6bGY4ZmWvZkN9PehJ4YOVv25E22/vnm5my+Aof58Puwliul8XUUWWl/0A8/jJTia1G4z9Kow8MBmuG2Fwq2PVZtdSsaA9Uhj+2+Hsy7Clhk/O2S1ajP5+2HQb9z633GuU3d7Q2ZnFKTc6AVuh8lANpxdNoM+hAASxb0vFM4pUNnKTKb8/38Gf44UsK1fLuF6S1MNFy+6KH4NNU9QxOrn0lh1o9zWHFstZpiTQmqns1IfcES7UU868sLnY9DV+37IPm9gZwIqaLiH6wxca844uIdbPdCmPtmeSqCRfgWVs38TF14FbXyfkshyAKCyL5iMblVFdBUfOH9obOrd9RQHngUVSRBL4PaDvYCDnwdUqHle+35UX/sQnrEGMAxsix/LhSQCAVK73+KHEwS8xCLzPAo891oXB/LQG8xgkbTZT/iR0eyYGoIc0LCK4FvPbpMdxgmN2fPIOT+k98thaPV3lhe1Dxfm4SVEnPSlGLNeyq8SXevBdPMLuEzE2HYMOaPEteg+XZcnXVnVPusW0+xMQzkH6Z7NTG4Rk761Cub2sr9xMCDZaLKWV1x0AZxPkp5HfnklQF4ugFB80tv4CkMwwMCQKH4qMyQzTACOkRg2CZIASoJBrv8Wxlgq5TOaBfIPJNAx5dZoNkw+Bp kkL6kCzj ODgM0AtkJY90tv7QSeGWw7Tq4Up7iO0iYn3lSIPzm51aihIp8jTdJ4zxWRaEwy9GH+jvx8IvfkITnx7J2sgsVFcH9Y53CwXDNiVSvzOpebjX66OowLIh86NjCx5OlQpuq/xHDp2zvFPdUgmAm5AvQxl9A1GDmfWmX+QVGiMi4sNRLMxjUneDjTua+eTEVvKArE7KvaJP7gz/PBJtTQCRB9046imqRlNFokfLYM/JG1MH7bs0CNY00uBJUa1eXC65DXZ9suEf2utcqMl01HbOR4aJnm+BGVWecb3HdpbXTXQ7kzEMtL2Fv6uN8RHoavAj+XvSoRTzKctOVebvgxdNki3uDhXDJkt9DsxNlFWnUC0lTqPSVPaXg5Bp0eLELpJVYWPl7LDA81f0gCbKI0tOgz+3HGsNHZ3KPRVvDkr76EXqTm0uIKpl2Me81QVtTa9e0lwmAtbIqypxV1wCM2muAT0k5jLOofY4SEwXaGztphv5aNss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 9:07=E2=80=AFAM Peter Xu wrote: > > On Mon, Jun 26, 2023 at 08:14:01PM -0700, Vishal Moola (Oracle) wrote: > > Currently, page table information is stored within struct page. As part > > of simplifying struct page, create struct ptdesc for page table > > information. > > > > Signed-off-by: Vishal Moola (Oracle) > > Acked-by: Mike Rapoport (IBM) > > --- > > include/linux/pgtable.h | 68 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > > index 5063b482e34f..d46cb709ce08 100644 > > --- a/include/linux/pgtable.h > > +++ b/include/linux/pgtable.h > > @@ -987,6 +987,74 @@ static inline void ptep_modify_prot_commit(struct = vm_area_struct *vma, > > #endif /* __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION */ > > #endif /* CONFIG_MMU */ > > > > + > > +/** > > + * struct ptdesc - Memory descriptor for page tables. > > + * @__page_flags: Same as page flags. Unused for page tables. > > + * @pt_rcu_head: For freeing page table pages. > > + * @pt_list: List of used page tables. Used for s390 and x86. > > + * @_pt_pad_1: Padding that aliases with page's compound head. > > + * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. > > + * @_pt_s390_gaddr: Aliases with page's mapping. Used for s390 gmap = only. > > Should some arch-specific bits (and a few others) always under some > #ifdefs, so it shouldn't appear on other archs? Right now this struct completely overlays struct page, so the padding as well as any arch-specific fields have to stay. Whenever we get ptdescs independent of struct page we can cleanup any unnecessary fields, as well as omit unnecessary fields from unrelated architectures.