From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F2CC0015E for ; Tue, 1 Aug 2023 17:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 935B7940035; Tue, 1 Aug 2023 13:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5ED940010; Tue, 1 Aug 2023 13:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ADBE940035; Tue, 1 Aug 2023 13:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 67E67940010 for ; Tue, 1 Aug 2023 13:23:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 290831205B2 for ; Tue, 1 Aug 2023 17:23:40 +0000 (UTC) X-FDA: 81076207800.28.21038BD Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf30.hostedemail.com (Postfix) with ESMTP id CD02A802CA for ; Tue, 1 Aug 2023 17:12:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eqleB+Pp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690909975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tjQ83+bP/eZvrnu5mLPteL9v32upNHucn015ldMT4Lg=; b=ROTdYfathDtjw21ECKaG86a2vsrBmSSGjE3bkIT5wGALR600zj9bUGYZK0n30FPHQxPZFX o5Fy4FhOvPBE8DtK86StZyvFK2E+kwmcHrl1QzrzdAeL0rRuyyIGMJnaWJCkxiX7dL56wQ i/HP3aW6vB+q2gQVp3alIA4IdOAXYts= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=eqleB+Pp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690909975; a=rsa-sha256; cv=none; b=cABWIyJZgDYajtJoTZvGo2x6bZMTfPdLYHc+PhFv8ZDDLIW/+PVIhIYXkq5NhSiq06Djr1 NorysO1V/Ad19HER86rm0G3j1/SKtD+f8oyLkUjx46RHii0EAfgyzaiOBXr5mDu6fFgB6F A+SjmbzUZB1h0xmQ0EwXNvUSVcHhenk= Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-4476a50c64bso1688170137.3 for ; Tue, 01 Aug 2023 10:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690909974; x=1691514774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tjQ83+bP/eZvrnu5mLPteL9v32upNHucn015ldMT4Lg=; b=eqleB+PpZKRzf07CkM3xQAVn2NofBi6SMHQMVVOvtjj1yAdQkkEpzST4P2npF+ejbz 6OeHxWZxrhXtqLOSpyOOfUpXFH2lHhWamSLonMZ1o9NLYn5M31P6SwoZhQMpsBD3Rgxi jKQMJxbGcSSl685ayD3GcRoQfH5mg2NTm8mJ0XSQfkMgIrKRafZUto7la0ReRcyYsYF5 6g7JxTndHY8g7HTBuN5JR1VCzQCKdRmiz2umjOQr40oPXi6MbozGZp1POTJ+c2RgDyqb MBwz+LZfTd0zNq7XYymhuV448iJei5cgunB3imBi/pb/Bc6n3nGlkvRDpu8PdAC/v1zX /Muw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690909974; x=1691514774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tjQ83+bP/eZvrnu5mLPteL9v32upNHucn015ldMT4Lg=; b=ZQ8lUwgfVkkYTinvahnLNcmFe/TYWJrnRmFnZRcRHI0gWRne33c0L5jilt2rI8Trne iBbOWwZqB0wy46QQRQ8PI8AstQz2oXQEDdLxoKIwMbRV9sE3Fd002Yz35Z2x10xhi9At kNfhw8tRmxmtmzXSjhblwPkjx4hGfsZ5xfqzVv7oDDMuAv24zmhWrwl/OVZEGTvfeIGd dAzL1jS5RtRakao0InSYVq2gQ7m3pTu0loXVIn/0VFnbLyNAZgOXwKZIa44PpFQwkqoy 0LpMOCv+ScaJfTBwkm+gQTBh4V4nMWBBuji7StPjt4qGfbTO7n9XdBAjMiPJ3hvmwhUy E7SQ== X-Gm-Message-State: ABy/qLaIu1eii8SiHfCX+kQsh1VlxnDe9MA7dcRxFCclPM0EtUW4Uowu pEPpeYN+KagFFX0Y3gQmhGbaw/mTLc/WYHxvvZI= X-Google-Smtp-Source: APBJJlGnBieFRVxRgawFgQeh8nMkgg8VXaX2ymYIkKzgsSDMdNymXxpqVlXrzhUS5zrV6ie9HEECZVtXFldDoVWXz7k= X-Received: by 2002:a05:6102:8f:b0:447:48ab:cfe9 with SMTP id t15-20020a056102008f00b0044748abcfe9mr2671039vsp.5.1690909974270; Tue, 01 Aug 2023 10:12:54 -0700 (PDT) MIME-Version: 1.0 References: <1690598115-26287-1-git-send-email-quic_pintu@quicinc.com> <20230731112155.GA3662@lst.de> In-Reply-To: <20230731112155.GA3662@lst.de> From: Pintu Agarwal Date: Tue, 1 Aug 2023 22:42:42 +0530 Message-ID: Subject: Re: [PATCH v2] dma-contiguous: define proper name for global cma region To: Christoph Hellwig Cc: Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux.dev, Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: ihh4fez9e4mu3gubjx36e38wkgjs1t79 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CD02A802CA X-HE-Tag: 1690909975-473467 X-HE-Meta: U2FsdGVkX1/dvvDQesRRF3xpk5//jvN3zp9Le6G5Vz33b5VqB03jBd/YLBT19UYpKl8dg3S0mefgTo/Uh4vEeSrMYHeiP6UPLaUVbKUeB37d1V40reLT3ovir2PQdpL8Eixl2UfhRRAweIo4xuOTNiBnPoShEJBVfxDxlFfXMRuQwyyY4KI/M1nI29NK3qw6fmt+Gc1kKYAEN/faQ+xzQtoKlYyHwZXtebdQzZEeUqK5Cj61X4BLQbzxc+6UvM37s1bb4LYXtppGU6gVmmDtz9Ua1wNM08IU4+0NGqBfRKXWbzi6iQoQ69A9L+Hu7tQiBc0b0KLQ4AJqROdJg+UMzHOQeQdmUvWF+emqWjlEvaXI+5cI+JSGbP9SzmoWGsUo+TDJiPaedVkKY0ihXMapLfTZlH8YDoyaSArlQ6uH8qRfICIzM0SC5Ym3qoA6MqmcXlPRp94PjB6PFFJtJx2mXOo65EbuxRu9GG5cDD4MkoT/oHSj/bpVywRC/HbmxIIsLcOnBTKoXbwrJCloWJn57l4h2w49jtR3LqXo8W+8vn4WPwfKyl/Ulu9sJR9nnlh2wAaqvIqLlLF5AHMH/AHn+f27nOZpv5kTjsEqjx0hXMCxrwuQnVzi4xTILaOttREOCbQLDWcK8AstlAbGgI/jUebudMwPmA3OAbX5icckuB2sDTss3tF3BG8LDb7FN5/7NgqsPnsBEt0kkQPJDUDTZWm1OocBujWrE2SexWnbRmpf6qki+rvItqiOAuaTjPWFCZyRnAvIPuHHYsrchWZk3VAPBJK8ePH1m+RcjDm/fBJU80paDm+ncGiwlX0rHrTp+fxX2V0HYFyyUdDj6LJCd9iVcAsVIkqcWgw4Y9q3B0Ze2QZ7fu+dwnR+bCgcg3GWajjRqQ2T5txaLRTGIml9/Co19RmpV+4W10qTwVd/r7ALG7MJww5szLBHG7X2YgL2wzLFX3O6CpqFrSZ88P2 34cVDPhK t+IenSs27GRjXHfgkw+dOxsDMxCk4YicK36yvb/fvlN1Zbnpz7uLRZFlt39fh3AYSxaf249hW4vkC0DRN1OhV/8Gs7m8BFMXLzbYmtnLK6ur+vnuRZ5y/E7kq19qX8Yoc6XIeoOpA7Hdu8SDwRDbdnZwAgwh/Nspd3FDJLawIJi42+jqQ498181lhNSB2WbsYzCE7XOQ9QTD/mDd0KHL1LfhB7DZGbBZhZskq7Fh0RKUsKsjQ9L506bRsiwsVH8TQ4KJC3q8Pb84lc76TvMXuoFfvWLQyUa6qJIcxJzm2+ORHhzYyPqS1QIDFZTGPjC+5XKYr42499EfXsT8Ccd9mdVhIJNwRNr2gipJDSsUWklTi5VuXndjNOkBT4r3dh2v0yNH+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, Thank you so much for your review and comments. On Mon, 31 Jul 2023 at 16:51, Christoph Hellwig wrote: > > Hi Pintu, > > On Sat, Jul 29, 2023 at 08:05:15AM +0530, Pintu Kumar wrote: > > The current global cma region name defined as "reserved" > > which is misleading, creates confusion and too generic. > > > > Also, the default cma allocation happens from global cma region, > > so, if one has to figure out all allocations happening from > > global cma region, this seems easier. > > > > Thus, change the name from "reserved" to "global-cma-region". > > I agree that reserved is not a very useful name. Unfortuately the > name of the region leaks to userspace through cma_heap. > > So I think we need prep patches to hardcode "reserved" in > add_default_cma_heap first, and then remove the cma_get_name > first. Sorry, but I could not fully understand your comments. Can you please elaborate a little more what changes are required in cma_heap if we change "reserved" to "global-cma-region" ? You mean to say there are userspace tools that rely on this "reserved" naming for global cma ?