From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF00EB64DA for ; Fri, 7 Jul 2023 14:16:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33D978D0001; Fri, 7 Jul 2023 10:16:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EDF06B0074; Fri, 7 Jul 2023 10:16:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B55F8D0001; Fri, 7 Jul 2023 10:16:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0978F6B0072 for ; Fri, 7 Jul 2023 10:16:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 843A9140D95 for ; Fri, 7 Jul 2023 14:16:46 +0000 (UTC) X-FDA: 80985016812.13.B830799 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf16.hostedemail.com (Postfix) with ESMTP id 1A473180015 for ; Fri, 7 Jul 2023 14:16:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dSuOVZO5; spf=pass (imf16.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688739404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NmhRPpdN6RIYT+v2UBFcFUNwgVlDjZy43O4KVZygLbw=; b=ixj3LiSsopEZYtD/WXTauwCZboF9sRQaixNWpAA/4U0dIM6AKH/pYiEMXaaO01Dt0KGQE6 lI07gN3/aafuYTM9DSQeAi7ZtNlcTRrv/8F5ivgTZ+cHU7Bz1HhaqQY0sZGdMoSWKs79EM FJglRYZEiphXlNbUOwibw/YOH7GZEyc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688739404; a=rsa-sha256; cv=none; b=HzLD3CQk2ZRh7w1ry00kXEITpdQkwn52inZ1ZYp2QkUjtfoDLuJt4uP4N11sngzZBbbL4K MUpiDWARSnFFxvUJjqj/jKG4dRS2VTs5vF65/9CbpX5B/XXcz4ZBevNqgv/mfm0TOKxSd8 5SjEIv3v4DlkhUULKXgDmkOW3YymuvY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dSuOVZO5; spf=pass (imf16.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7948ad98b85so617031241.1 for ; Fri, 07 Jul 2023 07:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688739403; x=1691331403; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NmhRPpdN6RIYT+v2UBFcFUNwgVlDjZy43O4KVZygLbw=; b=dSuOVZO5uuYWymoT9aMNlqPp0oxM93k6GP6GzSNRhGmMWbEoeqQq+3bUoKw6O3QXbn soCtS2hQAPpDvo4Qp75Sii9thV8JaLqH77Ynxeufw5+5NYZJyH6RB93NvzvkIy1JwaPV dtdNOLdV2iHjWkyyUR1CtE5HvwMv2ILUcTXjKocZyfM+mGUTllgQHGi4rli8mKYSy5kv dLYq+MBlCv+3DbVs6U1ZbuP5OTZrVOLWlUK7uMTuDUJxCrFMqLLi1CkNQUjwMbL+uVLZ 0yViwuZ62JOe0q/WpMLttQDFSbOPAOwN9iQAWpTf++Kk4sWocKuEPniLOcUWzijhjHVQ s5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688739403; x=1691331403; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NmhRPpdN6RIYT+v2UBFcFUNwgVlDjZy43O4KVZygLbw=; b=SaLmEWd3GKZmQ/0Hv9Fsf91DiXDR18qADX7BD6F93Y119aXLo9LMNMOkukzCu9tvWd v8WboVgU5tNny71eyn16vVrreTTCJe8BYhIx4QNN0dIBxq2MXsfkedD/L093YJUVmm6F dRLq4HOfO9hM0+JCBeBOXBREAS1PuPwvlFz1PEKRXHN6rdh+vOvNWZXI5ZP6byg2pSo6 Na/Jvmr3gBafuVQhTM92gFiUR/J2NEplN2xIBKHuYOnBbAphwvlqUB8LJKnvOpWaZ0MQ AcpAwb3PrNtQ676APHPaWDnWMaGZotlEhl02QVO7PPK27NshTxujjvHnGrOoQM38n3u6 cgeA== X-Gm-Message-State: ABy/qLbd0+83aSYpS3BcNWulCtQb4eD+ajC5GulZbzlOTi4NGe6qnRT5 fJvnCIu74JKnJJNO0TMD/HzKsjIfNlEy0KzcI3E= X-Google-Smtp-Source: APBJJlG2kFCAk8KqK1POIGReF+E3FJsIJqOmxJ/+aNyI5mGmBDQYqWzLcaY76ijRIf6azEjeI6y5UIvxjNQp+uF1V0U= X-Received: by 2002:a67:eb54:0:b0:444:481b:8ca8 with SMTP id x20-20020a67eb54000000b00444481b8ca8mr2232021vso.11.1688739402990; Fri, 07 Jul 2023 07:16:42 -0700 (PDT) MIME-Version: 1.0 References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> In-Reply-To: From: Pintu Agarwal Date: Fri, 7 Jul 2023 19:46:31 +0530 Message-ID: Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug To: Matthew Wilcox Cc: Anshuman Khandual , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1A473180015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: j86o386r8tr3t39s6dzdikx9ofqb1ysh X-HE-Tag: 1688739403-128497 X-HE-Meta: U2FsdGVkX19syXldMLoPRgczBumqrhXEYX42y3vzW8hMJvJ/6lRzzzJ0MsiUTKt9mrAdbetNwSopbewQVfroFHIOcGilcdckO44PQsuox0qb9G4NLfrzpZDcYpDX/898yAhrggJUGpj0gO2HBTsGXmQnM2CijwHosAtVIbDKpJCZxHAz4tABsTUtR8sDdNAsgeiPU8AlMQ/h7YsUbMbPCrOItHcF2T/kIjhNc88eQCd14ZUQFGVHzB1bbQF6W2hqW+F0XGUJc3dwDISo5tHLFjiBa8Ep6gzJD5qOfFrmazv7B/R+EV2YkHI1dhsh3H4zTlKgWPwmik5vSn0izY1qBUbjBnVamszYYb2L9FpU1vg4DSJHHNSGppo2WGSJQZTGKKmhsWWKIZUvE43dGYL9FTAI4D7deIp2kM9UVqViDkL85xcknxaApBndBFV9VpIP7tE8VhnTiGg43uZqt6PYpqT7U2hV2QHC78t4Z3PxdtEcFin09m6Y9epISR8myhxAUSvZCsIqhhPJ7dtDmldCbZ8/zJATJ7wj5NsrRfy6mt4GQXH8C3DVZdZnqptUMTwggPYEHrMDH0e7XZHeGt7AgwXJwTJQYeqQixb0Db702kef4f3mr9r7ac9qDYR00ChEVzem94UslzNpU0tuo3sdDwoaxYX+/DnMsmoiSuyBp5dHTejCx9Js/o8QGjWmAxRgCzQ9XxprMFz24of9IecsduAfA0fEjAS5ws+rK9ZWc3Es3ltvBubDHHdaku3knigbWeyWJluT5ZWPuOA8giF2bC4gAv0tIHR+iaVAAyDXZLCoeGkAlnp3jgEX15db29/4EDnuN4M5cu2fVmxnqOuVukFFQGpj7qE2UomzCttrHydj/mRVow9CVGqrJfMfMMU8/kqRgWoQkCs8ds9++UsT7mOnMLo0FeHfpXPM83zlZqx+fr6SywLTgDzhMyU1VEKe9/2+50Yq73yM/NgdyC9 5nxeSPSW 7wwqmKBs0LX9nObW35d1EvRP8Y3ogc3SyoDW4TlnRrvfxhDXRPkq/v/RVdvO99jaBAxXsnYrgU08ynEJIMq8FNJxGrxA87U93QZcMWa4q0l2gv5f8bJkhO7b8YLXl7VE+ejf7sG10Rbu+VuXKe8MDf4/zU+JZl5sIfdns7qvxmL437evplVFW6GYGtG7h40QrU+yTbJGOvnV0ZHahMtP3bevfVJGd7nP3Zcp9l2HWDNdS3I3au/4DptEPZK08sXHwtDHpgvUFavmmxaSjXQaKofUMvTxKe9ppFCw4pbV3M0qShY3qwheYzbFk/s5XRpePCjyHXtDD1/+GRxQ3iDYRknNIx8NKDeLPEQbKvDkZDKzilOZd6AUp6IgAln4uPtyEeDQ0ffyZfuqzCGGVjYkmSWHRbP4MgMuLpfIpO18m/OOY2bZpIsQwr34HoIMlPC/DR6PDycGLpcxMwLHGC8ZFy1pyB/S51tF5wJPgpIip7ajdi/rmfTHV+K8KaRi67arpz8V9g/KsXVR9i730Gsbb2K2WZyjq5MhwE8f5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Jul 2023 at 19:40, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 07:36:20PM +0530, Pintu Agarwal wrote: > > On Fri, 7 Jul 2023 at 18:16, Matthew Wilcox wrote: > > > > > > On Fri, Jul 07, 2023 at 03:57:42PM +0530, Anshuman Khandual wrote: > > > > LGTM, cma->name is an identifying attribute for the region for which the allocation > > > > request was made. But how about using cma_get_name() helper instead ? Very few call > > > > sites have been using the helper. > > > > > > It's not really a "helper", is it? The function name is longer than > > > its implementation. > > > > > > cma_get_name(cma) > > > vs > > > cma->name > > > > > > Plus there's the usual question about whether a "got" name needs to be > > > "put" (does it grab a refcount?) > > > > > > I think it's useful that this function exists since it lets us not expose > > > struct cma outside of mm/, but it really should be called cma_name() > > > and I don't think we should be encouraging its use within cma.c. > > > > Also, cma_get_name() is a trivial assignment. > > And in one of the previous patches we avoided function calls with > > trivial assignments. > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/kernel/dma/contiguous.c?h=next-20230705&id=5af638931eb374aa0894d8343cee72f50307ef20 > > dma-contiguous: remove dev_set_cma_area > > > > One more question from here: > > pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, > > (void *)cma, cma->name, count, align); > > > > Do we really need this "cma %p" printing ? > > I hardly check it and simply rely on name and count. > > Printing pointers is almost always a bad idea. Printing the base_pfn > might be a good idea to distinguish CMAs which happen to have the > same name? > No there is no name there, it's just a ptrval cma: cma_alloc(cma (ptrval), name: reserved, count 64, align 6)