From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD675D0D79F for ; Fri, 11 Oct 2024 14:41:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5806B009C; Fri, 11 Oct 2024 10:41:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5596B009E; Fri, 11 Oct 2024 10:41:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36CC36B00A0; Fri, 11 Oct 2024 10:41:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 129B06B009C for ; Fri, 11 Oct 2024 10:41:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93088ACA57 for ; Fri, 11 Oct 2024 14:41:43 +0000 (UTC) X-FDA: 82661585622.13.DC94C46 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 9E45A14001B for ; Fri, 11 Oct 2024 14:41:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JVf5kTG1; spf=pass (imf09.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728657666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yp8vUrCXToxwD7SSj/r6S4k+PSj7M3peewBwqhlyyBs=; b=WBnjv6c8F7Idg52X2rE1AsIhK1kpnBnQJWmD588XgV6tuAT81K65RUTT04R7qjZLoEh8T0 4OfzMKYFXgsAslgYG5UieG8g5E4DRQCJyr2+141U30UO9GUva7ShH9Ipziwq1mWcBVqneM KkRZ4XcabFiuv7L+IvCArdMn1+2QDEY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JVf5kTG1; spf=pass (imf09.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728657666; a=rsa-sha256; cv=none; b=sjUnB9i0Iiy3biAAuxxeXrusHXz1qE2h/HEPnTSpGW/h/vY6bjZPFKuHgC4unUAh5pCNrr YhCKvrt6ZyDivbftu/WjudzoDRG1tBMiwajkEWouDB1vx/IBUY5LJqpt5igZvdreknNCKu yQrtfB0jY1K15i7frPF2jGb9GjRTA2w= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a99791e4defso157486166b.0 for ; Fri, 11 Oct 2024 07:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728657709; x=1729262509; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Yp8vUrCXToxwD7SSj/r6S4k+PSj7M3peewBwqhlyyBs=; b=JVf5kTG1RZueZKO3INOckmnOfudD2ZvUfLLEbMmqmDn2DoYXRQzngeJ9r8NYj/fU1O XYBRxFILzxEYSAlLS9Q6Hv8nskCkWAwh6uX64VztFPrt4trPq9ohu+4eWVUj8xdAVnc5 Jj4GkBlZH+uxEI3musEbX7gTkSBexyTjoNCjKTulfcnLOsxHUnzPuZMcPGQON/30SylM /QIytSEinYupf56f9DAxSwIqbEnNIoU/1x1lVwnbZ1JLqiHiYatqvgs20mecd1fA4NI1 deMp04BwH508t3NGPb6b41wKrI5w5nQS939UwWOTuMCr13PeAytTHLR8Lp9edFtB9/FE FDUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728657709; x=1729262509; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yp8vUrCXToxwD7SSj/r6S4k+PSj7M3peewBwqhlyyBs=; b=k/ST84igpCFUFAkxuFAiIeS4PIVhVVQ9SJ30FiYOQ9Yf8Nzl9hivEwhTM831hHe3Zu w04Qpwxrt0rR80ownviXrOKoFUGrvt7IIdVAWFh2mbsBSoACL9TGVI3tvQn0k47+u8Ac QywltF7zU5I9jywR0TBQA/ImatVkwdzfnVFRs/THkTeI/ihxkdJfS8dcsD2mIozL9v4G 7V3AjIn9pysxL2AdKgyUwiHFDxWL8LN5GhL2WNbGJodohibZ2Ss56SaFVFOavxEm3CMS JkvynrvH481LWYM07rHNVO7QNgzQkA30gAHoIDQTLqWucq8xXd+vchsYYnufShZR2gew Td3Q== X-Forwarded-Encrypted: i=1; AJvYcCV7G8AMqQahn9FN+Q154r/PLdVR/6ZXNeIcnPnDHQ8u1+And3mlD9LoiuxzkbYjG2GqsBPhfi/+Gg==@kvack.org X-Gm-Message-State: AOJu0YxSs42G1itPdSzCsgMQd7bxiN2FWAyaGxfm+zgj2YVvpRoJlvRa WkkPD9fEN6EEao65+a7fgA6OA9Aw8oOIBtlu4sdFFfwfj8LlXMmmeNQAK8w1xBCnyaRuA+GE+3Z HxtsbEgn1BjSa0b/tS6xSbkw2EZ8= X-Google-Smtp-Source: AGHT+IEL+lzIoRn2C8CX2DEfQMcSNou7qEMI1qNEP2IU8c0FFZsDVEQIMMdeJmqWo6eCdiKH9GaZ0oKqzrkyXZHIB4c= X-Received: by 2002:a05:6402:354f:b0:5c8:9f44:a0b2 with SMTP id 4fb4d7f45d1cf-5c948c8834dmr3313318a12.5.1728657708906; Fri, 11 Oct 2024 07:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20241010175143.27262-1-quic_pintu@quicinc.com> <20241011020037.GB1279924@google.com> In-Reply-To: <20241011020037.GB1279924@google.com> From: Pintu Agarwal Date: Fri, 11 Oct 2024 20:11:36 +0530 Message-ID: Subject: Re: [PATCH] mm/zsmalloc: Use memcpy_from/to_page whereever possible To: Sergey Senozhatsky Cc: Pintu Kumar , minchan@kernel.org, akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, joe@perches.com, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: gzngx9zft71j7jyhu1epr655jan5x33q X-Rspamd-Queue-Id: 9E45A14001B X-Rspamd-Server: rspam11 X-HE-Tag: 1728657708-499213 X-HE-Meta: U2FsdGVkX1/0xCy0Lln+N9yWkhKA71blTgZZu50spkmyNmt48WleJ61GLYj5OISV4r4LpC1b2Mn9SR16MTeG1A2U8cCUB+hO181ecMod2XiFzYpD1BW4zYCLAPEq5AZVqTw000OJ6Gm+TI+G3rcfTXoNGzVqmSPHjt/oO1PzoIAaeXH71tg8n0FEfUcsvoUGc6StG9y/sHYGaKgGGsQI1NqrqJy9otfY36NBwS9IxObq7yARyw3Jx3AYBjt+kHsoB5Qu06MfZz7WssMZRsP7hvnDu6vTjdNcQ3XH5sS97V2/irJnKraNd2GB10cTPCmTFtcO96/dAca0rgkdwoA2luufoTZsbNqpIwnaBkk+9pqACZ6r/VWbMq5BTXMZnD7aHWfrdHBIHft7vH0HHlbKkjQ2UUtzCLzT86SUEAzWylxgK6mj/wE1nw53Hunytcfs86uodqwrk/3oraDtvjMphGQS10MOXUUk7pGCPsWpME32lIEV1UOv0lW1ZbuJIikh4NmuJfHqutY3nJ1fZONQYFnWGeFkmIyAkWfNq2csZMey4A7dLq4ER4DYhNmvR5n89n6MSzbNzrT8evk7uQ6R8YWz8rLGcyUm/p5I6MmrENZdUr/RnwPFsDt4m+bA4O1NHwhuQKoIKOJbjgXpTW/hv2dYJyuhJK33Vtqz/mA7xpODz6YFfMpmFk2JVM3IinBkquN2w9zU9b8Ua9/BnjWmcaTLfuMv+IpNIPbMPjGvmagta11HnixYbHijNEp/yfB4+4FhMLqdaCGBLGeyaj0VIKz2w7YgTWFxRguROEgvQ3MGg23/h/INudDr3uDvA4AfpHL9X0xGYDddMSIclnPLMkdOLuIhBFQB9htgtg6KOGDfRqAnZ73+Xzksht7IeqQpJk6Yj6pRck5ljS8JjPP2edb+Mofml9E7Kah3WWm0sTIDDZc32Dp+EOkV3exRp2bjRVS2DL+Xv99Uoc8MkPG PDLftuPe jzqzyT5dWUdFGTVLBZPcQX1s/rmg9fOjVJJEZm4tWIVI1JyG2WEmXy8R6pyhVE27hYZ6iztaOxghy3MrdHpq1yeyUwtJHjxWQ3paRndobDzn5BqoqJzPA9scHR8i1owjTiLwR5uUoGBPhKwiw6hbGnw/vLd9TLnWWkFuH/LuME/p2rln0PcwVEzevjCdIlmzrsOn4C/MJyb2tyvDJ0XfkbvFXwtMQUXeStZWPA4pjfyDHvbJA8PsPOyCS0xR9/PLvkoovNAnvVRtaVNZBhamEAww190NUG4WuUOwTHLTOvcijOZn8hu9T1QskULw3ixnTYKl+cRQVLfSoDzkdIKRMwQLKf2ZrtHQrFCoCa6OphK29GdimeiZyvQ51m6vxxkLHVfwD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000101, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 11 Oct 2024 at 07:30, Sergey Senozhatsky wrote: > > On (24/10/10 23:21), Pintu Kumar wrote: > [..] > > @@ -1511,10 +1501,10 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, > > d_size -= size; > > > > /* > > - * Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() > > - * calls must occurs in reverse order of calls to kmap_atomic(). > > - * So, to call kunmap_atomic(s_addr) we should first call > > - * kunmap_atomic(d_addr). For more details see > > + * Calling kunmap_local(d_addr) is necessary. kunmap_local() > > + * calls must occurs in reverse order of calls to kmap_local_page(). > > + * So, to call kunmap_local(s_addr) we should first call > > + * kunmap_local(d_addr). For more details see > > * Documentation/mm/highmem.rst. > > */ > > I'd prefer this entire comment to be dropped. Oh I thought the below code for k[un]map_local[_page] stills exists, so the comments are still valid. Ok I will remove it in the next patchset. Looks like there are a few more code improvements possible. Thank you, Pintu