From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C527EB64DA for ; Fri, 7 Jul 2023 14:10:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F6238D0009; Fri, 7 Jul 2023 10:10:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6058D0001; Fri, 7 Jul 2023 10:10:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE498D0009; Fri, 7 Jul 2023 10:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEE148D0001 for ; Fri, 7 Jul 2023 10:10:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 73A74C0DA5 for ; Fri, 7 Jul 2023 14:10:48 +0000 (UTC) X-FDA: 80985001776.07.4308E2B Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 95229405EC for ; Fri, 7 Jul 2023 14:06:32 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jGgqVsyw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688738792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f44kh5KTGD+QahP5UiAgfI/9olThWS/JmkuLAErq3T0=; b=2WR5aRG0YD/5bVyAcZpgVAKlEQ4JZ89Bd/5y2HGxEV16RrvODCdqcoQnr0usokd5QTO6H0 7qA6IpuXS0lvS7v58jmENYq/BACulUQos12r8SbYFJjNskLPix4oldrea1VjZd1G5NGHFJ j6lvjMuqxV5XaqeXwGIPfA1XoixEIh8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jGgqVsyw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688738792; a=rsa-sha256; cv=none; b=NObnGQsgSOBGPQZGU26ak1LcI3vyQyZgOJZLNbOsKGdGPty7aT7y0/K3haNM7y1fwlXIGo KwNweWwLEjX9pfVALlTMyv+P9FsEBBICRaxeqBuWk8426+XjpEvOCwQixDRiMp4eWX8Mt0 j6BTWYJIue/hhXa7uMF0gQYt8OjD4dk= Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-56344354e2cso1404290eaf.1 for ; Fri, 07 Jul 2023 07:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688738791; x=1691330791; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f44kh5KTGD+QahP5UiAgfI/9olThWS/JmkuLAErq3T0=; b=jGgqVsywm4x05pn/quZC2WcP5UQzn6+GjiK5WnK3egFZWjPzLhtR9Hj6d0vOkjajiO 1VoboqUJVziPsAOJfstm/gQtGiHjFXfq3BoguLr+pB8w8Z/hHKAX5nTim+jgdVWAtWoo 2EXxS7h2MIzDc+UGnHO5mEbm/j322g42IP+yfev0s4hW0a6Sai0oGw4xBUnA48mvHL8a 8yYKnH3lK4kgObRKIRVH2ShszGRo6jMQOumyxOW79GiGotzwRthxU789gJbb2PFcpwfl +mwMvbxNHh/RIqqsXPJT/lUq7ei34A67c9zJodvWK5DNom8n08meAOJ+jvxsDKbkhjoD KcwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688738791; x=1691330791; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f44kh5KTGD+QahP5UiAgfI/9olThWS/JmkuLAErq3T0=; b=fvq00at5PFqgxj9VCN2Fhsht7d1wTxZkngKtZ4dAmAaKRApo3qKYsKr8pNLo6zKkJ6 Tg0N2OlVuOQ3sqElShw8jBaPqvsbRmChdsWrYwJwRQPEL1KWs5KnXTfWqve2qEQhUlmD vyHgTSHxEMerP156Sv95aj5DQYFq/wqegNhdrYFhWGQbq+wcREx/5pSDOhwUQI8yrBi6 Z8ZEDN8mfl05J3Mj8uo7ZTI1xCQTau/YdWeONJhtYnEcYouayMzk+/E1edWp7oLIjAsL Aey1MQa4VtWEiUVn0npWTvMc5bjxCt4D/wWYzdys28hoPnZNq9GjkScxjc3gI+Mt6EdD K/Ng== X-Gm-Message-State: ABy/qLYhbtNHHwZwTEbTl8CF2eaMFkVOXlgPxWPGmxiOdGZGSg/Gl3pf zlGE2OwAZ+SwX0PcHX9sjSUHXg47BEmVvqPO0LY= X-Google-Smtp-Source: APBJJlHIm3BHdtfHYNpxw+KTddhIzWheDhiwQ9ZAAx+Ua0ezXv1nOp2mKq6rzEljAeaPoez4Sp3FZ7mNdpyqZiQxa2Y= X-Received: by 2002:a05:6358:5294:b0:134:eb97:ea01 with SMTP id g20-20020a056358529400b00134eb97ea01mr7594089rwa.27.1688738791261; Fri, 07 Jul 2023 07:06:31 -0700 (PDT) MIME-Version: 1.0 References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> In-Reply-To: From: Pintu Agarwal Date: Fri, 7 Jul 2023 19:36:20 +0530 Message-ID: Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug To: Matthew Wilcox Cc: Anshuman Khandual , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 95229405EC X-Stat-Signature: qj3ji1yp3a45czzk1x63i4m79cib45ud X-Rspam-User: X-HE-Tag: 1688738792-23517 X-HE-Meta: U2FsdGVkX19Z/rSFJ+v6GqwbZUeIDQa3jvvavnlw6zPMqSFb69XmN4P1O03UDFhh2Wcl/rteO7vI1pZOXuGJKZgFWYTv8Q8Nheg7FKV72tBGbEWoXj4cejnHW/tO5WlFzS8SeBAdeOcVbzZsNjwupln0v7niwDEzW3zXT2cz03OussLD5Nn4ziTE45HHHjnsCrBl/cifQL1lQByLj2KdOOWSTX9u1m//xy/5VacVGqwb+mIsSZ/Vkj5Etg5Bc3IasUsOg+odrP5oPooaHAIiod76RUE18dhizwntuQX58CA31EwzQShliWeQuohwYmXWRGYPCIfieITPgEG2KxL60OmVha0vId3ZtH8cZMuzKVGK8QADH0yg9KLZ9qKHG/J0rAnuoYlQbJw8TJoC+uBeyko6Kr7iLHP9KnIvoYeBa2XBcH0KXW11sUhy/RRSNaidyNxZG221koZzpEvmt6CS7f9J4QTiwtR9TSap7/1cPVtQBxkzPGshqk9j9aJJODT/OfDh4zTtEnIkUS7dEMoxNWEjhY66Yutce+c3rxu1AjErlG0seQ5vhfMG6s6Up8z9EV17/Biq53kxaVWvMj2w1Ahmf5qXESOvjS6OH3ElQMhtwjOF0zEOlj2FFXULNLX/TyFj/xgS4fc9iHUeNW9gHynp6Iqdptj5sgHM04IaE04txC470qAVro8OcWPga9myJd4fk3BjRUiC26+o3o8SpXeGwBj+03bE78mmSgYSAaKYEPE5GVaOmMBBHuDf75oFgyb9ih0wy4eWou+XRSljNkga2Msyw3V9L3H+B62Q364DtkIaE2FTeFPUvwZ50l2XEapeoFtHeBcKmM0XyEcbPEped0oLe+E6sMeI5lPCiXxFha/v0RCVXkO5eWyhYZwoa78VyYXIIGbGJFoG3AIz9yZdC/XC6ALR/Xd5j+IFct8cnedwT1uzYQMLKUYN3CN3Xp/bEungnm8W9tWPi4Q HpG7djDt AWZCaJ5TisKje88s9/4cMY9IDAYhOxuwL3NWnUL0QtiJ31lTiEiMLM3PogVoFsmGq/JTREFKY9Nh2ssOBiMDXHr3QzVgmEM0RGWRw3J9Li/CCJxTNjuDAb5RkrvzY3gh+hdkVsXDnh0eZ08670ox68HqoxrlIS3S6+yBSSXgCTJD/GMtrRdWHPVU9CplrftUOB1KmO/XpSvR5KNe0JEhUp+mCR0MkWKrSLGDGWtOGCQL5n8/JWgDlBBK4RHwbcoW2wzz0B0qYBOktCZJ0x+XcpvM8bTJV5bOq23eZagoz1NxZCzOYVO4CeQxh0nghihWMBposyQcpkgipActJgTorgqwSM+kXxHzmRYnyUA7/vdAvriCp6kawyjVhXMDZC6tAs4AwEKmkS2BltIt+rk9Ud4sDdXRHVI6DhdpalAR7YXNkIq1TqHNLYeDv12TeUKBdCE8BB3xGJGnyrXPYkagAwnKTcqibf4odFePXdhuKbacBOt9pOnZN8++hu7h65Joqbn+sN24Dv9cc9ObJKN8ORkHt0cBCRQc+wXky X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Jul 2023 at 18:16, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 03:57:42PM +0530, Anshuman Khandual wrote: > > LGTM, cma->name is an identifying attribute for the region for which the allocation > > request was made. But how about using cma_get_name() helper instead ? Very few call > > sites have been using the helper. > > It's not really a "helper", is it? The function name is longer than > its implementation. > > cma_get_name(cma) > vs > cma->name > > Plus there's the usual question about whether a "got" name needs to be > "put" (does it grab a refcount?) > > I think it's useful that this function exists since it lets us not expose > struct cma outside of mm/, but it really should be called cma_name() > and I don't think we should be encouraging its use within cma.c. Also, cma_get_name() is a trivial assignment. And in one of the previous patches we avoided function calls with trivial assignments. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/kernel/dma/contiguous.c?h=next-20230705&id=5af638931eb374aa0894d8343cee72f50307ef20 dma-contiguous: remove dev_set_cma_area One more question from here: pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, (void *)cma, cma->name, count, align); Do we really need this "cma %p" printing ? I hardly check it and simply rely on name and count.