From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38794CF34B0 for ; Thu, 3 Oct 2024 16:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A691D6B041E; Thu, 3 Oct 2024 12:55:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A18966B041F; Thu, 3 Oct 2024 12:55:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DFFF6B0421; Thu, 3 Oct 2024 12:55:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6ED066B041E for ; Thu, 3 Oct 2024 12:55:55 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F8DAC1374 for ; Thu, 3 Oct 2024 16:55:55 +0000 (UTC) X-FDA: 82632893070.22.14303CE Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf22.hostedemail.com (Postfix) with ESMTP id 399C6C001D for ; Thu, 3 Oct 2024 16:55:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gpy7y6rm; spf=pass (imf22.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727974423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J2m3xY6PlLGSTN5fPr42DCOph4HTOgUFznouod/TFqU=; b=4c0YtwQOT2HsmwfDcahD1B6P0+xh3TAo8dhWI4TP/v1mVzspj8phAG82e3/toJ0PPQA5Vw D1faC3OoSg7mOUBNuefzg0Ir0WH0Vpnz1oFBNnToROGsumWenv2fFzRLK3dr6ra/kHkNXE ZDk7G+Dlh/eSs8I7FRb3Bjj4BpXctmU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727974423; a=rsa-sha256; cv=none; b=G6zS4vZD2h238JP34orJ+x62Me7PvTFNuetHKq5/HQVXIej+ofNjG5X2f7Pf00w47vH4Qv O9eyfbSrkyT0wEmU3pPHU4VXDYySXUBmVsYnSzBowGrrXTvnFbNPluhYqImgFmNTDXsikd +ecsCt2jjdT7qWbfq9wf2b4GLhq+POU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gpy7y6rm; spf=pass (imf22.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5c8844f0ccaso1560331a12.0 for ; Thu, 03 Oct 2024 09:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727974552; x=1728579352; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=J2m3xY6PlLGSTN5fPr42DCOph4HTOgUFznouod/TFqU=; b=Gpy7y6rmIY+yhKKyqu1kqJF2zkQvmtL7SVSNfUuQ8M0qq9mTj0dKA7MMTEbl0OUsCP EKhePzxVvEntECwOLyXQguskbDvKR5+KwmnOYIBGvi8DvZFRxwBoB+wPBAw9RNC+jvua 0Tovg2T4iWpGhrSrdVNVILctQXpPz8wTevWFh57EbbvYy4rEP5yTKBle3QL5vsHFhctW wjTyNMnDztMg8dJWslEfgxYxskAbNm+fBv9+fk/DRMLeUirTAm8DPI27UhUjgA/yOdWH 8gAVon70ckfhNQMjb6gKKId0gNzStZyTIEgiGLGVUav+ug2w93UdfSSoL/zkN0ldj7Pj tmpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727974552; x=1728579352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J2m3xY6PlLGSTN5fPr42DCOph4HTOgUFznouod/TFqU=; b=J//5U67bpHmMW4517p5lyjdvvhq0sb7tJFYOxCbptNvue6hLJaK0pXsL0X3jq3aAa+ NugiB+Sd+6idrwivFAajcO80Dnjlvf2kK7L5rxZhmGB9t7yI/WqHWK5Rkl//U18BfD9E 9GRsAe2t35PQ4ibxn9jQkc00rK+A2LLdzsaS2OhYa9LZuf3WcnBHOBnpoU4HXln7edPg Ho3YSWFa/RJ29TWACn4th+GRezfKwXETacswdbi5VAWk8Al+CW7lrGWKiRY/yQGaS18c M7UbnJ224cDi9VJRkd8MB/3et4btY+8d6ZEchbV9A1GA0idD0JBc+XHl3btn0ohdnowY pN/A== X-Forwarded-Encrypted: i=1; AJvYcCWmdENp3rpwoXhkROTsVhn1ZRn5J8NbmU2xHCK7KuDSdhI3i9hfXNb+Mc/oikdZBg0cB+YWc+VWSg==@kvack.org X-Gm-Message-State: AOJu0YyEFwzYh/GyQUXU75ovKlD2ffpJig6Hq3aHp4u71fFPG/eBHNrJ bWu1p9EDLcH4mvdZr5DmuK5nDL/wHXmQ3TOmhcj+hgP2RiubDzzJRbXhF/KBJU6AjOqT6BF1gm0 Z678OUqb6EPcLYYCeXvXz97R+vdo= X-Google-Smtp-Source: AGHT+IHbsiQzJ06SyZgAAiQbJMkT/n0LTtOuxJ046aHIEGJik+fIDuB4Df8JkyRU5FSXhJMEXviPOZKpTEvRrszeeKk= X-Received: by 2002:a05:6402:524e:b0:5c8:9722:f9d1 with SMTP id 4fb4d7f45d1cf-5c8b18ded1amr6832191a12.5.1727974551484; Thu, 03 Oct 2024 09:55:51 -0700 (PDT) MIME-Version: 1.0 References: <20241001175358.12970-1-quic_pintu@quicinc.com> <20241002031850.GJ11458@google.com> In-Reply-To: <20241002031850.GJ11458@google.com> From: Pintu Agarwal Date: Thu, 3 Oct 2024 22:25:38 +0530 Message-ID: Subject: Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local_page To: Sergey Senozhatsky Cc: Pintu Kumar , minchan@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, joe@perches.com, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 399C6C001D X-Stat-Signature: yrd8ffds8qbatsa5pnw3umbki3s43y5q X-HE-Tag: 1727974552-862488 X-HE-Meta: U2FsdGVkX1/F2gvxK4PYSkrnE9zwH540My7zAoRgEL3a2qC+q05Tac3ztUNx63nF36+EhNukDRlR1LXBFV4Fh2YZ3SBZwLbcH5CEdeqddIG9eF6eRzGD8ygsbmc4P3Fm1ryJs6zSj/1delvhxKkbIESUiXrM26rGeGiOCDHyJOAUsrH7ECs8wuXnV5lrh1QixBSxJ6cojaAJ/sahgFmwnQfhWnpkWjgcpLWJ6W8ZIAQuFshzWxhjoYVKCWaxOzFVO5kLGHClq0XxuUm/8EgtShTx1FD6x2RXx8OYFBfi+wf93zCyJaBOm2F1FcyH5Oq5QWjAQb3/+iNZ8tpj3ZaOuJQlfeyV5W8f4FzJ7sLX+MDSL53biuvPbpyzH7VpEXuPIaLHTkO1SRodBENwX9mpijuVDkiz+4y8hld6D/+A/IBvjjRZajN+gqzr/DG6Da1WrtHXmtaKxAcP/liPNlFc2jwrktbk+XWfbwYAPrS3Iwmlm0dESD7eWUn3JX0k8AjbHOZwaFOOoUSA9i/NnZkV58pOshEQ8lmYv8akGYZIIXug+anA++pKS0toti0yz4RcJP9OhtOW+DpM/NhwuDvLWewjsalw5NMk+427VXBHakt+HQLjxpBnnADaJcDxjwHM3utGWvEIhCSEiato4HWd37rhNL4rL1Ivwg7Bzevz89pU9RvTDNA4UqGoMUf6A02ke3abj2vDqO/7UCXzhRMOLw+0FpyYz/uR2mVe/0oN4KnaebhMXhwXMaPKcX3GXVE+NfJ7uMf0Qd8qGK8yFH1gAGUiGo4omLALd3YOdAOt5zBRfc9NgjEPcKO8AliX29BSUVdazpfNL6jJPjkZIzxq6SioCR0mkEo7WJXPTC2OqaO/TyFtHUdAtkIYGkYgYRj7nbtKdVcyVQEkNlCOCQ/oMhijPQn2MyXXseAemC9fH+Gw0evWPTXGi+OtfTkxKtglW3ri+2+NM3y0zaKfoF0 T0OpeXxS v/gYXNq97cfJ09lG+6MbzAJoL4tkPjNXK4O3DIz8j8a4ywlQfNWSwSyxwUqjduHeiuvkf0OypqLvDC7wSIB/wngNYzu/HHrHZUlI19mUREkcJS6M28uY7cz3bZGURmd6m/xintaPvZB+7hPnknyWPODX2RuErbvUl2tGtgsSlU97BKTVfO2mAwy09S8dwdQG0jDxF15CvAlFX9yclIrKx298RJGQyXmmC9YnxGWiulULoAft4KG1ZpFGUOYaGAathCUkPdlHjqClj54Lbc+SAX8jR2UL0WKtQK0oa05CCABheGkL6sYTDUyS1vQtyifmtjEnrtK9vH9e5w9z2lrVe8BONvomDh/a5YlBr8O2UG9DYdUHZeuZMygattI77NTH5xtnUbUaxseh5EG+BzqAeP/0GoIJrf/qL9HqV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Sergey, On Wed, 2 Oct 2024 at 08:48, Sergey Senozhatsky wrote: > > On (24/10/01 23:23), Pintu Kumar wrote: > > The use of kmap_atomic/kunmap_atomic is deprecated. > > Replace it will kmap_local_page/kunmap_local all over the place. > > Also fix SPDX missing license header. > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > > > WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead > > + vaddr = kmap_atomic(page); > > > > Can you also update the comments (that mention kmap/kunmap atomic)? > Oh yes, sorry I missed it in the patch. Thanks for pointing this out. I will also check Matthew's comment below and fix it together. Thanks