From: Pintu Agarwal <pintu.ping@gmail.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Pintu Kumar <quic_pintu@quicinc.com>,
minchan@kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
joe@perches.com, skhan@linuxfoundation.org
Subject: Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local_page
Date: Thu, 3 Oct 2024 22:25:38 +0530 [thread overview]
Message-ID: <CAOuPNLiJHRL+7B9FkmK_x3gcjwrAfNaRR6mrYy-AwT_M5yaiww@mail.gmail.com> (raw)
In-Reply-To: <20241002031850.GJ11458@google.com>
Hi Sergey,
On Wed, 2 Oct 2024 at 08:48, Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> On (24/10/01 23:23), Pintu Kumar wrote:
> > The use of kmap_atomic/kunmap_atomic is deprecated.
> > Replace it will kmap_local_page/kunmap_local all over the place.
> > Also fix SPDX missing license header.
> >
> > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> >
> > WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead
> > + vaddr = kmap_atomic(page);
> >
>
> Can you also update the comments (that mention kmap/kunmap atomic)?
>
Oh yes, sorry I missed it in the patch.
Thanks for pointing this out.
I will also check Matthew's comment below and fix it together.
Thanks
next prev parent reply other threads:[~2024-10-03 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 17:53 Pintu Kumar
2024-10-02 3:18 ` Sergey Senozhatsky
2024-10-03 16:55 ` Pintu Agarwal [this message]
2024-10-02 3:38 ` Matthew Wilcox
2024-10-03 18:07 ` Pintu Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOuPNLiJHRL+7B9FkmK_x3gcjwrAfNaRR6mrYy-AwT_M5yaiww@mail.gmail.com \
--to=pintu.ping@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=quic_pintu@quicinc.com \
--cc=senozhatsky@chromium.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox