From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF15D6E2B1 for ; Wed, 20 Nov 2024 04:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 668686B007B; Tue, 19 Nov 2024 23:40:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6197F6B0083; Tue, 19 Nov 2024 23:40:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DF466B0085; Tue, 19 Nov 2024 23:40:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F1AF6B007B for ; Tue, 19 Nov 2024 23:40:11 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A71EF809A3 for ; Wed, 20 Nov 2024 04:40:10 +0000 (UTC) X-FDA: 82805220834.02.85D9C17 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf19.hostedemail.com (Postfix) with ESMTP id C8CA51A0002 for ; Wed, 20 Nov 2024 04:39:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Mm/iwWcr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732077473; a=rsa-sha256; cv=none; b=lSFhIgYMImMVSPIasHtO5IxpOiR10TvbCa/z4OPQI5byh/65+ThrHL8Fg/PsWEYntKdv8u YsnqMXR92oJURoYEUbpPbGRrqxevg1E3M6bzfTVc/+a/wL39OkXzRj+NEdFbsb7z+BY7ZT NP9JwIr0cNpp9C6xPUS8Cbjv5RfoZIo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Mm/iwWcr"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732077473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lDSsn1BYXXDAXiWD1sg2l3m5HoKoH0Comr7O4JuesqE=; b=Gdh2crnQWQpPIm4r5eLS/LGkqTd5HldV/GX76/oD8eukNvj41KCo+AGuDd7Q+1FXQH2L7g Ca0hEfrOu68DpSU7dqG2wgn2t27AvOfjvzhgVIrWHaW3e52CisfU3SsbyMBtdsrBXksfSI kbH+XKf8HX1RYTVo+zXceMIf9pAH8c8= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5cfddc94c83so2225979a12.3 for ; Tue, 19 Nov 2024 20:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732077607; x=1732682407; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lDSsn1BYXXDAXiWD1sg2l3m5HoKoH0Comr7O4JuesqE=; b=Mm/iwWcryLZqsHeBHWQxEMAQdZUGoU4oVnRCntM/OvS6mkeztAeUZMmi/tIZ/3qpXm KkhGshsKaqDtR+6GORVYGQUDW4kt2wZo9RfX5Jy0kY5yGweNcG0TWTVQ9kk6JHncnBW3 uNpaEjrFXfkAMXVKUHAY+EBBqECn+RAIEZbpub1HY2Ddt+T8hYifPAPhxvYRXuQgfGOo C2GGyqEc2kP2XQvztiOmU1wuUgHXZg0Eo0XsmmrM3f+lySbIsnylmkDKPHJv5HvNXrPl OFp8nEAmjYLMgep0TIc6bAHe/53DZVdjZ7pPiPTw5aqR3kaW5UqvNOBWdhOPBuxzJHz+ u9iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732077607; x=1732682407; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lDSsn1BYXXDAXiWD1sg2l3m5HoKoH0Comr7O4JuesqE=; b=NCrQ9IQUxynmDxv51+4z916KcbCVFsWhMZoJI8/NLnFn5QlGdQqvXuiBmVUbWnkQks dp0QTgEiVUmUqMqBKVDiRu7ddPuWWKU95/JsWoHxlSjhTVGCld7TVx8ViqhHcnvR2T7+ vuQzx9MJzwYITiYueFirD7BLNXmERhZd5XdJn8Cg8NsJDwVGdV0VbJ+AgmzJkSbqoh7A 7vjXE2K4JtUAaS2rYdsFAYI2zhaDgBqwuIs5z3cTM7ZMQgJJzyreMqdi8l5GgiTQyj5z R93hq/dISMFH4oBSByYK+AWHdeG03AU6uldkaTynWkjJNLt2wlpYEXLnY6a64ou5pJPb 3UAQ== X-Forwarded-Encrypted: i=1; AJvYcCXJ+fKhJ4Eq6KqwFjvQwyFyeXK/F5fXdZLZLV6hQbet7VLX4QlOXWy/OrA/96X4ohi4dYjqN0hSUQ==@kvack.org X-Gm-Message-State: AOJu0YzChkPo2pHWTggAg607+Qi4bpdqX5/zsWJ1Z5Hmif/x0QasLWm9 PyE7d/+97GXjTql5XNFxAarmvDToqn1ea2/wQzDGXcLYCmvJNJEpaarDfqPVHgMaem7tSXG4RAj G7gUCafmotFx5znYl3oVJKKMV/Fw= X-Google-Smtp-Source: AGHT+IFXuWwjWwmmYva29ncqigG5pI2rfYzjNf4t5M/eO1r2z13mHBdnDmOcqzsyTIGt5O1MqaFjGsoFY4kMBmOc+cE= X-Received: by 2002:a05:6402:42c7:b0:5cf:3d13:ddb9 with SMTP id 4fb4d7f45d1cf-5cff4c7b8d4mr757350a12.15.1732077606957; Tue, 19 Nov 2024 20:40:06 -0800 (PST) MIME-Version: 1.0 References: <20241119191344.53712-1-sj@kernel.org> In-Reply-To: <20241119191344.53712-1-sj@kernel.org> From: Pintu Agarwal Date: Wed, 20 Nov 2024 10:09:55 +0530 Message-ID: Subject: Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area() To: SeongJae Park Cc: winterver <295107659@qq.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pintu Kumar Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C8CA51A0002 X-Stat-Signature: 3rhczqnuup7tujneg3pauq67gzhu8xsi X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1732077544-834057 X-HE-Meta: U2FsdGVkX1/c3B9PjccmYz3gx6gyKB71Gkyn4V4SeHOOhUh2cOj0D5/8kd5hXkbUTT4sNhYmToYus2S8qnPyPGOu9cAfmO786K7LgbvWiPRCFto+2mnuruyuJjJB9wJfXlYBSQ/hxeDmYFH097tEoaC0jst5TOclaLIwI4l4UEJC9zmFCI8y7E6Mz8HPlOSLJTk2kVUmRGbIwxQMbD31JYqfgXpoydzOSXs0fk9bp4pja6NfPpUK8yVOjG4Xz/TA3gtUF5qmRMgd7dLXTH1Sc956MfYx0AY/pSxKzhlskG7m0v3nZ6CURWv1v1NcJ7ihp/5cxSzK5qNo7Z3S1ysdUdQTvxhH2fPdW1QzHwE7jVPiItPHFfApMrJLSEh0CuxDfnyB83AcdnaIETBYadUzALdrDTGKyrj40NCgNT+MjYZkl7xB2oFzDw16CcWAYIQfXKaeDgvwwiSonGNE1WIutjsh5UoSoMJjrPJj2TYSJLhn1MYXh3CmzsaWGevLkJUIUehOVopqxmAT/q2o1XIVdgwQmzkqfgcfIUEfiR4qG7N4+vOzoIGg0NkvPXYnDDFysojphNaD5kPYTr6lDtWU27tvfVIDmL08OyhqzY0me/CNDhqCi7ObId7B3TmTxv7jlWPir5QETf/+U8vbNr1Fl2xDWkElDhy4WO/UiEhJfvQ4AGCMqUwINaJPHQvJBIYtSVt4nnVjrui5k44/FldtBlQVEmDaZVIeyBvmxwh5ZlOXtzSsvVjRJpKHOw9inVBSNUqdURDnySGtRvGUp3tLmCMtHchKr/VFkGrjbyNWlDdhEjMstEyE5e+H4FW9EzpddPxFT0fbF9bPYHmjDwHzcyD0Ky4NrbRnn8P7gMWL5sfoXkB8K2AcsrVzoaY9sCtMrgqoV3j0J09CzMPJzaoqEtsPWCBQfAg5T85Czh2PHPAV3A10Mha0miHMmwfLdnCbiA6Y/RzWpr2Bgx/WHD1 +JZU6VPU HAWuFWiJsiXajsWXWBDXNFaZZVd5K/KxZNQhG+rT3ZoyivW3Pd22F5+wj4qgbPZt+hTf3L/tC7bbjrzrn2EgZC0la+GDBHYVouNuTvXgCsNEo1QixR1+YgH5p4Ga8EoJ0PNQKWx07lgn4J/smzUMmCctYIaC7YraiD0l0Ndec3RkNbi0/GxPCRzWD00jJ9Wfz73I4JVjWDS+eauORo8C6bBQ8izzqHhVAgyXmbNn0scFgszMd1t0DZJl3/WT7Aj2GVmzO8Oh6n1JEUPyjsUvbK4RHI51vDQ3Fkjc0i5l+DPmNNgnZPUih6jLhcSHlX1JLvfGzawisd4ztpxAAfVYOCxHocXqyZFcAO4flZbG8zZ17Nn/tidZuUM1RPWRVLv0/pkZwd/LQoFkUx6+MQ+ahvsKNcF61u3YxdxbGvRI9FAhbyv9W982VNTYnn1IGB4i/shZA/uIahZnikdkwI/+HYNXZBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000919, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 20 Nov 2024 at 00:43, SeongJae Park wrote: > > Hello, > > On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@qq.com> wrote: > > > From: Jiale Yang <295107659@qq.com> > > > > Remove 'return;' at the end of void cma_activate_area(). It's a void > > function, so an ending return statement is unnecessary. > > > > Signed-off-by: Jiale Yang <295107659@qq.com> > > --- > > mm/cma.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/mm/cma.c b/mm/cma.c > > index 2d9fae939..070399bce 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma) > > totalcma_pages -= cma->count; > > cma->count = 0; > > pr_err("CMA area %s could not be activated\n", cma->name); > > - return; > > } > > Looks good to me. But, seems a same change[1] from Pintu Kumar has already > merged into mm-unstable? > > [1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@quicinc.com > Yes, this [1] is already part of linux-next now. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20241118&id=1fa00a568d113db279f683f40636cf72cf73a55d