From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCEBD3C526 for ; Thu, 17 Oct 2024 17:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 682496B0083; Thu, 17 Oct 2024 13:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60AEA6B0085; Thu, 17 Oct 2024 13:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC826B0088; Thu, 17 Oct 2024 13:23:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 286CA6B0083 for ; Thu, 17 Oct 2024 13:23:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C98F1615E9 for ; Thu, 17 Oct 2024 17:23:31 +0000 (UTC) X-FDA: 82683766200.02.18C4023 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 335CAC001B for ; Thu, 17 Oct 2024 17:23:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/NOOTbc"; spf=pass (imf28.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729185774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1k/XG1Lvb4g/ajEdhRNSXz8EKC7ci3gdhjl5GgeThA=; b=hMTI5EVBlQEHR6FjfKudEMjR8quDp800h2O9QzbZj8ySxRTXi+WKgBBiy6ck5L5A8JkadB hS+JvK3zyiwPfIlEsel8Z6Otc3wg/I+Rdxce6eFHl1SrWK0YTWMf4hyOAvxD8xSOt8qq7K sII1kfTigJWZUiJF2tSlBb8KlqwEpoc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A/NOOTbc"; spf=pass (imf28.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729185774; a=rsa-sha256; cv=none; b=8RfCrqHBQFTt6NAy0OmTd5zyWNpT4kCMBgQW9Q2nCZlauk+P0ERfw3FQ5RSw6AsqUni7zQ B3xhRPEViJ0WL58GgleoL9MGSmPfSrTCwTj+KVrRplh71Xk63IbVDKUqNO4aeP0iQsLk7Q BWOYeYymqwFlwurW/BGl9aAOnwvwv3c= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c96df52c52so1615392a12.1 for ; Thu, 17 Oct 2024 10:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729185820; x=1729790620; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g1k/XG1Lvb4g/ajEdhRNSXz8EKC7ci3gdhjl5GgeThA=; b=A/NOOTbcSnTKdPOl2SbGKDebfjErG0ErHo9EHYlECmuS5TqE/Yx9Rd3EX/k0VuNp6Y Joa3W50e9+74M76UpiLoM5LeEVCXHf8ox2NdZYDLo2oT6hG/5Wdo2BltY/lhpMuEBVs/ 0fJUfgJSSi04UoqJvp4fPZPlSAEGM74rYUMIhc97o+wzdSt/n1BhGgO/H4OA0dF0mnoa RvFbaVzSgIcsk1e3CyKY2v8DeNMDaNneAsoib9Axtx9sNE1WGZB6entdJVLY9x9LxOIy 8RbCYxAAh9oMcrUi8a/cLJJPpYXgXKP+tyGgJActup8xgUVBs5FZ+sMtMG43+4+FpIj4 Uvbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729185820; x=1729790620; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g1k/XG1Lvb4g/ajEdhRNSXz8EKC7ci3gdhjl5GgeThA=; b=JcWB9W+hChUGP58RUBa+qM5onvJFJaJ6hXoNCspBWvvUvnuBOmUJMiTCj7HzoxvG38 h6LyS2vmwXSRdgrxqyEzxjqlj9ZcO1PoITHo2tEfTk7Qw2O609HFf4cXLjxcMVBqQ+zf +LpQLCaH34D06RqVKvjySpQL/4hWvcVmECf9iz8Jecpj5Yx2q/MtqOC1jkdNFkrejv+1 4H4YeZ4zPPU1GXB1XywC+n+Dh7L9fE6xKWEaAoP+IAuMR5vMDI1g2uZ//9sgmdXNDTIV sXGxkaEyFsl2inVSxBKM6tm94y7eHzbaMGNDF43X9L0lBCI38RiBsvz6xaJtVlsFN2An aAqA== X-Forwarded-Encrypted: i=1; AJvYcCWORez9osh62LMYvG1XXTmQ81q8+9GBwuBtg6CeW3WLHBJ60u0xfaRuPsbJ9aN9z7CSq+lVXVtueg==@kvack.org X-Gm-Message-State: AOJu0YwmVuBkOfPNkomdyX9rQkJtjPqvsLAplyp+ILJooiViJ0rGxC8B jnvB0Eg3NZrTVXam+YAtNyJtvj+ckzox640q2BLNFVYvp29LIDk7Zra+PKxV2dS6i12Xeu1C/Wv VYqgtrXyCTU5Mc+cheo6quL4iQKVoF+jV X-Google-Smtp-Source: AGHT+IHwnT85QfPV7bWVNJaXIeJUZNim73/ejLbAPqm/4IpHi7VRvXETJOcws9Uro7uWa5HL6NgyaUGpH783wHWb9p0= X-Received: by 2002:a05:6402:51cb:b0:5c9:27de:6e73 with SMTP id 4fb4d7f45d1cf-5c95abf2e6cmr16148909a12.5.1729185820311; Thu, 17 Oct 2024 10:23:40 -0700 (PDT) MIME-Version: 1.0 References: <20241014183918.30123-1-quic_pintu@quicinc.com> In-Reply-To: From: Pintu Agarwal Date: Thu, 17 Oct 2024 22:53:28 +0530 Message-ID: Subject: Re: [PATCH] mm/kmemleak: fix errors/warnings for coding style To: Catalin Marinas Cc: Pintu Kumar , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 6hqm15obnhdokyoqtwqsfrxptxguygjd X-Rspamd-Queue-Id: 335CAC001B X-Rspamd-Server: rspam11 X-HE-Tag: 1729185811-559988 X-HE-Meta: U2FsdGVkX1+4yvzW+Tsq9fbXmyLXTolD2Ooql/cvjvdRbQo+vv0eaHFD/vCHvIgnkh/hAIqfoNIa/MKg+55caN3Sz7CdPqaVqUjtxcpKyqdj+YHay7jxTm05jDZ066MXbxs3+8CW0NzKdzLSoIfj4Z4I0DAkx2OZYRTUa+bUmf3DPuNvJEqYVEoYXux+YUmKE5ZGdggYrhWs/ZtK/pYPDhSC/f3DJg2H9JrtZ8V4fZODg812LdF+55jASCgqhvOGF++LA8CaseR4pRkGMkoSwYFEB2GrCO6PPSOlo2m4A50u2dLeBR/Ozs/YASQtoW8bu11M3FnAhSZI9MNYyYr4ZRlaScoFrwl0jDIkMW5FQsD11AGrB5wF3TWqx+cVBUrDDVtyrqPSwv/ARVbuYfK8IBSHQx93MzmIbORUGtqsDwekc7u7T4wWNsAfUm79oo/hkx0Ddsgf/o+y91J1q5zeznXZ5WvA6ggBQC+VhHqZzZTAMjCJAakIyN2E/1gGhxJ0M8RbORhT0uZ2GFLPIruUg8b9ekk9rWCY7pQVR1bMUhT8tsfZubQHT6qY1gEtzu8dmbiHtXfuR9ZjIMtP5zguB2UktX6ljIu+GBNCInTfWSwKQ4RH2zXxsZowqzECAwmZBkB98ZJDcMhFxKZaTUDbYzBKG4ky8uRlCTf7767q+eg5UfgL8kN3KdvgBqTmDoms/kEfLPPQT8lqh39AQep6Jo4kBK2c3fnsGoL0IwjGWRgtwuyr2wC6SIKoyjEf5IntiOOWg9Cel07JYymBQGP2cYbSLgDKhfQdM6lp4eC/bVCnF97ydMpCESVBAaqc8pLAPrwLCg7ZQijNlm5PHPwkWiBk8P8DdDWXklrHtTVOmbL6ymTOxO6PTnWqahxVSvLMA5NJChw7o3Xflf0RqtHyJtG5dRA4V7iMKwCELZWV3mcxvoj3FoLHi2Yr6z8AHsxsyQH6yrzuBAjLEP+E8ui FS+fMKOm obfaKfudpL/sdb1rySpo08CMYFuP09tQ+QwXwaqIXrU1dLTvOFk35HXylSqVWMsN9j1u4q8whS0jQDt6N9yht3juranjCLKOoUV+UqCtmDNfuZrfNsklKjMV5Nb7LaazZ5sWGlBM2uHTkwVC/8GEsIz1aza52Z0PN9fdrcbVuqBwgp+ZIV5Q2pbPfo3eEy/vOUMlCWxFk+DRCUDHtfPCvFchDOP7OFzWerVpLFVwn7hZL4i0ceiRthxLLSb1dPacoeHxLE46B18vjtCLPDWY8UtaD3M5FcqMzDvg/TJFELoL5+nLqO5ml0s8ysUaVCmBAkYRKq7USNfcabB49D/WCkT9uJpDql8qkQfm7DNVDo8ia5Usw+PoAgJtNJf554yYSYDp7W6/AO/jQL0eNKVLuiIJNh7YQMlF/zWrG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Catalin, On Thu, 17 Oct 2024 at 15:10, Catalin Marinas wrote: > > On Tue, Oct 15, 2024 at 12:09:18AM +0530, Pintu Kumar wrote: > > There are several errors/warnings reported by checkpatch. > > Fix all of the positive once as below: > > - Use #include instead of > > - Missing a blank lines after declarations > > - Prefer 'unsigned int' to bare use of 'unsigned' > > - else should follow close brace '}' > > I wouldn't bother fixing up the style in existing code, it just makes > backporting fixes harder. > Thank you so much for your review. Yes, I agree but I see that this keeps growing. In 5.15 kernel there were 10 warnings: total: 0 errors, 10 warnings, 2010 lines checked But now in the 6.12 kernel it becomes 20. total: 1 errors, 20 warnings, 2253 lines checked This means new warnings were introduced while the old ones still remain. Thus I thought it's better to reduce it. > > @@ -2179,8 +2180,7 @@ static int __init kmemleak_boot_config(char *str) > > else if (strcmp(str, "on") == 0) { > > kmemleak_skip_disable = 1; > > stack_depot_request_early_init(); > > - } > > - else > > + } else > > return -EINVAL; > > return 0; > > According to the coding style doc, the 'else' branch also needs braces > here. Oh yes, thanks for pointing this out. Unfortunately checkpatch does not report this. But I tried adding braces and no issues either. I will push the new patchset with this change. Thanks, Pintu