From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7D7C4167B for ; Fri, 8 Dec 2023 15:54:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A97A6B0088; Fri, 8 Dec 2023 10:54:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2591F6B008A; Fri, 8 Dec 2023 10:54:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1212A6B008C; Fri, 8 Dec 2023 10:54:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F23146B0088 for ; Fri, 8 Dec 2023 10:54:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C33CE1A0234 for ; Fri, 8 Dec 2023 15:54:25 +0000 (UTC) X-FDA: 81544098090.30.FA9621C Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf18.hostedemail.com (Postfix) with ESMTP id 19F161C0013 for ; Fri, 8 Dec 2023 15:54:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=URz8MPkd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702050864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJckfY/O+WNBjP92Ja6mDXLeNrN1XJG5KdYfPf1kDfE=; b=ogje0zN4xwr7yUxz5DPo/Fx/mB8QP8cDn8+989PKFUFIlcR4ZtIg+3PHWCSiRvIqSqP82S nohUHTv4c9z+vdoPPH/uCGhtYgHcVG+VHN/7Vak6pLIV/aVL+cn9coxEVNalpWiJZztXmi 8Y3h611MvLw/bf58q43XTwebc6DPQl0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=URz8MPkd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702050864; a=rsa-sha256; cv=none; b=HCjB1nEjrGnGSZ49jwqGikzA0zth7Qqj+qOc5T92B+o5uRHqBNQgHKmELUVUvCNQOT2UM9 HypWDI019ZXDpmuaDu3lHdKdMf+2knmCHDijk+wEY0Wh04BS2CAIuajIzjljpckABEIrlW gsFjrw7ZLcrTv3ewCThrYumrABCfbrs= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7c5634d3189so1175826241.0 for ; Fri, 08 Dec 2023 07:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702050863; x=1702655663; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HJckfY/O+WNBjP92Ja6mDXLeNrN1XJG5KdYfPf1kDfE=; b=URz8MPkdZyCA+2nyToJH2LMIStqgf5UWu6QaeKKYwgRzeZ/kYsGirN+AVozrFH2zr1 I2RUeCiEA9tuNcGlSL0sBhcdQBi+/yjAhXBJixt1hJAd7xg/7zTDIdMPDBTN5aRezTi8 60ndcFtBHUvuvTen0YKOTYzYnZ8XaOHC3KRyRcsEWz8lr9P7bwwlboHRMksEQTebMZba IwflcfMvkm7nDrrCtu9Nlad/+MnQq1VmclLGtPa+jyVYIGRE5H14x2xWtgBvRZ9xgfYA IO4soYSl8Vj5ZclKyh0DdN4QtdvpiCQp8TyCfr9AK1hO5QX94j2apV0Jr2MGOoMuoTes 7E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702050863; x=1702655663; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HJckfY/O+WNBjP92Ja6mDXLeNrN1XJG5KdYfPf1kDfE=; b=ou0GrMbp3MEjIvN4nvkm2MpI0TXgU5HhEWhB1AaMArBx2eB80KfxOjrn9n8xVJgL1n bBJ86r1xMPFw8pXDh/hG0HpZowG21sn1y9WJmlthk7VQ3xUVMS1hJZ+t7Ykcrb8COcer ZRfSSschWYIvlam6Aet+2ziS4ffvSMAOYLwhyYD9Akj2mMIjldUpbq1jboA7fvYUIqf6 Ek9UrU3Lwa03lx7rF4SrYcLdL2eV5MLAWNiDmx9KZlEWcy6HW1SgtgzsJDchFPa+0+C0 Kc8xegkMgwLHtShKmcZj4I0NNZIyKZcrjqxFytiK6zKPdnad9x3f1p7MiCz7dHPMx6zG JRfg== X-Gm-Message-State: AOJu0YyAr1r0yrH1pZjKE+OiRFg53/6p4MJWVNBnT9Awk3ArXQaXIhA+ HPTZlmGDxHVckRB8d88Zb4A8zkgHNhdko6TyRBk= X-Google-Smtp-Source: AGHT+IHqBcm+dyGPEwNbp3iBaa2Wq1bBEaTn16dQ0uJjK1ajD86blAwTvlSgHu6XUY+NKK3+3Id6Eb+/MX/wT5gCikk= X-Received: by 2002:a05:6102:1007:b0:464:a0f7:6ce6 with SMTP id q7-20020a056102100700b00464a0f76ce6mr870724vsp.13.1702050860319; Fri, 08 Dec 2023 07:54:20 -0800 (PST) MIME-Version: 1.0 References: <20231206151134.26052-1-quic_pintu@quicinc.com> In-Reply-To: <20231206151134.26052-1-quic_pintu@quicinc.com> From: Pintu Agarwal Date: Fri, 8 Dec 2023 21:24:08 +0530 Message-ID: Subject: Re: [PATCH] of: reserved_mem: fix error log for reserved mem init failure To: Pintu Kumar Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 19F161C0013 X-Stat-Signature: 6noye8be4dd31pmrcyedgr3ixg8cb59k X-HE-Tag: 1702050863-288291 X-HE-Meta: U2FsdGVkX18gniEoXbx1k4MXmCV9GxGDXpSvd1j27Fw8Rkb0LGY2wA3U3VClu2NXE38f+PD6YYfcLELty91EDXRzZ0Tof09Fk89rjiHCr0SAgYDA5gs77wTukXUQGoXk1HcsS9LAFNP3kefw09cFT7+xDNdtTRNGLWsHm+jAclUetOZEejj70ykHsvxAOMqXLKDMlWKeJtB+V1k5orMGV/D8C2yLLB3DZ1vXZx7Mvl3X6Uh7eEDYoQajLiiARDu+eg/3FBRK1HQcBEk3Y0+yjHmgOeGGjCnr8ZwTgoaj1k7u+ulOxikst1/NpIohNGDyORmvH4ZX65RGyoNnfQqGVF1b8YLxhyaL/0Iitf34uV1ugsjzTKfNKlIpzxAZafizZ+cc+UlUTsABStdFlv+V1TLQM/UVYHYd6FI4UTgft/sDsG4RBxBZvvGziKXKfE8fM+KJn8OjpM8Ms8yM0WsKFDZIusvjdMHMzup+5Jkrf4+ydm0VgnfLJDsbGRA9pPu4/3YhJ08alOC4y2jDTcrpLmcHf8cj4Dz+hWEipAHVvxpt/2AupBnvHRGnDLJ3Q4+9xcPSTKfFZzy1UxOZAR3WWQGo73nu8rvBJoEAY6niVhR8THlnjhDqwy/t+LOyEDs62sSg3BS0yZ1bqoMacwCXcw/Tqjw9XPIZUWCU4eRS67iW9QCTh+ayvkfbt6vRQR76T+sGIC9xhBYkLbWgxyqPQ3iGNBA/w9z/1Nph8nlEKIFBJG6xN6ppBHtlBGplmE5zYW6M5cASFEBSu29QoCfxxsLUKgv5eXXZctJmq5H14uU+8wElPRQ3m/4ikp/rtZ3lXgWUKGFuXXA51wjUQk8FzNBwg5Od3DlTi4PhiOx9rVTwXPWw4LToAJHfVB7UdfDvX/JhHUQVi42A9tFRKRR5pvBhLv0vio462SNyVZUKjjbKE+MPhqzaoNUsXXxLpRcT5EQ6NzU9bDVenQXsP6D tI6sJXRt EId4QNKH/t2ym0STLncI4td+2tKpdek9EKCWONBStSxYtNtjJg2AfWBkorss4E8yB+6ksiKHp9A5VzqazWvejv0Yf/XB51v8ce6LdVFk9c+cij0mjfGaAcaIrZzw/EvIXdogjYOBuh41+rMjovqdKuSqZ379Tpb+PB/h39/Q07BNUlVxFaRtvcecyVHPqauK+fi6vXhyh3AIZfxKPzi/ndVo20YfaGeoPQFQFOU/RDYsZUOSb9IR79U6pytVXerTW4DVB/A/uJRZtqFLkgwToQA5+wRfIcv99mo4itHPJ08293vfaOrLx3N4/gZ/rui++rLSy92FHwYoIqzQVoLeNONVWflAluIL521MOUQbOnbz3uwAcfeSSOvg3ReqpsrXmrn8QLzvboCc9Pd+TVEasNUgVRP0IROozqDN4H1pQh4pn24F/e7yipeaenidBlFzz5sLx4HGQcaS2pjZHTPXUmXyJ1rZWevCZVl5Q7nwxYof8AoDykMCeqZsG4z50Jgu6j+NGN1jFq7o/aob/+XJa2zTY7ZXC79suhilxclSIPTajKlP9i4s9BPI7eA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Dec 2023 at 20:45, Pintu Kumar wrote: > > During fdt_init_reserved_mem() when __reserved_mem_init_node() > fail we are using pr_info to print error. > > So, if we change the loglevel to 4 (or below), this error > message will be missed. > > Thus, change the pr_info to pr_err for fail case. > > Signed-off-by: Pintu Kumar > --- > drivers/of/of_reserved_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 7ec94cfcbddb..473665e76b6f 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -334,7 +334,7 @@ void __init fdt_init_reserved_mem(void) > if (err == 0) { > err = __reserved_mem_init_node(rmem); > if (err != 0 && err != -ENOENT) { > - pr_info("node %s compatible matching fail\n", > + pr_err("node %s compatible matching fail\n", > rmem->name); > if (nomap) > memblock_clear_nomap(rmem->base, rmem->size); > -- > 2.17.1 > Looks like the patch got pushed twice because of some network issue. Please consider this one for review. Thanks