linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pintu Agarwal <pintu.ping@gmail.com>
To: Pintu Kumar <quic_pintu@quicinc.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	 linux-mm@kvack.org, robh+dt@kernel.org, frowand.list@gmail.com,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH] of: reserved_mem: fix error log for reserved mem init failure
Date: Fri, 8 Dec 2023 21:24:08 +0530	[thread overview]
Message-ID: <CAOuPNLhVHHGa45rGvXrcYaDvxvWk7H7Ckip=jiM38ppKw_7uvQ@mail.gmail.com> (raw)
In-Reply-To: <20231206151134.26052-1-quic_pintu@quicinc.com>

On Wed, 6 Dec 2023 at 20:45, Pintu Kumar <quic_pintu@quicinc.com> wrote:
>
> During fdt_init_reserved_mem() when __reserved_mem_init_node()
> fail we are using pr_info to print error.
>
> So, if we change the loglevel to 4 (or below), this error
> message will be missed.
>
> Thus, change the pr_info to pr_err for fail case.
>
> Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
> ---
>  drivers/of/of_reserved_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 7ec94cfcbddb..473665e76b6f 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -334,7 +334,7 @@ void __init fdt_init_reserved_mem(void)
>                 if (err == 0) {
>                         err = __reserved_mem_init_node(rmem);
>                         if (err != 0 && err != -ENOENT) {
> -                               pr_info("node %s compatible matching fail\n",
> +                               pr_err("node %s compatible matching fail\n",
>                                         rmem->name);
>                                 if (nomap)
>                                         memblock_clear_nomap(rmem->base, rmem->size);
> --
> 2.17.1
>

Looks like the patch got pushed twice because of some network issue.
Please consider this one for review.

Thanks


  reply	other threads:[~2023-12-08 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 15:11 Pintu Kumar
2023-12-08 15:54 ` Pintu Agarwal [this message]
2023-12-06 15:16 Pintu Kumar
2023-12-08 20:31 ` Rob Herring
2023-12-11 14:43   ` Pintu Agarwal
2023-12-14 17:17     ` Pintu Agarwal
2024-01-06 18:01       ` Pintu Agarwal
2024-01-16 14:35         ` Rob Herring
2024-01-17 17:25           ` Pintu Agarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOuPNLhVHHGa45rGvXrcYaDvxvWk7H7Ckip=jiM38ppKw_7uvQ@mail.gmail.com' \
    --to=pintu.ping@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=quic_pintu@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox