From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AA8C433F5 for ; Sat, 28 May 2022 03:51:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384AB8D0003; Fri, 27 May 2022 23:51:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3333C8D0001; Fri, 27 May 2022 23:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE6C8D0003; Fri, 27 May 2022 23:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0B6A28D0001 for ; Fri, 27 May 2022 23:51:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D32B734BE7 for ; Sat, 28 May 2022 03:51:15 +0000 (UTC) X-FDA: 79513776510.17.BC774D0 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf05.hostedemail.com (Postfix) with ESMTP id 65CDD100053 for ; Sat, 28 May 2022 03:50:44 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id e184so1309405ybf.8 for ; Fri, 27 May 2022 20:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=orLkwKBDXLhrzD4BMFuH9kb4hQtpnaRtRA74RMpv3ig=; b=ThcmND6RFj2HLB5DknQBN270ZC7q5ZBSbUhnpvjSSxPkpgWeN8xWuH7kxfUlGvDX4U RLbW71kg8ym/EFwAXdAVnbEK2sShyDaVJEw/XQXd7oTnGyIO4zbqhx+C6w/UnhiqyK+r gWgK9LgL9tEM0fDqCJxUaOW8uk2meXg0Ih7leP537y4W0wTOnRSUNy2/nLq2ToQ7w2ew xQOCfHwwIkzPbZddQlJUC3Y92S+W6XtrKusrrHiZkTX/puTeHq/skzPAHerq0aSYI9XN FEyld4ttK60iVF0N/LStp5gDIbc+PG/spteC7pGozY3QlmlEu0CxD9rk1TlZyEknnBnI sBgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=orLkwKBDXLhrzD4BMFuH9kb4hQtpnaRtRA74RMpv3ig=; b=byfumoRHUjdbBt/GP+lX80cmRIA4zHX7ENMZegWMhKpqAIcIFQN0rIKWZ/feNlxOb8 ghTAUM1gQmdDqNysWwyupR1XrsPUGV7tfmvtzR6Z9+0WWqq6+ByosxTkxUs1TQ7yKb0Z qgKpE13Hb6lIoBNagd6OwVGikEb/HmEqKOrIofTlwBxish4RLeXLJKDeqDayhm4z536I BYqc4IKW8cbbI94nb9aJ64+H/jWwsRghg3t7nzkOpyS5QtirdEkELS8tnBAwURfpFmt4 b1XzLkIcVRt34bIAEFdpPhejt15SBBYBBhRMKKM7lBkhtHQd7uICFZAm/Be2DDTSw9dD rwiA== X-Gm-Message-State: AOAM533BNZHflnSQJ6NWTHmimx/Io/TT3oJBPIJmknV0tneYrVpyqDn3 B9NYpJ50PXpbwlRLS+MiWHiDuBHIOXH3Lgdiw9Q= X-Google-Smtp-Source: ABdhPJxxrYOkGAyX4e1QCYM6a1+xjZEfex+Ht0UhrC0tGLmf7QERIkMp3OjP4TmXl+gdHOj7c3+u9HT6TM4EjppppOI= X-Received: by 2002:a05:6902:14e:b0:64f:d2eb:2df0 with SMTP id p14-20020a056902014e00b0064fd2eb2df0mr27601593ybh.557.1653709874725; Fri, 27 May 2022 20:51:14 -0700 (PDT) MIME-Version: 1.0 References: <65f1b675-84ac-b5da-6075-2a9f0353ab37@quicinc.com> In-Reply-To: From: Pintu Agarwal Date: Sat, 28 May 2022 09:21:03 +0530 Message-ID: Subject: Re: Queries: Using ifdef CONFIG condition in dts files To: "T.Michael Turney" Cc: open list , robh+dt@kernel.org, devicetree@vger.kernel.org, frowand.list@gmail.com, linux-mm Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: u4m4p8aur7c5shphffoby14t86to4ifq X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ThcmND6R; spf=pass (imf05.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 65CDD100053 X-HE-Tag: 1653709844-815761 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000924, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry, a small correction. On Fri, 27 May 2022 at 17:06, Pintu Agarwal wrote: > > On Fri, 27 May 2022 at 15:34, Pintu Agarwal wrote: > > > > Hi, > > > > On Thu, 26 May 2022 at 19:53, T.Michael Turney wrote: > > > > > > Kernel developers correct me where I go astray, but this seems like the > > > CONFIG_XYZ value is not available in this file. This would explain why > > > the disable case works. > > > > > > At top of dtsi file are you #include or whatever the correct > > > syntax is to see the CONFIG values? > > > > Thanks for your comments. > > No, I could not find any specific config,h to be included to make the > > CONFIG values visible to dts. > > > > BTW, I tried another approach but this also doesn't work when CONFIG is enabled. > a) I have created a new header file such as myxyz.h and defined a new > macro with config check. > => myxyz.h > +#ifdef CONFIG_XYZ > +#define XYZ_CMA > +#endif > > b) Then I included the header file in my dtsi file and used ifdef with > the new macro. > > #include "myxyz.h" > > #ifdef CONFIG_XYZ #ifdef XYZ_CMA > &reserved_mem { > xyz_region: xyz_region { > compatible = "shared-dma-pool"; > reusable; > size = <0x600000>; > }; > }; > #endif > > But unfortunately this approach also did not work when CONFIG is > enabled. So, when config enable/disable its same behavior. > However, if I put the #define in the dtsi file itself then it works as expected. > > > Thanks, > Pintu