From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CBFC46CD2 for ; Sat, 6 Jan 2024 18:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B9706B0292; Sat, 6 Jan 2024 13:01:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93F0A6B029E; Sat, 6 Jan 2024 13:01:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B8656B02A9; Sat, 6 Jan 2024 13:01:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 657AF6B0292 for ; Sat, 6 Jan 2024 13:01:27 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2FC93A20AA for ; Sat, 6 Jan 2024 18:01:27 +0000 (UTC) X-FDA: 81649653414.16.31DE20C Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf20.hostedemail.com (Postfix) with ESMTP id 791E61C0022 for ; Sat, 6 Jan 2024 18:01:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=StsuhZkt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704564085; a=rsa-sha256; cv=none; b=nAzaa+ghnHZoW6mm4cOG5EPS+OlnkqZSMUW48evO1Z7b93Hz5OzANe5bMTM1BGutZPM0LZ f3vundzA7P5NaXfSyk6PzZjDZF9We3GHVflSkAv2NG6/8RjzTIh6+vi9JR3GZE4pWjLZyJ q34/qlkcIHpuDyYvCX3wYSfOhNZKXaU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=StsuhZkt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704564085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SlF5MKSukDXBsWTKudYrkR+clX5vSSACkqiWizoDMjg=; b=77+rwOKcUbe9wCf0STQZNMsFYAeE3LHo2nPnm06Msmt2MvZmHKrf0qRQokqLIYWrZ27Mvx P2cKMtwoyMhjFaKi2H7EY+x/DtvSIedtpFYXq1VyJJVfkAjwq/h9PFaXv34+xkf3V03Ujx WeD7ryUYB4DJYamJnWaVtnmV5gZ8O2k= Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6dbcebaf9a9so376303a34.3 for ; Sat, 06 Jan 2024 10:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704564084; x=1705168884; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SlF5MKSukDXBsWTKudYrkR+clX5vSSACkqiWizoDMjg=; b=StsuhZktFGKl5RBlx5HUwGoFzolF+TCKbpkZ2qYjEDacTQau8mx/FQBEPsAtRvZaS1 5NjcJmrkNy87Nd/kUgul4xUq+fbw6QvX9gJMfZC0H9pJRD6KhQqn1A+ZMtt2EzW6Xxbf ARr6b8RWDQU+ej6uaCppixSGDzWceuQBsbt8W0RVvVpQtmCy/JOnyC8myqb4TCGltyhb MDS5w6JvoHwet22paGDVcacSaqwAhDgATaHKUVSkGrHk5Fwvi71iy2Svx///TeuBaM/e iqejB97xzB4GwjthGMZXihDQslYjPzrf3jxZF5UuRsngII7MqOPx9vqYDce/Y0IwgXP3 2FXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704564084; x=1705168884; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SlF5MKSukDXBsWTKudYrkR+clX5vSSACkqiWizoDMjg=; b=YOMhgMaywFOmEXKcXt6IEOT1UyrU8C1OWf2//TvWBPBuuY4sH44B/OvZomZTPCO+i1 qqLg3+HYSPmxXWUN2cAT9VF4KaG7aT7dpDfN1JLeEiXc+ZWJnqnZFNxp1fGnApW8WPX8 SbBJEx+1mA6a8+GGf3w0Mn5xnEIbBq9H3M89lPiRkPOrJRNpLLKKyBHuyzOWuQcvch4t SARv5SLVWrobzifAh8nA1mW1E/Ad1GSE3gSNxp9ME2gURoDqdJE91pKhfrCxxkOfiZ5u flloW+Hf9nv/VZGjr7hvNxuCojTCXgBcnFpDzm4MlY8ErHkjbyqNwiSwkvvqRsiGTjKI PA+w== X-Gm-Message-State: AOJu0Yx0N1fI8TIznOI4APQiqjkSBKpV2rBLRg+ihRoS73CEyxJbI1yu UKDJRacLKmXct/d7Ums+1UuRYOU3DPydJ6uNdgg= X-Google-Smtp-Source: AGHT+IHFMAuY9wP4JZeMq0AGVSNp/s3w+mHEB0XJgEh9v1FVbyJOrTHPgtffWFKIufHuW/WwSLScpnFmGY/VTT9kHXU= X-Received: by 2002:a9d:5d06:0:b0:6db:d330:b8ca with SMTP id b6-20020a9d5d06000000b006dbd330b8camr685486oti.57.1704564084515; Sat, 06 Jan 2024 10:01:24 -0800 (PST) MIME-Version: 1.0 References: <20231206151600.26833-1-quic_pintu@quicinc.com> <20231208203128.GA2646347-robh@kernel.org> In-Reply-To: From: Pintu Agarwal Date: Sat, 6 Jan 2024 23:31:12 +0530 Message-ID: Subject: Re: [PATCH] of: reserved_mem: fix error log for reserved mem init failure To: Rob Herring , vichy.kuo@gmail.com Cc: Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, frowand.list@gmail.com, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 791E61C0022 X-Stat-Signature: pn5woo7xzgkdkt5g33mas5phpfk58gbz X-HE-Tag: 1704564085-896659 X-HE-Meta: U2FsdGVkX1+nvwhS8aaI6PYdFwFgmgdmnCk5qNbzhjJ/sf0TI8cmeOEiWOCAZvSIb3RXL+EcXuNje6gYtW+kAlYZcHg2C+PEtlfD6JvX/I+X3mbbLGoRayHwMUgZGQqMR1jXOoj27s/1nDdEu0VDxycKB64W4vGdFXWd1VYbudoxhTzpFtFZ0i2kgX+nx5HoYzyti8Tigs2hOyjPF2qGW76Iv04GpygLCKUlEKbcgoTQABSfRQwpKCyYvp5u5Vn5ndcz50DNkc+y7Wu8weE/J2IdupwuYyXTDUQ0N1L+uS5T/6n8HyjBombRrokUSIaI0oqJrkVOVGUZs5IOQmkHnEqcOAcRdehlFg+ghgaoDuVxn7WCF85izJ09Ox6uFGlf31mliusRzZk1oTZojmrGPtE03NbjQQKCAgVtgOw5BbzREOjB5ZdcY3a1Ko0f2L7GvYGuZTDEABlEs6MdCwf7NmwcahgS0NKoGvpda6J7KaG2muqumKoWAykZUPNfUyA9EaLpmECnBuxIzjSrOld+T7YPOdwNkX9wvRQQKo4PINGnUVNQkXNbs7QK6morhSZKCzc2WJGK2tYCcxfuCgybA3pfOlmxylZlmxuXcGjjUYC6OLOzPYBoiVu4g/sNKwbhE7HXjrxkA7nrkQELWMGXZieVClE1P9Yls56Qb8VpJnOeGdAFJCtqZVkEquXMkzOndYc/CGUxVMQupxLTesD7LWYoQB3DNgcTGnhC8JhR+5vZesnYHtKuezRGG4FPalAnP3sM1k3EMzvYG+a4/SOWpqm3QTR6VCcxApazD90afv5Ru/w+SeEFJz+K/CAYe5sJZAk+jPwXKAgFzwzLKrVkDRnpRwWpWUjklWgK0YFFI6WxyWnmd4wQqOtmz0Pk8Q+M0FdEGD+iJJ1filw2Frcr6QrZ3MzzCuVtD8yat2VMJ9hg5A3un7/zJ0oVClRDWGhr0vZyzc6ubC8jtbzKiPi p7fGx1GD /lCVN1mi/yUlgjxJ4yN1uLPcn1TNIoQkDkgsd1SOkp1rGq6KFla1qZb7vt2LBlpsNWPdluS0KqV9TJOQAvUkM8eUp9kOJXiw3ot20lQ5eLXcU4yDCxcjKPrXRx81HNC5hSWhvYybp3iKn0WqknHYPQ/ZpPvpAZgz5u9eIgmT1qy+k+F7i6h/n/L509bhR/fve3pWzfECtw2ER4IkmF5v0fDBGUd9ML7q5LDUCHAdO7UN/tunrX1YNwg3KDD72qdTKN/r+W2dsMKoo1wZfzqCrCYmzHl1KRQ6zLLRGAYNMUmIr9r7k/uGzhcsWuUgwT10rOlUg4WgwK2Sc9FyMMyRGr/3QwmMpSRLJMd2slx9Q8Uh3NaBtjDbDnstsIUhAyJbiZj5ArS3w7sXqH0dkQn3wHC+aD2zysaDqt6L+gAmV5VGD1XHhUsYqUUyQCdUXgNA1xYHzL4CGhkO7h6qD2ToiIXiCX+rL9ICQIY5pYya1fB8R2/TSURqSYUtDmB/Jn1wNm7HSTk8PI9cg33tNUaqIuXi4SAQOF5gwwE/gdkjz8OVJDzbxJxRBiU5X4o6R3OG8MlS1iBKJ4+9RLczh6kbHEws4xzg6bmnkI2QQ1nvotNcJ2+an1AdAoD0AbNNXWSMVLqP4XQtWKhCf/zY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, 14 Dec 2023 at 22:47, Pintu Agarwal wrote: > > On Mon, 11 Dec 2023 at 20:13, Pintu Agarwal wrote: > > > > Hi, > > > > On Sat, 9 Dec 2023 at 02:01, Rob Herring wrote: > > > > > > On Wed, Dec 06, 2023 at 08:46:00PM +0530, Pintu Kumar wrote: > > > > During fdt_init_reserved_mem() when __reserved_mem_init_node() > > > > fail we are using pr_info to print error. > > > > > > > > So, if we change the loglevel to 4 (or below), this error > > > > message will be missed. > > > > > > > > Thus, change the pr_info to pr_err for fail case. > > > > > > > > Signed-off-by: Pintu Kumar > > > > --- > > > > drivers/of/of_reserved_mem.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > > > > index 7ec94cfcbddb..473665e76b6f 100644 > > > > --- a/drivers/of/of_reserved_mem.c > > > > +++ b/drivers/of/of_reserved_mem.c > > > > @@ -334,7 +334,7 @@ void __init fdt_init_reserved_mem(void) > > > > if (err == 0) { > > > > err = __reserved_mem_init_node(rmem); > > > > if (err != 0 && err != -ENOENT) { > > > > - pr_info("node %s compatible matching fail\n", > > > > + pr_err("node %s compatible matching fail\n", > > > > > > Isn't the message just wrong. If compatible match fails, we return > > > ENOENT. The failure here would be from the init function. > > > > > Okay. > > You mean to say, if __reserved_mem_init_node fails with default err > > (ENOENT) then it may not hit this condition. > > Instead it will hit the 'else' case which is wrong ? > > Also, the "initfn" inside "__reserved_mem_init_node" may fail in which > > case also it may return default err. > > > > Maybe, the initial author's intention was to free the memory only if > > the failure type is not the default ENOENT type. > > > > This seems to be a different issue. > > Can we address this separately in a different patch ? > > > > And how do we fix this ? > > One option is to add another "if" condition with just ENOENT error check ? > > if (err == -ENOENT) { > > pr_err("node %s compatible matching fail\n", rmem->name); > > return; > > } > > Then, correct the existing log with a different message: > > pr_err("node %s matching reserved mem not found.\n", rmem->name); > > Or, add one more "if else" condition ? > > Or, fix the calling function itself : __reserved_mem_init_node ? > > > > Any further comments on this ? Any further comments or suggestions on the above ? Shall we just fix the log message, or correct the if/else case as well ?