From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529C6EB64D9 for ; Fri, 7 Jul 2023 14:33:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4CD28D0003; Fri, 7 Jul 2023 10:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD77E8D0002; Fri, 7 Jul 2023 10:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99E018D0003; Fri, 7 Jul 2023 10:33:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 85A958D0002 for ; Fri, 7 Jul 2023 10:33:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 28C7A1207DC for ; Fri, 7 Jul 2023 14:33:45 +0000 (UTC) X-FDA: 80985059610.24.794B531 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf04.hostedemail.com (Postfix) with ESMTP id 66C6540008 for ; Fri, 7 Jul 2023 14:33:42 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=E+2jC548; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688740422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVeuS4wdToj74Jk3B8MYFfuAdcYEpuPAI6KS5+ndsoc=; b=mpS1tGRn2YIBpAqtJj6Tai3+4mfi3ObY+dheh6WpKMBZxOMqtnjs6R2T0bk4lOhAUQaexo 91bD08CdgIY/SVnD93R7TjHNwTTwQu505gIXfxoe+fBEoJrvMQparvFE59yzQorbLvRkMp 6bhNIuCajhG0KB/e1ZLmfThijXEyNuY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=E+2jC548; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of pintu.ping@gmail.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=pintu.ping@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688740422; a=rsa-sha256; cv=none; b=h4K46Kyr3aUD+RUDEkWNzVE36xqwEx0M7PHH9zZuC2sQDFOZzZBDkfpPvIOL/+mfRX41QJ yLR6KjGGfA34HBvHVofMzY0uskq4MvVr3w9AE0AQHnbnPrQHf2fqDIsIMQrxqYEeNThOow HcndLl6hZqPWiJFNrMIQDR+fx0oQ1dc= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-440b53841a4so498685137.3 for ; Fri, 07 Jul 2023 07:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688740421; x=1691332421; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aVeuS4wdToj74Jk3B8MYFfuAdcYEpuPAI6KS5+ndsoc=; b=E+2jC5481ARYh3dPlxGMzlhLDmS+fOLAo98wKgmu/R40uiF8p8BOc8JFDHKwjuKRSE 7x56GH6uVFW9/PbWpTHu3BKDTE+0kPUHd9DqZ9+kzNLKA6O/kbNrKIePtoIqj55DTCIC bJ4Tf2l5Cmo1CKcuVCzGigluNEPAnqQb3ebAtJ0dtue2EUOY41icM2uvO1fEdAQDZ56S Ekn2lXwjafAnaR0yWMiBZuPbCPVzBrD1k2WCHlfMhbLUkdjGxlhHxwDouOLTUjvtCP7Y rEZqwOVH7w5mn4ouYOPQYH1BICswXH3VEXPqiwvZfCEWtiYzq9A3kQNSoxud9F6+NHPS g0YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688740421; x=1691332421; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aVeuS4wdToj74Jk3B8MYFfuAdcYEpuPAI6KS5+ndsoc=; b=N447Z0D7MbkIr3fX6RMd78lrl2GK3v4mJNqPuBts7Lv1YCRSvkRybd5hhaMKvHbYBe gITVyYvKfhjMNzy/xhTOZ5OyQ7tUJRk68bx6uMFbgmdG1nvzrP+pNVFK5QrPAMjkEERk +6w1T7NAxTbz7Itpoi1mdhrYE4pmMZOXe6eGGDrRk2I9CNRLc4NA9rKgastah2j7mYwi DZMq8y7K1NZhDk7Ipa+Om704SsJTkfL25C7TJ8pzE+KSDBnfErkW6jkQbXCuuVf/zTaE cJYZHo+6B9XAwuhNtnfd7eaWAcexgKszLl180b+dONdcx2HhzDop7wklg5N17sSv5faR +d2w== X-Gm-Message-State: ABy/qLYNHsawF/qe2K8alNj5QOjZdiqFXXYlpt7OHGeS5/+hSvwSJuit f85mCUTLG4x++UxNgsqu0Y5gXBiQRhj2+VRgZtYKt4Hq5cI= X-Google-Smtp-Source: APBJJlFHV4AdYtL5p4KgCODe0r5dDG+8ia3+EEsir5TXqYa+2KqWgefInkEDcHcIDkNjV0O84qMihE3hbBBbM1spljA= X-Received: by 2002:a67:fd66:0:b0:443:72b0:6675 with SMTP id h6-20020a67fd66000000b0044372b06675mr2184824vsa.16.1688740421300; Fri, 07 Jul 2023 07:33:41 -0700 (PDT) MIME-Version: 1.0 References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> In-Reply-To: From: Pintu Agarwal Date: Fri, 7 Jul 2023 20:03:30 +0530 Message-ID: Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug To: Matthew Wilcox Cc: Anshuman Khandual , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 66C6540008 X-Stat-Signature: nbxyj96i8xizbxsu4a7ttfom7ypa3yrd X-HE-Tag: 1688740422-351211 X-HE-Meta: U2FsdGVkX1+k+FTZs710WjdD3hcntiBBWEjQOSgn6WoPL1tVDvhTm+d0RLOg5rFC47qkFsSJFRiAa3aBY515B4gJ3gnZdwjvRl484GsHsiN9kNZEpxDLvzLqEN0dKM6yrd6seckJ+rCuFaaPuNmIk/n8CHOHoohWEiejHM5GkH33aaOakPK7jWr9dI6veLeqsWOlVcIOuYYLdTj9J9Q24KQXRHY7jE6ab8R9k7iCDIk5kdCKBl64A0SaZ2yEkz5jN9z27D3ZVNngDUqi9SnYHIYTu1CTGHDEchQLjsZdpRq2wqGx1eCTSk5TWyNeZE13u8iQh8VmKVHl7e9RNLlQx2rcaxFSgPr6Uv2exBGcrZtOtRLmjx7qL9faSsELNQYjBGOfd3O6+TWkt1/qh7+yRZmjBIIl32Si4sbcIeDIkfTFrcsk5EpZbZU4LEtrVD6QOt9HC1MEg4iKFyLgqd49wT+ax+I8TqB3owSBogxgr3LqsC3Igl82hNc44cBID2z0SVTyt175e5uGuDrvFMuEnF5blN80m8DJLUW9xKQFQqViD58v9H0If4ObSxHV05xvhrD7nMuX2Nop5yVw/BGctHNTyEi70IF+uNcOyHl+LjV4OCreNwctiYSZ38f6GgAJUHRjieSeMytiPt3P4Jqhcit1gaCzsgygCeRGPkvfOD1ZKb51Y609yOlsGWsbFejadwlX6I3BzJA7ZBy/nHE6AJBi3praZ43XvBIXFpamJdMw3hGO3q1WS3hlITjCioMpAokrJLgLIiilTsLUBFgn6BY1KaI/xChaChllW4cuKde4rz3kFnHKojbXteDgrSadMM4/E3DPHCo0jwQd/1GctqojfjQRom6RQqJMkf1Kdkzbn0rkaKgM+pe3+PmuCU/0JqssUkuoj8+v9TpjeMCXBJCt7cDYbK7yxv/4thzj6oEE67Iio2TL3NbC0UMVWV0VYy15vIxhgqgXFhcx4OC +GSxz+zI sh1RTJ25c1QO6Vb6D71iL2tOYn78vGvQejJIuhSd11LOp0uClwa+NR7+k8DAugF+TrKyIT29jRSTNLYOP9QZTk6o3oC8nDxKvs3AiYZHxA43uw3/ZQHfYHJrQrC9P35zhPclgPVJWg0oyL7KOikzzyuuafNekqicobLhWRH3pb7EtaLM8aJnw0AmMe6CLILSB/PSKoSc7+0oB+2a5fnP6ZAfdSK6t33V4ctMdIHpo8CslrmTAsZJEYKiq5IQEdz1FQL9D9H8PNeAI1DXATFQ7A3xk2m6V3qK9bVIw0Q0196sAOetI2bS/UA2JwTJgjU/ui2eFXPsn6MxWUkdg7LMIOeV0Elry9rLFIqfqfk2mdLaiju7l/YK2+DHcjPNxgSkpFJICFEWAQr6YVNMFrlRf7nqy5zr59rCa2Chznwwe0kYJIiYGc+od9nnr3BddDIsAva12f9N1a1dSIGAPmzEPQRXuxiqQ5VQChewoxu/emS7KLUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000131, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 7 Jul 2023 at 19:52, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 07:46:31PM +0530, Pintu Agarwal wrote: > > On Fri, 7 Jul 2023 at 19:40, Matthew Wilcox wrote: > > > > One more question from here: > > > > pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, > > > > (void *)cma, cma->name, count, align); > > > > > > > > Do we really need this "cma %p" printing ? > > > > I hardly check it and simply rely on name and count. > > > > > > Printing pointers is almost always a bad idea. Printing the base_pfn > > > might be a good idea to distinguish CMAs which happen to have the > > > same name? > > > > > No there is no name there, it's just a ptrval > > cma: cma_alloc(cma (ptrval), name: reserved, count 64, align 6) > > You misunderstand me. I don't know how CMAs get their name. Is it not > possible for two CMAs to have the same name as each other? > Oh yah that is possible, for example multiple players can use the same global cma region.