From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx162.postini.com [74.125.245.162]) by kanga.kvack.org (Postfix) with SMTP id AFFC16B002C for ; Thu, 9 Feb 2012 04:53:43 -0500 (EST) Received: by vcbf13 with SMTP id f13so245782vcb.14 for ; Thu, 09 Feb 2012 01:53:42 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20120209001335.49f2360b.akpm@linux-foundation.org> References: <1328448800-15794-1-git-send-email-gilad@benyossef.com> <1328449722-15959-3-git-send-email-gilad@benyossef.com> <20120208160344.88d187e5.akpm@linux-foundation.org> <20120209001335.49f2360b.akpm@linux-foundation.org> Date: Thu, 9 Feb 2012 11:53:42 +0200 Message-ID: Subject: Re: [PATCH v8 4/8] smp: add func to IPI cpus based on parameter func From: Gilad Ben-Yossef Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Michal Nazarewicz , linux-kernel@vger.kernel.org, Chris Metcalf , Christoph Lameter , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity , Kosaki Motohiro , Milton Miller On Thu, Feb 9, 2012 at 10:13 AM, Andrew Morton wrote: > On Thu, 9 Feb 2012 10:08:16 +0200 Gilad Ben-Yossef = wrote: > >> BTW - =A0I used a macro since I imitated the rest of the code in smp.h >> but is there any >> reason not to use an inline macro here? > > If it can be implemented in C then sure, go for it - that's superior in > numerous ways. > OK, I tried that and got into a maze of cyclic include files and function definitions so I guess I now know why the original code used macros. I guess I'll leave it as such for now. Thanks, Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" =A0-- Jean-Baptiste Queru -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org