Re: Re: [PATCH] slub: Using judgement !!c to judge per cpu has obj infucntion has_cpu_slab().

[Gilad Ben-Yossef <gilad@benyossef.com>]

On Tue, May 8, 2012 at 11:40 AM, majianpeng <majianpeng@gmail.com> wrote:
> I tested your patch,but the bug is still.
>
> I think the code may be is:
>
> diff --git a/mm/slub.c b/mm/slub.c
> index ffe13fd..d66afc4 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2040,7 +2040,7 @@ static bool has_cpu_slab(int cpu, void *info)
>        struct kmem_cache *s = info;
>        struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu);
>
> -       return !!(c->page);
> +       return !!(c->page || c->partial);
>  }

You are very right. I shouldn't be sending patches before the first
morning coffee...

I take it this last version of the patch fixes the issue? if so it
should should go as a fix into 3.4-rc7

Thanks,
Gilad



-- 
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>