From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1040BC4332F for ; Fri, 3 Nov 2023 08:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B637280012; Fri, 3 Nov 2023 04:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 865FC28000F; Fri, 3 Nov 2023 04:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72E4D280012; Fri, 3 Nov 2023 04:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 631DD28000F for ; Fri, 3 Nov 2023 04:22:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1FE17120E9D for ; Fri, 3 Nov 2023 08:22:10 +0000 (UTC) X-FDA: 81415950420.23.B7A7541 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf06.hostedemail.com (Postfix) with ESMTP id 52A3B18000C for ; Fri, 3 Nov 2023 08:22:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TidVachV; spf=pass (imf06.hostedemail.com: domain of huanglllzu@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=huanglllzu@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698999728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b99O0ifSMAF6Lk7ndWOjn/p2g7nsv+20NwC2txia3a4=; b=ypZV0wC+ShCMPzkIeaJ++SEYjtEPFJAX18MeKcsJWQ29nI4oH//pckyzlt3EaKoHc5BSN9 R0ykuMqN2M6OGXvT98l7xNsfYGet8mt7/jCX3eoNZ9aBR6eFWPIwwOOHy/6GJPeMq6ulOA S3/q0t41nim+ebMoEA4y9nhZnAyHf5E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698999728; a=rsa-sha256; cv=none; b=DFNcDlqA8kR4evi7PVutf0oQTSo6HRIP0Dairevw9WwqVCtvXzNrbBj1YvB5hJE0BWRWaf 0p8Y73SmULFnnEmCUfwAlfVbfY1EjOx9aNIOk1i5BmmF/hOWDU6q1Pgt5azNg0dLeXrR/c 0kCUDdW21OLgySrfz1SDIPhqTEe5to0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TidVachV; spf=pass (imf06.hostedemail.com: domain of huanglllzu@gmail.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=huanglllzu@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1ead2e6fab7so1025106fac.0 for ; Fri, 03 Nov 2023 01:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698999727; x=1699604527; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b99O0ifSMAF6Lk7ndWOjn/p2g7nsv+20NwC2txia3a4=; b=TidVachVddibwhVs80VP93kmcT8/8d53Ii85QmBtCYAaTyryXozj1XCTyHnBQU0oUU I9cm+GzC/9FQezru8n5JpAr3ED2xssPhmvs1NU7FljykxOrAGGEDzsrCVK5TWp6PpEvT Pg4uq4uhahewFAUAlfFVtQIVhHDWtXLCaItyFywFcj3H0cPDUTiLOZWUXR3hzK6DMA1F Uk8wHJrr25OYcsVk1JNAw2+joFaQGndVxc18/TFlxxAKkbrdFZX679vKchF94DNCP071 6aiTsh2PuHwtGRDYRRilju/AjVpp0Md/jMQPsZrYe9ynBzu7ukplZ2R1u+uMWizyEyfp w/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698999727; x=1699604527; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b99O0ifSMAF6Lk7ndWOjn/p2g7nsv+20NwC2txia3a4=; b=udm5e4dq5FSMyArZNxVcU9gL7WszzkD1SHK/AtPKFssJRxMhfomvr+R6eB8ogUjCE7 uGYafFFNzalOTqUuEjYtqmEjY//UM/dte3+AsUWIsrr1k46Q4H8F6NPfi/4S0hXDnz6u FVaDKFGdoCtIRFw1mgvGT3W/x0n5BHltxSM7sWuqzwL7ZzncC0Xr61S29lJpwiqavPVR POjbKj6XTP28XPtEFhLVD4m16/FwlKtRd5VCbp8VKEeb4GPtO0SNbSiyP3w6LTX9eMft hJN2rveRnBMbJ9UhAYb1aHUFN5i0+/PTpYQg6UN5fFfXREa9kXlXZ5ANHkch29cPHeAs Gz/Q== X-Gm-Message-State: AOJu0YwhYSP+EeDG0Ke4va6ZslEkiytO5ZaqFUdIu6xmluT2GCRASqJ7 SsI3pNHuVuiM2h7XNfEnSQOWZNXwqcAz88qHOAc= X-Google-Smtp-Source: AGHT+IGpPtw6Ck6Hk6rKzi9cuPHdUcPxg/E0QMKKu8QpqkiInH1KLjOcHpf0eLxWFTiIgjpjJQ+ObQi11aae4gCBfWQ= X-Received: by 2002:a05:6870:6193:b0:1ea:3746:b7d6 with SMTP id a19-20020a056870619300b001ea3746b7d6mr22761434oah.28.1698999727337; Fri, 03 Nov 2023 01:22:07 -0700 (PDT) MIME-Version: 1.0 References: <20231102023710.13023-1-huanglllzu@gmail.com> <20231102085418.GM2824@kernel.org> <20231103073459.GN2824@kernel.org> In-Reply-To: <20231103073459.GN2824@kernel.org> From: =?UTF-8?B?6buE5Lqu5Lqu?= Date: Fri, 3 Nov 2023 16:21:56 +0800 Message-ID: Subject: Re: [PATCH] mm/memblock.c: using judgment statement can reduce loop and enhance readability. To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Liangliang Huang Content-Type: multipart/alternative; boundary="00000000000038b69d06093b3379" X-Rspamd-Queue-Id: 52A3B18000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6mi68hc1wfpqwwdrcr7fs4z38ydhstns X-HE-Tag: 1698999728-262226 X-HE-Meta: U2FsdGVkX19lTgxGHG9hE/icLWHgRG/MYOb4jbY3LjvWv+674fnLsMCgwOhjdvGApm+7PUWz5JKtIK+S57twTX7umcqYzGQxHm6gge26JDILvc3Gy6jEw25xsvlwpmONTKwj25EJ6yNqFnKnR8+GQ3Q2LpoOH/a5p4/Cvvp0eCq+YOidZ02w/9A3jpu4X6KqryWNr2RPc1PKJ2Pz/L18oVbAmUAR4VVnY2Ww47HfioSCMZPHsF4aB+e+R0pvBQV4H2X5pmMYXRa9YREB+KqqFjuveJ8JKl0WFUSU26YbjLnsLUQ12uXUUO1B3Yuf50S6y1SBpz58ZI6zGz1uCNKycM6KhEUJH+0aEHw/urwBEUFpU3u52aanrhjgyXii4tkgCIBmz/f/DTVTN7VF1KKmuXmzeBNK6zG3AbfjOALfWPfAs7NjXZ7BO672Q+43CMqR5ORlx3kbtmA1EXNYXRbpoyzrgfjHQK7csO+I/Sp48V/ecAmWChz0/GSdTWFrqfYUT60tIXMcZF6JZDdqkbDyA32RQ5nD0TdOltioWoim9HtO3XseJEiEsvF6GZefD1Yhq8KqSH9733Ir9YGmevgg1q13SiCWg5F96Sy40fpLBHCGG6zzYh2Fymbkkx4k8ZMRwCoC2DMIVHfzwRAiZz141BT6Ifaga5rQfQV6/sCRnk0IfTgZRyM4tMFnWtdMlj2MvRNTqloYmN+cCFPyYfA7bBGcTR2+IUZAHRSn1RGZC/kkx6ngpxyxB3L+NhLM+d35wtwCJJWUKLMzZ+Ok09IVe08nTxbeOdWkNR+P22Os7SQ0nFJdZn2R4crIgawnVF0HuRD0kMD3LRGwmGlseuPaQEcaQf4Gfzbj0UjmifqWfeDZ8eYIQC5YZnRiN+u3fwovDmfEOwxUleUmOdNF9q9Tkgr76bQJx0Z1JxOdD2oThAYYfp/X+StAvZRB4gDAlmH/GmG8hrfr+ChUwMnyMBU jwQSCsGM chr0eQhRW04HGqRtmXbstepAPbIScsxZqGMZmHHw/1QgDa8kXFJWi0XGLTjTrhRx3iSshYVveME9NG9zidJ2POV95uAgnVIxX7sSS1sC31b14iCpvHSiq0tTKyrXUHl0Skf594YdU3e67u2EwXukuNurusE5uSad2V324Zgbdo/L0ALreBa79sAwT0dkHJzEsjCRfSWIIRo3CAvJn/2oVVJgpWevFn4HcqWq8wAtnxsCGl+6AvpWJPlnib+1esBj+qxg5pMv51AIGGTUPbUQUZ6XSiumd/5Z3iwwZNTHtrigT3giP1ZZZPecIFmkZvhhW1B2ji6PJld4aNMD5Bi2MwJ3HU+3r/xVltvkg4uPmGHUDnrmu3cA6hylD2SZnnt1lRUWCD5BzK4AD2wWXNR6sPJi37UltJ6aKT4wSr9fXjeXzvKQYAAgq6NqV1YGfWPnmO+unnLqiv10/R2jLMfQsyEJwG8wtw52Eu/Fvpt9iK/quKHakZiqERE6wQRws9ZAVe3yGsox9u/fXizlWkGVYzgLppiuF+2N9cChmnzaBRnw9fbdOfXUBNFU295DdV2n9uYI1EfdWyWcV2o8bm0DRLhweliSBiFVI9C1+AqYWrHCP8p4xdJy5kpO7Mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000428, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --00000000000038b69d06093b3379 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mike Rapoport =E4=BA=8E2023=E5=B9=B411=E6=9C=883=E6=97=A5= =E5=91=A8=E4=BA=94 15:35=E5=86=99=E9=81=93=EF=BC=9A > On Fri, Nov 03, 2023 at 01:30:21PM +0800, =E9=BB=84=E4=BA=AE=E4=BA=AE wro= te: > > Hi,this patch can less loop once in this situation: > > base more than rbase and end less than rend. > > base end > > rbase-----|--------------|-------rend > > | | | | > > --------------------------------------------------------> > > The loop won't be executed anyway because there's similar condition in th= e > beginning of the loop. > > Next time when you reply to the kernel mailing lists, please don't top po= st > and make sure your reply is text-only. > > And there is no need to send 4 badly formatted replies. > > > Mike Rapoport =E4=BA=8E2023=E5=B9=B411=E6=9C=882=E6= =97=A5=E5=91=A8=E5=9B=9B 16:54=E5=86=99=E9=81=93=EF=BC=9A > > > > Hi, > > > > > Subject: [PATCH] mm/memblock.c: using judgment statement can > reduce loop > > and enhance readability. > > > > I disagree. > > > > On Thu, Nov 02, 2023 at 10:37:10AM +0800, huanglllzu@gmail.com > wrote: > > > From: Liangliang Huang > > > > > > Signed-off-by: Liangliang Huang > > > --- > > > mm/memblock.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > > index 913b2520a9a0..e48dea7144bb 100644 > > > --- a/mm/memblock.c > > > +++ b/mm/memblock.c > > > @@ -655,7 +655,11 @@ static int __init_memblock > memblock_add_range(struct > > memblock_type *type, > > > } > > > } > > > /* area below @rend is dealt with, forget about it = */ > > > - base =3D min(rend, end); > > > + if (end < rend) { > > > + base =3D end; > > > + break; > > > + } else > > > + base =3D rend; > > > > min() is perfectly clear and there no change in number of iteration= s > of the > > loop. > > > > > } > > > > > > /* insert the remaining portion */ > > > -- > > > 2.25.1 > > > > > > > -- > > Sincerely yours, > > Mike. > > > > -- > Sincerely yours, > Mike. > I get your meanings, thanks. --00000000000038b69d06093b3379 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Mike Rapoport <rppt@kernel.org> =E4=BA=8E2023=E5=B9=B411=E6=9C=883=E6= =97=A5=E5=91=A8=E4=BA=94 15:35=E5=86=99=E9=81=93=EF=BC=9A
On Fri, Nov 03, 2023 at 01:30:21P= M +0800, =E9=BB=84=E4=BA=AE=E4=BA=AE wrote:
> Hi,this patch can less loop once in this situation:
> base more than rbase and end less than rend.
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 base=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 end
> =C2=A0=C2=A0=C2=A0 rbase-----|--------------|-------rend
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |
> -------------------------------------------------------->

The loop won't be executed anyway because there's similar condition= in the
beginning of the loop.

Next time when you reply to the kernel mailing lists, please don't top = post
and make sure your reply is text-only.

And there is no need to send 4 badly formatted replies.

> Mike Rapoport <rppt@kernel.org> =E4=BA=8E2023=E5=B9=B411=E6=9C=882=E6=97=A5=E5=91= =A8=E5=9B=9B 16:54=E5=86=99=E9=81=93=EF=BC=9A
>
>=C2=A0 =C2=A0 =C2=A0Hi,
>
>=C2=A0 =C2=A0 =C2=A0> Subject: [PATCH] mm/memblock.c: using judgment= statement can reduce loop
>=C2=A0 =C2=A0 =C2=A0and enhance readability.
>
>=C2=A0 =C2=A0 =C2=A0I disagree.
>
>=C2=A0 =C2=A0 =C2=A0On Thu, Nov 02, 2023 at 10:37:10AM +0800, huanglllzu@gmail.com= wrote:
>=C2=A0 =C2=A0 =C2=A0> From: Liangliang Huang <huangll@lemote.com>
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Signed-off-by: Liangliang Huang <huangll@lemote.com> >=C2=A0 =C2=A0 =C2=A0> ---
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 mm/memblock.c | 6 +++++-
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 1 file changed, 5 insertions(+), 1 delet= ion(-)
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> diff --git a/mm/memblock.c b/mm/memblock.c
>=C2=A0 =C2=A0 =C2=A0> index 913b2520a9a0..e48dea7144bb 100644
>=C2=A0 =C2=A0 =C2=A0> --- a/mm/memblock.c
>=C2=A0 =C2=A0 =C2=A0> +++ b/mm/memblock.c
>=C2=A0 =C2=A0 =C2=A0> @@ -655,7 +655,11 @@ static int __init_membloc= k memblock_add_range(struct
>=C2=A0 =C2=A0 =C2=A0memblock_type *type,
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0/* area below @rend is dealt with, forget about it */
>=C2=A0 =C2=A0 =C2=A0> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0base =3D min(rend, end);
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0if (end < rend) {
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0base =3D end;
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0} else
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0base =3D rend;
>
>=C2=A0 =C2=A0 =C2=A0min() is perfectly clear and there no change in num= ber of iterations of the
>=C2=A0 =C2=A0 =C2=A0loop.
>
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0>=C2=A0
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* insert the remain= ing portion */
>=C2=A0 =C2=A0 =C2=A0> --
>=C2=A0 =C2=A0 =C2=A0> 2.25.1
>=C2=A0 =C2=A0 =C2=A0>
>
>=C2=A0 =C2=A0 =C2=A0--
>=C2=A0 =C2=A0 =C2=A0Sincerely yours,
>=C2=A0 =C2=A0 =C2=A0Mike.
>

--
Sincerely yours,
Mike.

I get your meanings, thanks.
= --00000000000038b69d06093b3379--