From: Jimmy Shiu <jimmyshiu@google.com>
To: Mel Gorman <mgorman@suse.de>
Cc: mingo@redhat.com, joaodias@google.com, wvw@google.com,
Minchan Kim <minchan@google.com>,
Will McVicker <willmcvicker@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Howells <dhowells@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
William Kucharski <william.kucharski@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] SCHED: attribute page lock and waitqueue functions as sched
Date: Fri, 5 Nov 2021 02:30:55 +0800 [thread overview]
Message-ID: <CAOnVMEHspYQUevU41ojR=rM_H658qGUf9xdXxRemdWgv6sbEKw@mail.gmail.com> (raw)
In-Reply-To: <20211104091654.GV3891@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]
On Thu, Nov 4, 2021 at 5:17 PM Mel Gorman <mgorman@suse.de> wrote:
> On Thu, Nov 04, 2021 at 02:47:03AM +0800, Jimmy Shiu wrote:
> > trace_sched_blocked_trace in CFS is really useful for debugging via
> > trace because it tell where the process was stuck on callstack.
> >
> > For example,
> > <...>-6143 ( 6136) [005] d..2 50.278987:
> sched_blocked_reason: pid=6136 iowait=0 caller=SyS_mprotect+0x88/0x208
> > <...>-6136 ( 6136) [005] d..2 50.278990:
> sched_blocked_reason: pid=6142 iowait=0 caller=do_page_fault+0x1f4/0x3b0
> > <...>-6142 ( 6136) [006] d..2 50.278996:
> sched_blocked_reason: pid=6144 iowait=0 caller=SyS_prctl+0x52c/0xb58
> > <...>-6144 ( 6136) [006] d..2 50.279007:
> sched_blocked_reason: pid=6136 iowait=0 caller=vm_mmap_pgoff+0x74/0x104
> >
> > However, sometime it gives pointless information like this.
> > RenderThread-2322 ( 1805) [006] d.s3 50.319046:
> sched_blocked_reason: pid=6136 iowait=1
> caller=__lock_page_killable+0x17c/0x220
> > logd.writer-594 ( 587) [002] d.s3 50.334011:
> sched_blocked_reason: pid=6126 iowait=1 caller=wait_on_page_bit+0x194/0x208
> > kworker/u16:13-333 ( 333) [007] d.s4 50.343161:
> sched_blocked_reason: pid=6136 iowait=1
> caller=__lock_page_killable+0x17c/0x220
> >
>
> /me peers at coffee
>
> Maybe I'm blind but aside from Matthew's concerns, this
> appears to rely on an Android patch that is not upstream
>
> https://android.googlesource.com/kernel/msm/+/c9f00aa0e25e397533c198a0fcf6246715f99a7b%5E!/
Yes, Mel.
The main purpose is to help get_wchan() to get the meaningful information
of the schedule() caller and can also benefit to Android
sched_blocked_reason trace.
Maybe I should edit the commit message and remove the Android specific logs.
Would that be OK?
>
>
> --
> Mel Gorman
> SUSE Labs
>
[-- Attachment #2: Type: text/html, Size: 3101 bytes --]
prev parent reply other threads:[~2021-11-04 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:47 Jimmy Shiu
2021-11-03 18:58 ` Matthew Wilcox
2021-11-04 18:01 ` Jimmy Shiu
2021-11-03 19:10 ` Matthew Wilcox
2021-11-04 18:10 ` Jimmy Shiu
2021-11-04 9:16 ` Mel Gorman
2021-11-04 18:30 ` Jimmy Shiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOnVMEHspYQUevU41ojR=rM_H658qGUf9xdXxRemdWgv6sbEKw@mail.gmail.com' \
--to=jimmyshiu@google.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dhowells@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=joaodias@google.com \
--cc=juri.lelli@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@google.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=william.kucharski@oracle.com \
--cc=willmcvicker@google.com \
--cc=willy@infradead.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox