From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C73C4332F for ; Thu, 15 Dec 2022 00:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16FD68E0005; Wed, 14 Dec 2022 19:41:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 120558E0002; Wed, 14 Dec 2022 19:41:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F026B8E0005; Wed, 14 Dec 2022 19:41:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E0E458E0002 for ; Wed, 14 Dec 2022 19:41:07 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5E119404C2 for ; Thu, 15 Dec 2022 00:41:07 +0000 (UTC) X-FDA: 80242686174.22.DA5ACFB Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf18.hostedemail.com (Postfix) with ESMTP id B90E01C000D for ; Thu, 15 Dec 2022 00:41:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=atishpatra.org header.s=google header.b=jb2ClHC0; spf=pass (imf18.hostedemail.com: domain of atishp@atishpatra.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=atishp@atishpatra.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671064865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l1+9aFWIywW24+fuTbx+Qyc1HRmi+jILztX+FivWx3Q=; b=K4PE7v84/9VAITNF0Y1o278ONyIxuvJAgfua9rEdWd5Vn0CsbNd6i2UEuSYdfMaGpp51Hx 0jnuZiqTjzvV6aom4lWV0l60gEamVR+c8Kf+12XhH1BVeZu7Ekc/cXrmhztF6Z4CH0Hki+ zskq6Cq2nWg9iKOBYPTpOcVWy+fcW1M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=atishpatra.org header.s=google header.b=jb2ClHC0; spf=pass (imf18.hostedemail.com: domain of atishp@atishpatra.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=atishp@atishpatra.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671064865; a=rsa-sha256; cv=none; b=LCZQluU3C1QVIWPJ+06qOjytCKtvER9zsVS6Y3CFOAw62zrtDAFsoDl7DvaDgYs8nCs7ub wh0NCh5LiFhGq/lE/yMbhRhY3q5sNnIefHvsQcTSEghrVwMHNtFkecVryIBRYkQa4GS3cl X4GpUkH9FiTUE1rFvmPwOMoNlwz3D+4= Received: by mail-pf1-f182.google.com with SMTP id w26so5660329pfj.6 for ; Wed, 14 Dec 2022 16:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=l1+9aFWIywW24+fuTbx+Qyc1HRmi+jILztX+FivWx3Q=; b=jb2ClHC0JzlU6/A7oG9wX2lIjW163wYAAsnuD7z6vHKLAJ6WCABdC0zHaJgH+vW1cJ X85wm2u0tBa3ucj4A9xYBR14n5W4lrDo4Z776KQYkYdhCQEQVA9T1mvhctnbGmU3BE4C WARNv31LD1wabhMMu+06rdt20q9faYRYxU+FQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l1+9aFWIywW24+fuTbx+Qyc1HRmi+jILztX+FivWx3Q=; b=LWYMMYcF2ORExGqN7SYzzin6eehLMFtIogDWcFwFSZu40wVAURDPCb6WH9npopDaN9 v3g9nm9iAZ+aCF19jiGl/p2qaTVwIFD+rKJdUUC47fKhkuYi0CYocbcQ2lrA6sA7rzUr ifko0JHaGEU9ilZFLLfZjYE93LnWkxTh9woFIqf3EjZwZAXoUGlY0sWdTT+jKxNRSgh9 C2jUEuZPYoAE98Rz4eImi4e41ELf1Rsri8DRboeusVPKoGcscgvT7+MhC5SPE9OP4yDo JTSHWVSA7TzYncXgJKmD4pf6apTDEe7E7NJh5RnG8bCf3E744vzPJx6PM/UNh9Fjtm3C UVow== X-Gm-Message-State: ANoB5plTMn2MpBZgK8gn9mTVPONUY0NnNJ++JELrVOx3rYAnEYPFNY4H UdwmKd5hJjSIb1tz0tvZ/j/QkWxdkpvlMCL4z3L/ X-Google-Smtp-Source: AA0mqf41r0jXtY+/17AH27nqYNOeQ6pZv+/Uw7fREISQYROGD50E5EiI8tulDjCBbhcj8fUBC5QzNKLSVNd4DxlDuwc= X-Received: by 2002:a63:f4b:0:b0:46f:98cf:3bb6 with SMTP id 11-20020a630f4b000000b0046f98cf3bb6mr68618832pgp.332.1671064864426; Wed, 14 Dec 2022 16:41:04 -0800 (PST) MIME-Version: 1.0 References: <20220921214439.1491510-1-stillson@rivosinc.com> <20220921214439.1491510-4-stillson@rivosinc.com> In-Reply-To: <20220921214439.1491510-4-stillson@rivosinc.com> From: Atish Patra Date: Wed, 14 Dec 2022 16:40:52 -0800 Message-ID: Subject: Re: [PATCH v12 04/17] riscv: Add vector feature to compile To: Chris Stillson Cc: Guo Ren , Greentime Hu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Anup Patel , Oleg Nesterov , Guo Ren , Heinrich Schuchardt , Arnaud Pouliquen , Paolo Bonzini , Qinglin Pan , Alexandre Ghiti , Vincent Chen , Arnd Bergmann , Heiko Stuebner , Jisheng Zhang , Dao Lu , "Peter Zijlstra (Intel)" , Sunil V L , Han-Kuan Chen , Changbin Du , Li Zhengyu , Alexander Graf , Ard Biesheuvel , Tsukasa OI , Yury Norov , Frederic Weisbecker , Mark Rutland , Myrtle Shah , Vitaly Wool , Mathieu Desnoyers , Catalin Marinas , Mark Brown , Will Deacon , Heiko Carstens , Huacai Chen , Alexey Dobriyan , Janosch Frank , Christian Brauner , Evgenii Stepanov , Peter Collingbourne , Eugene Syromiatnikov , Colin Cross , Andrew Morton , Suren Baghdasaryan , Barret Rhoden , Davidlohr Bueso , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B90E01C000D X-Stat-Signature: 8aenfnnjg4wieposhuz6b6izub1sstyk X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671064865-468761 X-HE-Meta: U2FsdGVkX18lL9bg3KyyP5S7ly6vV+EjyLif2TvtV39TMberC3rZxLG3oUcsLMfF+ruYOj0v22jkoZCbec5trVrHDrXTPV2bgXfpHCi1BR3a/VBK3HtSWE+9NdxN+b/ge42BwdaOYLcXl4lkkvuB9SaV1hYtqWsexQ32pL1MWh1hJ3zsIBgj6ZVLC3enpxumubOIoBVI2ZgcJ3LTI3BGPLZOu8Uhoqq55nafqL49GqZISJ4Yo9If8jpbLmWKFjqmDK5zuqW5i/07Lk8PSKV55ntKx1CUvgYfYDCxxlZmvJXlCaQXebCEdUCHrzmcz8H7ET8dDQsuHvx9Mjhyy3Du6/e2NFEVj5ZfpZkOiGvvs/E0+o4tqbAIzlK8lcq4kA+6BRlc938QqB08H13ZjtGHvK6y0/dGhjc7Pa8spH49W1NbUzF6ulrZhwdf39kd4tDobnHCBBp8AESQYFfrFhKzCiirGvj2cEAZTTqjbZTQVd1a0UXT7Gngp64TP/VreMrklPki3UCSqQXaOX5o/QaEkZBN0KsTbicY97TR15UaYBaidag8AxIUHEnyccW4LNOpk2xsps7XJwZ/ukQrTpKKRXcOnlI8/hSu9OwH9ABzaDy9XI+59YnAAikpXj0zJPoXaEhCbBSakMLZho1OlJYU5RJzMU5zxMg4YrwE+Iq+oEkHgtCSeNRWmF4KGYITH8Yf7GD4gwxB6MOx2FQ3rLuVyb1RAVNUex3rkeerUjZUgABp7/yM6mHdk7/Pr/lPxfxz48/HRMOLaf2Jiq1zIKhUiy3QMM/x8+XHJmzwvGzdAbg6aUrKxF7CHlDw4VxKg77uj3PJGMqKHnJXcY3CAcl+zZmulKobO/8VlFlXni3SBAz8Afe4JecLeWXg71QZVMrkkW4YCuVSv3SthEQMiEEsyF29EPYVWKmkqa7kdabB4myowK3zaruu/E425snwyXAZ3CzbeCi4QGtB5FCmcN9 ab+j7V8T G2loCw0w0Esz1rG1MX6/vm3eBnGMkdBeNP5CxARqSdkm0cbT7AG81gtqEDFWA0ytBGp7tKgEfd+H8D74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 21, 2022 at 2:47 PM Chris Stillson wrote: > > From: Guo Ren > > This patch adds a new config option which could enable assembler's > vector feature. > > Signed-off-by: Guo Ren > Co-developed-by: Greentime Hu > Signed-off-by: Greentime Hu > --- > arch/riscv/Kconfig | 15 +++++++++++++-- > arch/riscv/Makefile | 1 + > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ed66c31e4655..e294d85bfb7d 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -432,7 +432,17 @@ config FPU > > If you don't know what to do here, say Y. > > -endmenu # "Platform type" > +config VECTOR > + bool "VECTOR support" > + depends on GCC_VERSION >= 120000 || CLANG_VERSION >= 130000 > + default n > + help > + Say N here if you want to disable all vector related procedure > + in the kernel. > + > + If you don't know what to do here, say Y. > + > +endmenu > > menu "Kernel features" > > @@ -556,6 +566,7 @@ config CMDLINE_EXTEND > cases where the provided arguments are insufficient and > you don't want to or cannot modify them. > > + > config CMDLINE_FORCE > bool "Always use the default kernel command string" > help > @@ -648,7 +659,7 @@ config XIP_PHYS_ADDR > be linked for and stored to. This address is dependent on your > own flash usage. > > -endmenu # "Boot options" > +endmenu > > config BUILTIN_DTB > bool > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile > index 3fa8ef336822..1ec17f3d6d09 100644 > --- a/arch/riscv/Makefile > +++ b/arch/riscv/Makefile > @@ -50,6 +50,7 @@ riscv-march-$(CONFIG_ARCH_RV32I) := rv32ima > riscv-march-$(CONFIG_ARCH_RV64I) := rv64ima > riscv-march-$(CONFIG_FPU) := $(riscv-march-y)fd > riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c > +riscv-march-$(CONFIG_VECTOR) := $(riscv-march-y)v > > # Newer binutils versions default to ISA spec version 20191213 which moves some > # instructions from the I extension to the Zicsr and Zifencei extensions. > -- > 2.25.1 > Kernel boot hangs if compiled LLVM and vector enabled. Because LLVM enables auto vectorization by default and it inserts random vector instructions. We need to add "-mno-implicit-float" for llvm builds to disable auto vectorization. Thanks Vineet and Saleem for the hint :). -- Regards, Atish