From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C1EE77184 for ; Sat, 21 Dec 2024 09:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8962C6B007B; Sat, 21 Dec 2024 04:59:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 844B16B0082; Sat, 21 Dec 2024 04:59:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69F3B6B0083; Sat, 21 Dec 2024 04:59:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4B5436B007B for ; Sat, 21 Dec 2024 04:59:57 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BCFB8160F4B for ; Sat, 21 Dec 2024 09:59:56 +0000 (UTC) X-FDA: 82918518942.22.C005BC1 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf09.hostedemail.com (Postfix) with ESMTP id C5812140009 for ; Sat, 21 Dec 2024 09:59:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RUqpGFQi; spf=pass (imf09.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734775178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=egHprya5wIN6bGofZtv4dfpbBXKQe0iUzhyvNvr/kt4=; b=Ls0ZPDCErqGd9HcMFV9CP166f/Y4OjKNdvC7VpVYIVVn2NzkFIt0saUbqv31VkuXBIOYs9 1o2qnBvMG2tOkdL7Ac7H+YOQONUgPPyiTY2ZEFYz8YOL/7i+TdbiQb+sTHHCYFP4sh6bUa /vBb8w0ZGUKjvmLou1gDVv5CJ1xQFWk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734775178; a=rsa-sha256; cv=none; b=bc4OAQHA9DwOS+7akUNgRbSFhf65H+USciw1ECzc8/e8xLt0EoL8m0TGht3AZyY7WbjCcc pXyOi2LLOL+NnzTJWwRyd0bQ05BhtdRlwfSoEeIMdYX7/YBDyk5XWbEUFthGHbhn+MYi43 Y419lTIhpZWgfzwDF2sS8Z5cRrSKbXs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RUqpGFQi; spf=pass (imf09.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6efe5c1dea4so22131977b3.3 for ; Sat, 21 Dec 2024 01:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734775194; x=1735379994; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=egHprya5wIN6bGofZtv4dfpbBXKQe0iUzhyvNvr/kt4=; b=RUqpGFQibeC06bD+0IX0Y1m4Gi3453gyEGENPwYGW/BWEKYRakRNSmesPqMKBi+FY2 ns6wEAKqBXkSN6mhzsZ2UxRcHiXuAi7PA4utYr1P55xsVP2myksEyjTUbv7ml1/t1lMS x761SLzIXWSiKHKmfeYfrveT8iu6AsVB9tleIcnALi7I7WV7uD5rmxg2qQUUnTBFCUAJ hKy7bRk0GApRt+SorUj+Phm0/QJbWXse6+9ZZxQWD0c+uyd0hbogkl2TFdY9sKYzBLrP fT8Hts3jR5bU4xQ8OJjoP1H1F1nSyO/2wjKY6RM+Tn1ggxjGsWxdKNZKD6OFL6vU4M/B XRKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734775194; x=1735379994; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egHprya5wIN6bGofZtv4dfpbBXKQe0iUzhyvNvr/kt4=; b=n9WXEyADoQ5A8PMnkJGqKVp0uYcjh4WoKqP/gGu6tSQEQMiAvQlb+O1pP6qMhHGZCO 3lTiP/N9ByI5rVExijhTbmxQ/blyqanQoPqjNUiojraBinJMSzxzxfoQFZaN44kJyw6a kSc4AHZSQ+dnfinEdMqOcMw9bSICWCItfaMq/aNp6HKaQeSaCEYQCMJLeZQUz+rcj31R 1q+hb25SlXFajrs8V8nt3zlbKqIo8f0zynwwZYFwkVX+RhxQUShHbDJFURAkw4xb58IZ /csSdIkaS5zkZcp3Q7A35Z282sQIkzXrqMRqFrdZKJeEByM11AQESCnrwYaDKMMd0sK1 JIdg== X-Forwarded-Encrypted: i=1; AJvYcCUpa/VrgmEjISfv5LmVy7jJG8FEiK+5W+vAg3ddu3aoFidZRZf5+AQfYe2Lp28z7Nd4tBgVKzqO8g==@kvack.org X-Gm-Message-State: AOJu0YxFkRzycHcM6jAwRq3Q4gqd9vHxTxFU2aXyVy/2mOTjvn3lHMQc d5WqpmndDy+m8JqUm7neywtB/NqOIg0yPjAG44SqYNtsLEF8G2sTYy1aUJ3mDiluwW0eptN6yFk pSLJh6VvYHhRTOw65thJyt5+i8ic= X-Gm-Gg: ASbGncuphDvVv4HqOxIG9AF2D42QNmr0ZbyLlJclm78HEa88qyL79DghNyzNHFlNb3y HMocvXpEL/8TYDDDH7vmcRZLJwFqIqqQRvm6a7Ew= X-Google-Smtp-Source: AGHT+IG9hgHXPNsbBNiOuY+6OAJ+D2q82bPj4v1OfjOz7h337kMTVjsW2qLUpiuBZXc33tZc49lNKi5hOGaIXzFbkh0= X-Received: by 2002:a05:690c:4b13:b0:6ef:7036:3b25 with SMTP id 00721157ae682-6f3f8216b3cmr49229327b3.31.1734775193934; Sat, 21 Dec 2024 01:59:53 -0800 (PST) MIME-Version: 1.0 References: <20241220092638.2611414-1-guoweikang.kernel@gmail.com> <20241220150623.278e8fa9f073b66dc81edfe6@linux-foundation.org> In-Reply-To: <20241220150623.278e8fa9f073b66dc81edfe6@linux-foundation.org> From: Weikang Guo Date: Sat, 21 Dec 2024 17:59:43 +0800 Message-ID: Subject: Re: [PATCH] mm/memblock: Add memblock_alloc_or_panic interface To: Andrew Morton Cc: Mike Rapoport , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Geert Uytterhoeven , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Len Brown , Juergen Gross , Boris Ostrovsky , Chris Zankel , Max Filippov , Tero Kristo , Michael Turquette , Stephen Boyd , Rob Herring , Saravana Kannan , Pavel Machek , Yury Norov , Rasmus Villemoes , Marco Elver , Al Viro , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C5812140009 X-Stat-Signature: uwne3ehf3ny31rqfkta1w1h59c9ajtuq X-Rspam-User: X-HE-Tag: 1734775170-189348 X-HE-Meta: U2FsdGVkX1+w0v7BPAgXaprkI1iZ27am+EPKMh1mpqB1kz+JNVM90CaXiKtbjs8/9mC5MTNNoKG1zEQuMxJ2t6eNSLnO5SwtYh/v7LZGH3s5o/vIV0A4tBSXvMNMLC83FElNik8HOd74yXT0bAP9Ixd1inTy8P6H9s3N3xitVtCwl0MgoaW4W1wI9SlJBSSHfNCIvceJ0Gl4PZ8QcVZfDHVoSPEb00KtDvW5dOG5v8WD7SBfNvXd0gSrsdNbE+1EswsxuaRIQVekMcayF1LwGXiZJmkkvsB7B6hY04GwgYLKwJJSwEtSQTTl4GoYsLAHQJ0bQL2LBzvZGBh1zBn091rwHiZBqMw94dEtjqSfbmih5K6A1ZB5BdzI6vRVL2MufYqwZa7dNvIMPbja4w8VarWGVmTXddy3QPpY7hMzRcpUciZ/oGv2U3rmCFfey67pgmO1H5xgraRb63qJCDKFxS356VeJzaAzcwiTgTwGMkhwdAQtkxRhRNTbMwe6jJ56CMw4W3yfsIuUaSkFmSqBt599kozV63KIGZrQglTW0JO7Shq60Lqf9i2pcnCMidiSdrMdug37Q8ugsnuFjwyJ4sjjXCOZDq9dgYxnTzXyDwmyiixWEnogMkdZoSV8dVnVGUDjBA69ty7HQUx/0hqx/luKrIQ3farthzCrrYQVZNRYFVoNZd5Pjm8JpSOzZUBFpBvWcvtKnMCVP68RN1Sm1oQpTTQYhK19QoIAnokwcWiiqRP3pBqYxtn+fU/aoXhP5S3WMvzQA9P4k8TdROyPWDv2ageJRhKgH6JjOkej9udvkPslnDgNiMnIRuv4slmSGVnkYMG9B0OsZyIFKOwUzn9zA5+Iw+3goPmXgTJHhdwtfMR3miDL4Lxi9zv0Tw07Jvb8HKV6S+eeIyFL1IpizM1BKVCIEb5mEcRfVbPL7vvIeA8aaC+ebozvCvfoJ/wC5CJTrhiln+SZYOVWEdy 10jfPVDi eiX+5JYu8kbsXhufY+KgKRACglTvDjx5qzq+LPPAeAERVBpzf62oywhWbLzDctQjY7kJ25jyc14zM4r9UvvFEGF1JyrSG61qHgqZOyt0aiTvjbNJBJkhchexxoVaRtEvM7DOvKbHJAKf3Dv2mqv4D1+QvF8EDg2rDFRra3OLxviPQybKlt+U0blblgGWSkjLPfgtO2lUR6FQOCzhN5r2zVWTaC89shXPHvjosF9XBY0eoqoO7q19Yxda5lF6sVnM+h4POwucDzqeiAUowS8jZNCT0PxAhyGDWPla2tAXR1pIZv4aquOMwGam6YuakgLiKyF+KyN+CwwdDFeX1U+A2WtteXhFVv7aQnVtFQ9IV8GpV96bPjxdZwZuXBj92gsOo89u8SDcZFV2LjcOlqYM64h6o6eK/lZtO7NcOt6RXCKlNXExYs4Hc5hazmSOUJb7W19Elxme6gzERSxBl6EttDhMKd8dbTnULRS3/WtD8BhO455savyqjtHjw3Kg0Uf81rq/OkQOPM5eYjLPIEUby0G9x9O5QJct57lztpXnUw+WW+CU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrew Morton wrote on Saturday, 21 December 2024 07:06: > > On Fri, 20 Dec 2024 17:26:38 +0800 Guo Weikang wrote: > > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immedi= ate > > panic is required. To simplify this behavior and reduce repetitive chec= ks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavio= r. > > > > Seems nice. > > > ... > > > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > @@ -417,6 +417,19 @@ static __always_inline void *memblock_alloc(phys_a= ddr_t size, phys_addr_t align) > > MEMBLOCK_ALLOC_ACCESSIBLE, NUMA_NO_= NODE); > > } > > > > +static __always_inline void *memblock_alloc_or_panic(phys_addr_t size,= phys_addr_t align) > > We lost the printing of the function name, but it's easy to retain with > something like > > #define memblock_alloc_or_panic(size, align) \ > __memblock_alloc_or_panic(size, align, __func__) > You're absolutely right, this was an oversight on my part. I=E2=80=99ll mak= e sure to update it with the correct function name. > > +{ > > + void *addr =3D memblock_alloc(size, align); > > + > > + if (unlikely(!addr)) > > +#ifdef CONFIG_PHYS_ADDR_T_64BIT > > + panic("%s: Failed to allocate %llu bytes\n", __func__, si= ze); > > Won't this always print "memblock_alloc_or_panic: Failed ..."? Not > very useful. > As mentioned above. > > +#else > > + panic("%s: Failed to allocate %u bytes\n", __func__, size= ); > > +#endif > > We can avoid the ifdef with printk's "%pap"? > I appreciate you pointing this out. I wasn=E2=80=99t aware of this approach= , but it=E2=80=99s a great idea. It definitely simplifies things, and I=E2=80= =99ve learned something new in the process. I'll incorporate this into the code. > > + return addr; > > +} >