From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248E4E77197 for ; Mon, 6 Jan 2025 02:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2B46B0089; Sun, 5 Jan 2025 21:18:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A82396B008A; Sun, 5 Jan 2025 21:18:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 949D46B008C; Sun, 5 Jan 2025 21:18:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 787CF6B0089 for ; Sun, 5 Jan 2025 21:18:03 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2E606B0A48 for ; Mon, 6 Jan 2025 02:18:03 +0000 (UTC) X-FDA: 82975416846.03.8C0FD44 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 5FF8D40013 for ; Mon, 6 Jan 2025 02:18:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mzep+yBW; spf=pass (imf01.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736129881; a=rsa-sha256; cv=none; b=6V4awWt24be2l5gsvZ0Z3qLnPWr0/hDm+UjwY0S4LOklgVoGVHmEQZAwQgIAUpMbcX9g2s FLbpL3FEuPn1fWEmsoeriqvtLuHxOgPu8Z0YVUaY84QrLAvvpfZFeH2d/rU9qGqw3pIBNW etotrXmkwFt3odg1VLakFhr35Q7vPg4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mzep+yBW; spf=pass (imf01.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736129881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XI5Jl7SnwjypqjTAmM7cNiqL58HAEuhA3myRhYUJCBw=; b=f9ytjbj8a6w53Dxysa7tERMTrW2GRB6MkHksnKD/c9BHK3PvSRssveMPaNTWpDr+fIhsbL 31dgPez2mj4Qvph5ZfD3U+R6Vm59ApYevoPkmHG10Z6T1hK6W9t+opKWUKTCGJaMj5iAHz ybdVlU1V9giDVK4+jiJ4/TcvHUqiioo= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e455bf1f4d3so15160948276.2 for ; Sun, 05 Jan 2025 18:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736129880; x=1736734680; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XI5Jl7SnwjypqjTAmM7cNiqL58HAEuhA3myRhYUJCBw=; b=Mzep+yBWBT8pRgGYaIy3IUHBOtlmYWkzRkLZa7pCwjZIlTnshMOfBX1J/MvkGjHBar b3VfbIIHplnfUymfFvzSWmV6t/NBLcbDDbtDuQV/H2tRkZfQk76g0EO4WPr45okH3wR2 fNNtEwKGsC++8j9fZgA3GqhiRdWIkwhFSJ4iu7GqgUUWMNp2ISQZGYSaadLInO4g+O6/ TIyxgXgSd5NW5kS059tgPOYsiOP5y1lOkj1o199GdXJDGRphsP0rwkkrgl8n6junmzRx FOMC1BxREE5fPF9W7UCI1w+qlLy4rPAeTZl+vPiS1sWHbs76tajRC+ytE7GwT33Jn+rT T+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736129880; x=1736734680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XI5Jl7SnwjypqjTAmM7cNiqL58HAEuhA3myRhYUJCBw=; b=n5bu175dcYzK2nUop0sZPmqN5H/lVRvhptWAtSnfuMpCVuzsb7AcAFe6vCCjTNc+Hp Aum2DxFNXLWWFe3c9CUk5ThE7xCWri+P2o2bdR/q+lG7k9/XQzCVyafc4nHxf1gr7bzU 8WolwiiMKse9JCcyigtFpUtn4+EnQlM12DQjWnp9SCHQ4RrEeDfQiu2PB5y4OafTWgi/ oS+QLu6XhqVE756WhQ5IQSIBg9PQOHQYLvQcSwbCVTraq08wc73BZLdbVDVN4zgu+nHC g+8yEy53R7JtcRKJK8Up+7cbuZbqSgqDRzj83PTDhhFOTmCbesW9HDOrRhHV1FYLh/zi j8Jw== X-Forwarded-Encrypted: i=1; AJvYcCVwK/peMydsvh6Ov5jSHkfExLvjJLPYsESo42txNJOVRG89TYG8iSuoZULwXlLk+q3XIcg1LhuxUg==@kvack.org X-Gm-Message-State: AOJu0Yz00UZ83dUut8pMO5AslorUyM1L78b0ithdWfrEXVgc2UVgwxd5 4HVmgB2GgiL5mCz79/mJhP6PeT3rPGDRxB78o8hqUOVfotTDa+aoydeUx4pZgx43Ln1lWTWLPIs myozL1wDHdP5HkNBx6fYOnGDazO4= X-Gm-Gg: ASbGncsWsrfC19NCOWQLXVPhqjarbb4BdN2IlpNcBY1/jAaWpfHiHIWCovSHWBe4eEp 4pmJoInI/72I5kYIISuEyL+XwqzSwzsIIQFWNelY= X-Google-Smtp-Source: AGHT+IGMv2ixUpKOZzYwvd49UXJRl4Mf6drEyGypj7bw2oJO+ri7nTtmPE8VC3Wj4GRWqwJ2+GxMfn0BKWqtX7EMjgo= X-Received: by 2002:a05:690c:8bc1:b0:6f4:dcb1:5bc7 with SMTP id 00721157ae682-6f4dcb15daemr53079047b3.1.1736129880446; Sun, 05 Jan 2025 18:18:00 -0800 (PST) MIME-Version: 1.0 References: <20250103105158.1350689-1-guoweikang.kernel@gmail.com> <39e6c57c-0a8f-4f4a-b6ae-27f2ef6bb8fa@csgroup.eu> In-Reply-To: <39e6c57c-0a8f-4f4a-b6ae-27f2ef6bb8fa@csgroup.eu> From: Weikang Guo Date: Mon, 6 Jan 2025 10:17:49 +0800 Message-ID: Subject: Re: [PATCH 1/3] mm/memblock: Modify the default failure behavior of memblock_alloc to panic To: Christophe Leroy Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5FF8D40013 X-Stat-Signature: 5f4nbq9qb8xydaqpnyajs6skubd7xas4 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736129881-825260 X-HE-Meta: U2FsdGVkX19r+zKEcObEeIcUNyon33Zg1Azd66RCfWiFeOH6EKJAtS5LtJ74sLdHOK6HOK3XJGbhsI06GrMT1/0iTtzT3MEZuTOV0KpSXhyu89lJgtrcQ0M4nSNSRJpFCT4ZOO4Wxyy/CE8q5WFPpRAHjclFIM8LCiYGiUV+EdFzLdCH3vzGsBMi2nKnKJOJv9rp07cMcMmUb0joetUwcXED7HM0O/L1b4EC5eSF84/w9gvawpTwumoXHBN0p8no1Pdm+UZHh0mT4s1cRbptIgsFdChctlGaibmspZcsJjf/ya4a8r613sPoXjhH4rEgCwaU2G7Gjh8QPLwbXTadB9mVBzs7ss5eoVaQaauR9404sGakSZ0WkDAn/U+U+RgHRouPn7WAWzuMpFBU77hxEe7ZtVg+j0LIFNZDV863rzJbk7mgGeFdojvOmLAjoWC1WPRaKvC7pbvyXuIAWlsFgwB0GoSMwvngOGj+UXoTFvryoaOBkhIwMQ1tpDASM2Tccp3YZdbWzBmrzWlIEpmkZfGfHv+i3wIWbNdPpgHIdL0XGEJRZfEuCvwwN4ZQlfLH18YhsCPznlIgM0uu0R0bPC92kb4/P2IO2tjoAiD4WiSRna715BX4giFxqa2fPPwVY/Ox7fKOU8ZEAVuU6zuKaUq5OZeJVtTeHFogk/t8GKDJaNw1R1BdMEQHIYyeetmHmGyA+mtTVhQni2zuUpL/4CofyNmrawMSbgZubkcSNg/+HU2aqnF4RU/Cyss6QbVmowQyAsX054z4gbwDGy7LvJtQ8bQ10ggMURSdwGfWQYLBNATta0MBzluzBxCXWuPJOTn4oUvF6O2mfuXTJRJBX48ZZ0lqHQ6OvluZvXrbNEPOd53UMunx3gJjWJxeaeR0XCWDZtry4i9NC6037/tx5A8ARKtd6Y1gHJ8eOHZ8UolSZ3JKhkq3xlGgTOcRI4jtrXVr7skPu8G0sJscHd7 FV14oqlD H70wrsUHyaKFWy2E0oMbdXF0n2pjLtrFH05f5GAm/VT5g3iiMq9kIlUXxYzT3gSb36zOF9YtjOZ631Z34ubZycGge4y1xeCovY0BqA+lhmnEtqtUSKdi5wQNGq93aiQB3GTkp5gtxYSJIpJwbPinxaf4Phwqhg+7iadJlP/vhOATiIZJKO1b14NYe+ZlR7kFPRbkSriicz2jIXwnoBBaeAvEEBzHl4jMA42LUn3d+g2UE1jw3FognBtAfAsvxtWHZD1OmgeEsATefX0mivnUhdWV8dcG09VDGH5cvhb7H134GYMjXH/ZsKf/NnEvI2aoQQUHEFGQqlU+EcqLcxbJaQdhbx/VT5AStdXsghm5QQfjKlCRscyAK7MhMww7FlrpyoN52K80UeRgRmPFGgpGSwwPpgFegK/XcjLO9I/w6JfJZvUwdCLn16ncImzCiIbiwbAXR6deumfJHGsY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi,Christophe Christophe Leroy wrote on Saturday, 4 January 2025 03:58: > > > > Le 03/01/2025 =C3=A0 11:51, Guo Weikang a =C3=A9crit : > > After analyzing the usage of memblock_alloc, it was found that approxim= ately > > 4/5 (120/155) of the calls expect a panic behavior on allocation failur= e. > > To reflect this common usage pattern, the default failure behavior of > > memblock_alloc is now modified to trigger a panic when allocation fails= . > > > > Additionally, a new interface, memblock_alloc_no_panic, has been introd= uced > > to handle cases where panic behavior is not desired. > > Isn't that going in the opposite direction ? > > 5 years ago we did the exact reverse, see commit c0dbe825a9f1 > ("memblock: memblock_alloc_try_nid: don't panic") > > Christophe > > >