From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09623E77197 for ; Mon, 6 Jan 2025 01:45:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09ACD6B0083; Sun, 5 Jan 2025 20:45:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04B6F6B0088; Sun, 5 Jan 2025 20:45:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54C56B0089; Sun, 5 Jan 2025 20:45:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C70F26B0083 for ; Sun, 5 Jan 2025 20:45:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 51232A128A for ; Mon, 6 Jan 2025 01:45:16 +0000 (UTC) X-FDA: 82975334232.13.8723F15 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 89253A0005 for ; Mon, 6 Jan 2025 01:45:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JFjqYOBV; spf=pass (imf15.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736127914; a=rsa-sha256; cv=none; b=OWfKit6AS4WyqpQ9NJKD/aMHXRM28y1KUBLnP0vsBtvR4YIzgM7B0MhipLKt19X4n2rWp0 dMHT5DyvTIdOfFg1OpqPLlUCHcL4s9y6kJzFTDcUHD+W396yvMVeI5fQ/sqgz7BH4CNBTM VnFtGYb1Cl/lHe+vIC4VcFTapvKnM9I= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JFjqYOBV; spf=pass (imf15.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736127914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E57G0uX0D6rzvmmB77bv91KjqLRLhdK9NOjZpXfzwQY=; b=2i3AclChPxLv1o/QmLBJY1nTPAQvx0lMnLAHurGjUMS+tSmWwh3SLPJ4zPjmjt5bkPQzx5 r52u0+2kHMMJDlzqqhHGJRMW8xPzhZR40GGGPS74mAJWD7yG4cMOK7YbtNXF4t4lApwChP Bb7fJOKYbeUM2+pAIj47eat+U+pkAnM= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e53537d8feeso17875227276.0 for ; Sun, 05 Jan 2025 17:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736127913; x=1736732713; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E57G0uX0D6rzvmmB77bv91KjqLRLhdK9NOjZpXfzwQY=; b=JFjqYOBVGGw2B6DDKzRHNBJumL/lTr4//xP1HBWPnCgLjMH8RYqpMriUnJSR+JoRNq UKHVSzvWvpoRZuknqo0IoMeaDpuSlhtcA7Gff8xd3Bb6ayhZlw9GJutCctVNSHkbddot exqR3gd6TduCbexFKkRcUMC6N71lIBhTwgcyEwOa2CTgZfeD9MIXNC/qS1KIIFGnyxLL 5i5QKfuMK7q5PWYtoq8KNlL4us3M1HnNB53v6TMiR0CMczEDeNgtLPVZG4lYdz7mlqRN nqL+5BJ8XN7TXtkvE6Z+lwz6NvLM5zQAD58vl7XMWFxZAqaFcI498jfJRCjaLvC7DmsJ JLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736127913; x=1736732713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E57G0uX0D6rzvmmB77bv91KjqLRLhdK9NOjZpXfzwQY=; b=EuBSznouiB5yx+5ICm+/5/vJlMvNfjrfB8Up7IBjHhNDIdCRBVStv3ojfCLkvxwZGE tMHlovwd0CaVf2PG57H3dCp4HCFGkB+YJPXqc/b0KPvI5jilBNzYHfe1hvj8yHnU6Vpn U8ruQq8Q2eekYUH9m5HCPPrI4RqB3bbwKgO1xaj1c6cAC6zh5CJUTk21yM9+mtPf2s7k N4wDed9umeb7CqS84Udczd+YByRT4oOXyIXico3ZECtN4VyT0TYo16YMxi+4Ryb8wq6w auCwR7rUGOWfTGPTv3P3LGKSDhv7Rl516bLInEvqX+Ms+wqa6VERa3R4jTuRmK9OOR6j 1QuQ== X-Forwarded-Encrypted: i=1; AJvYcCWjrsGQmKhJiAWGHnmTxBrhFR95CP85KMr+Z+0Ttduzz5/oSJPuIe5X9n2wNHxGuGUFfDYkQT/d9A==@kvack.org X-Gm-Message-State: AOJu0Yxa+lWMXADTUrewB/pIOrAKCcUKZgW3y6CkuRPmINLhFHEpyoPr ezJNy9Gb1sJ3C5x2ybcy9xIr8XZpqQnKuAmBdZ7qoy08WKvzh54AO1xWDoXeOg8HcnFhXIwwVPL Hzeo1dnrVPgidG6aptylggt6uNYs= X-Gm-Gg: ASbGncsmqN+WJ9JBGsEC6k1LdStBAxl/lv9nHUmzuDkzUDoE7HaqhFvaXlVaZ7kSOOx 4m3l7Wo4IbQGlHSMwmEZ+/8l8OJbKPk8jSrtxC7A= X-Google-Smtp-Source: AGHT+IHsLNVD89+xzk0t2qpQjzPUEwX/9yzDwW0ejaFXzSxFcqA9aHJsPv3eafRxheSmAriSJ6A0in2dUIWlbuBjAQw= X-Received: by 2002:a05:690c:4988:b0:6ef:a5bf:510b with SMTP id 00721157ae682-6f3f80e5251mr419235637b3.1.1736127913525; Sun, 05 Jan 2025 17:45:13 -0800 (PST) MIME-Version: 1.0 References: <20250103110150.1352226-1-guoweikang.kernel@gmail.com> In-Reply-To: From: Weikang Guo Date: Mon, 6 Jan 2025 09:45:02 +0800 Message-ID: Subject: Re: [PATCH v2] mm/memmap: Prevent double scanning of memmap by kmemleak To: Catalin Marinas Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 89253A0005 X-Stat-Signature: n5x4tupgeynu8jfs4ikhnrt1w54hyt79 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736127914-99373 X-HE-Meta: U2FsdGVkX18zkCkWdzU1Frdhd1AZOEUvZNg/8pUj9PL4ncxnEtg/8PiTfXE7MolrvQXveFpRB6GnlAfjae7wlzsC6S6AOTnftgj002a0zsWAqVVyHAwdsYS7sA/f8nz01uqCP8cM2/Td1J7HYNDYglmPpDrfjrPmLy5+TovDJxvj503NB0o+NjoEupFWD4gAoqEwsQ196PqcMxa3Rf+pjPNLSECGH1Q+nJM51TwtUNn6XNWXUpSOm4SpnJoBqePZBGZoMIqLVecQ0PxqS6HEjhml4e7WGI5cwTalNtbfRhyUmvUfyPovegv8F3szeamozxBGuiX368QI0+QbibTFxyasGx6GIIK81CmZZ3EwbnXDt7olL2yQszSzoTJ386LrnUr4aXq6gKKxDdwoBpxXbqhftPKm85q8boGa5fXAQw917C4f+/tzeWawYQPGPT88fl2QOrEKmzxb1MRzdcbn2+sHbhw67f7W/hhgkVvcyd4Um+xLFVun1kOxDGM4eYo0+P7Z4ggiuHH5oBeTWaQut/pK+KzGGhP36wl9t3rHc0THTqIqTDJHjYtUbJ0MWQ0NWkpz9uWfJvGBpRkU75GZW/y4sVt5Z1a7pTQmnC4R+yrQ/6l8joVIvtc32U6VgFT7DH/BRGE+e6H2l0vUSv/kfYLS2UtkOMTTd/zVuSKkn6NAATFeR/AOqe/fajDbI0/laBveK3bv1Im7Yp9PKo33PEf4OiPTx8i0YEcJ5RFSgOLGZ+pEKbD/cAcQAOMjMuQBw+FuW3PcKN1VfKsgbWmZrSH6intp8iGSAjbgPxOBJN6f4vqS+OArMa+IGzUWmdOJGv6FjecUVqb30YuACf4YIvtnzwTCgoEuKWGMUdC7yzMLUFDRi39jfDxUP1YoKo7R/CzL9SrDgulLSmhck0zBVukVxhyy5GJFqxpZYVOIwk8vSO/RoLlXU/HYUCaQjSQqB2bheq2H+/ZwuCa69KG 1kGINQgY DrYwqs+Zp6ZeQIcprysKTwKutX8HBBjyFzzEmsc9t61FQFqJ0g4wRk24rHP9eLwlKlcCA0Ooc0aP7VdtAAZlX9tCoNSMs/qgJRD0utMGa6EHKrd9b3CKuz36fx9HlX7xYBwpo+iekTWG14+O9MijLaxwd3gwI/rh/YSG2GcZY2oN1M6USYbQYcF62tpJbVxZJXSO3SePEmbmlWNRMv1Jv8nsMYiJ4zPTXtjFIbq0Ypfulf20xG75WK0+324RK9dgCu1DMwsmVXea8J1WP9pCOM8RC+QCz6DGFNxl5VqSohL15xJfqHEJ8WY6J2+FuxnddSAVWA8RBnIF6kzmBZhv7tBW8DCt69bae1y7glT0CymHRjJ9sFSePy1kSWuTQCaKg4OYXCyU1QLh+0A1e6W3OHDXHuHwEl6MVYHSDBTWDXOBLAukSlbDlnv6hzjC2mknMJZQQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thansk=EF=BC=8C Catalin Catalin Marinas wrote on Friday, 3 January 2025 at 22:28 > > On Fri, Jan 03, 2025 at 07:01:50PM +0800, Guo Weikang wrote: > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 24b68b425afb..71b58f5f2492 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -1580,6 +1580,10 @@ static void __init free_area_init_core(struct pg= list_data *pgdat) > > } > > } > > > > +/* > > + * Kmemleak will explicitly scan mem_map by traversing all valid `stru= ct *page`, > > + * so memblock does not need to be added to the scan list. > > + */ > > void __init *memmap_alloc(phys_addr_t size, phys_addr_t align, > > phys_addr_t min_addr, int nid, bool exact_nid) > > { > > Nitpick: normally I'd place the comment in the code, before the 'if' > statement. We keep the comments above functions for a description of > the function. > Thank you for the suggestion! I agree that placing the comment before the 'if' statement is a better approach. I will update the patch accordingly. > > @@ -1587,11 +1591,11 @@ void __init *memmap_alloc(phys_addr_t size, phy= s_addr_t align, > > > > if (exact_nid) > > ptr =3D memblock_alloc_exact_nid_raw(size, align, min_add= r, > > - MEMBLOCK_ALLOC_ACCESSI= BLE, > > + MEMBLOCK_ALLOC_NOLEAKT= RACE, > > nid); > > else > > ptr =3D memblock_alloc_try_nid_raw(size, align, min_addr, > > - MEMBLOCK_ALLOC_ACCESSIBL= E, > > + MEMBLOCK_ALLOC_NOLEAKTRA= CE, > > nid); > > > > if (ptr && size > 0) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > > index cec67c5f37d8..903a5422907b 100644 > > --- a/mm/sparse-vmemmap.c > > +++ b/mm/sparse-vmemmap.c > > @@ -27,7 +27,7 @@ > > #include > > #include > > #include > > - > > +#include "internal.h" > > #include > > #include > > Another nit: if the original authors of this file preferred the includes > to be in blocks, I'd keep the internal.h include as a separate block > after the asm/ includes. > Here is the order I actually refer to `mm/sparse.c`, but after looking at other files, I think your suggestion is better. > Apart from these minor things, the patch looks fine. > Tanks! > Reviewed-by: Catalin Marinas > > Thanks. > > -- > Catalin --- Guo