From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1811CE7718B for ; Mon, 23 Dec 2024 07:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 829926B0089; Mon, 23 Dec 2024 02:32:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D8B26B008A; Mon, 23 Dec 2024 02:32:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 679CF6B008C; Mon, 23 Dec 2024 02:32:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 498E06B0089 for ; Mon, 23 Dec 2024 02:32:15 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CCC301C89F0 for ; Mon, 23 Dec 2024 07:32:14 +0000 (UTC) X-FDA: 82925404296.22.B536DB2 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 4B1A014000B for ; Mon, 23 Dec 2024 07:31:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ibiu0/cx"; spf=pass (imf09.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734939090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0v6aG1YFkKVxPZgrKFkppCnD7setaclMAdKcShBz7Ms=; b=bcl7g1ZWOHWvmZWQ120174U+aRPQJPsWh2KYBKi9uJrO6u27RJEXWKC0C7CJylkmjokSLe jDL1rCutwIqGZVS1ZrT7bf6BPJ/f7re1GYF4IGL5+67qpU692PkJl4pYLegyL5IYSFtHH6 8y4Q2pLzCUtawDzDWnkj3LRpeNjP3fU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734939090; a=rsa-sha256; cv=none; b=YJTOhQYDCj73C7tFIOlaxpOy9eAHFRIyV+3Pe0iS6LGzv1tms/SwRKpXKwXMVrzBGdZqWb 0CsDCC1tybwnEcohta8wPJPob//OsA0j7Yaexq/reNU8i8f+au0hOWH/inUnSRdXTxEa48 ytxy89jpafpP5ZyM3wMdV9NQlYREyBA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="ibiu0/cx"; spf=pass (imf09.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-6efeb120f4dso30106447b3.0 for ; Sun, 22 Dec 2024 23:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734939132; x=1735543932; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0v6aG1YFkKVxPZgrKFkppCnD7setaclMAdKcShBz7Ms=; b=ibiu0/cx44jZdC1ZUAJzpPngIidc2KKJ7sBScNiSFvpNlCCoDPPco2vtT+VVwah9g0 o/+/AAEAR1UPcdFGrJCpVBV4qkQ8meFtKudfkBGudqfTQejOC55xBzdiUevX2E2TcdlG 8yo7jdSiGdQ79+ST/Wn/Tdn2DHUkg4hmqR+eOCmz5Pwbet46wwsdqtFXJGFqaLyOh6he /p+gzrUtFNAzwE1LSbM6D206MtYEb0KFLGm0Gyjo93dVNydiUBOIq1LPQ2dZom3OrSUZ ucS/ZJQIUHI3FiRp/4s++kJE1r9puw2jSLLAUEfUOlLTV4aE0QK3IBgSyT5gBLkjGIdW 5xgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734939132; x=1735543932; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0v6aG1YFkKVxPZgrKFkppCnD7setaclMAdKcShBz7Ms=; b=dqe2AVbvNdTotNpeQIp+dWFdUj78R20UimhfA0e6aXg7RRWvA7CerTUFG74QPEV+o1 HJKp/IaeKEurXRmeR1S+cm8blFbs99VQO/lHG5/ciE2ptECRDm0nNr2xkRrWZw66A8uX z9nlP5535+YjLogygRbXwPAFp9d+H2AUQFE8oApCWeuugHz5TNrsBVJM7AZakpXinwDr +1sHbtrhZT4vO06rw8bH6T9LUHMr3DfWQwXWismEsfL3k6AAbVV/bYUVif1I/kkv05p/ r6KmgOTc6rQCJel2T4LS48GKTXZ3qdM2TH1vTj27wpkLjUwVGr3LVc2HIeH0hvzbB06a 0iDg== X-Forwarded-Encrypted: i=1; AJvYcCXzuQA7HkSMRJvWLAyRokTjzkaat5lJ/gyYffSzjK4V5im+DHcVgolTm3I5AlNkxIj5ZjTQvd1Nkg==@kvack.org X-Gm-Message-State: AOJu0YxOxcn1CnuVOmQ9jZYns3Sw2Zxn2PAGCu/Vgo5FW34r/b8WMJCg DslsBOuvIFcj+icl2psM2ERcjibJWvxwIkmJpg9sWnBuAqNupNlhgWCkWe+4a0uyLOKK1CqtFEX TR7FtRVowBja2k232nydQ5rRkEH4= X-Gm-Gg: ASbGncvbw/BvEcItiCWcva7pK6wayFL0CsX2L4bZnv1ku6Zh7snUTl2NaNOzdlRGbFX 1zOBCHczzWfHcHnxXRee6ZzLfpPQDhTVxEMVhMxE= X-Google-Smtp-Source: AGHT+IE9Zx6rrSxmo/TfVMJEMfCSEvv5kTOAJj2WU/ZWv6yREWR2EgA4NDWJv08ZAUMMHtBOTiCxaj5H+lZ0CIJRFqw= X-Received: by 2002:a05:690c:6e0c:b0:6ef:6b56:fb46 with SMTP id 00721157ae682-6f3f824cb08mr87351047b3.40.1734939131915; Sun, 22 Dec 2024 23:32:11 -0800 (PST) MIME-Version: 1.0 References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> In-Reply-To: From: Weikang Guo Date: Mon, 23 Dec 2024 15:32:01 +0800 Message-ID: Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface To: Mike Rapoport Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, Xi Ruoyao Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B1A014000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: mmqakhcop5m9z6ka9x5cm4sx7rssen7m X-HE-Tag: 1734939107-41656 X-HE-Meta: U2FsdGVkX1/YhzlchG5PTkNNsoNH2rzfGerKCzN4oQo+N67tjt9oRMzrMfEb2NC1VEUIZ6pfgDVkIRfe5YSIAPWxyYrhxCHVwmJIyaRQR4wapZBtkHHZHGBUKTjONnFkMpim4kYyDfA0OENASkvqwVzoGc/Lw6j3TCipJz0F19JWPW5PrHsu1zAwEK6qrkH2N6KdUvVQLSEvnFbuAETmjxHRoYCjvPPF+AkzxaU83fMKa6mMdleFyHrKG1zP+swAQN5kj389KztBzQs7TvZo80WkV3QV3BCC1fBghEMO1QpH/Yoepv7XFw+cko5Zo6nbdWb5kCVGlQABvw79bDWz5j386PElNDebJc3xg5vRazeHMAc0iBe54GLWEMJGAoGiyaZ6GyynhGeZ1506Cp8aaresue3J3m8k4qORPmzFB4KE2VgNlYoXkAlVTAKHpPbrqixn7fnePnqpanOdrzg44cc+Rsk7XSoq1KiiqIWC7RLUzSnPMLDszXilNqAcxRwvTe/0QgelO6bEUz2CPjG04NPD/2322U4/KmgKxte6E9iULAtloxG4N6v0k8y2tJz2zf6JoV+1SZXp9V9JooCBrbEU9Y+Ugyibu/kyiZ0mwlmOnwQiOYmuLtMkhMZR6bikMEsRQzGauWdc4SQzV8bXMVz4hb+Q9E84dEkYzGOtVx4pgw7cembIFJN8wv76cJcZHAjQh00UD/56N+BvQobrkRCK5atLj9VB+0HT4htoiQpPg8t9POtekhZOJmsXrptI7tfFU5tQD+QG/n+6PSlDY0+L0waoqk2EtD02nIQoB/idfe2fjOkfN+5TTX6cZ6n4lf3oYX6u8Fesv+9YbrhGIW6AkDXlsJJNnIANGE4QcLEvVliNQH0ILDpKx1NgaR375gc3zpyE1YC4/nOW5p4aZYitCCL5m+t8DXLZO4LoefX5jvWIrwqNfPmF5mYYJY3t2IKT1DdURcSZQ4u+/Bs NciLB7cQ e6Gs8XGJsSFRTS+l8uLavWHKGT7Tr7czipYoD8f1BQjvuXVe6AaAZ9zS313CMTzRUBRzvrUWkZ92m8rqG0xB3SiH8tuYluisPDA5kXSf5nvj4JVcoR2UFiXsR1yc1R1TpW3lduCtP/YVWJpZ8XT1a5z5vC7smMCPFc/zG670ZYtsdUCECssoQG/B7kDwbRQeBtp1tsJURasiCL7uNZtXdeA/Az9S7nXCM0Ead0rHoy3YhpC1uDtLU2nLap2R3y3E+VI9KrjDCHYgaxbVnC/HhsDAGO8zf0eBIWrsQ414rKVXs6tpextBedjTCSHhn1LHIWe2V6A61q21vPpHQW7aN8Wkc4LcFdHuEGwUhOlcS3JxHpnKCHJ61ssEO2+3tV4QrJtRyReg4+3zyKYEtRlKI9uwXjTTL6MhQHT7R/3clYeeomPte08Tajeowwlj5GxhttqMeteHPIFWj0MF+lbyQAwIGYmLUJrTIzTdWbsPr2QoodBdVP7y4M2u5NqJdh9vEilsRGxn8OiJp+IGF59wc4Nh1L+Nv4+w79JQmyaDBuJd+yDZHsIepOG9f3XZdy9Ta2Oniad3QFH8FdaXtzUtKjdjXfNYFZDE1aoS+3pO8VEGHD1aQqvfWdCmCrLtjcIJWLy9a1Rt/RhjKdWc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mike Rapoport wrote on Monday 23 December 2024 at 15:12 > > On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immediate > > panic is required. To simplify this behavior and reduce repetitive checks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavior. > > > > Changelog: > > ---------- > > v1: initial version > > v2: add __memblock_alloc_or_panic support panic output caller > > v3: panic output phys_addr_t use printk's %pap > > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > > v6: Fix CI compile error > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@intel.com/ > > v6: Fix CI compile warinigs > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@intel.com/ > > v7: add chagelog and adjust function declaration alignment format > > ---------- > > > > Signed-off-by: Guo Weikang > > Reviewed-by: Andrew Morton > > Reviewed-by: Geert Uytterhoeven > > Reviewed-by: Mike Rapoport (Microsoft) > > Acked-by: Xi Ruoyao > > If people commented on your patch it does not mean you should add > Reviewed-by or Acked-by tags for them. Wait for explicit tags from the > reviewers. First of all, thank you for your reminder and patience. In fact, this is the first time I received a patch discussion when submitting a patch. About Reviewed-by or Acked-by tags, I will not add it myself in the future. Regarding this patch, do I need to provide a new patch to update it? Or will you modify it? Looking forward to your reply > > And don't respin that often, "Reviewers are busy people and may not get to > your patch right away" [1]. > OK, I will be more patient and update after confirming that there are no more comments. > [1] https://docs.kernel.org/process/submitting-patches.html > > > -- > Sincerely yours, > Mike. -- Best regards, Guo