From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E843FE7718E for ; Sun, 22 Dec 2024 10:23:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513656B0083; Sun, 22 Dec 2024 05:23:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 475CC6B0088; Sun, 22 Dec 2024 05:23:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C7816B0089; Sun, 22 Dec 2024 05:23:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B5766B0083 for ; Sun, 22 Dec 2024 05:23:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 882D91C8401 for ; Sun, 22 Dec 2024 10:23:15 +0000 (UTC) X-FDA: 82922206080.27.886D748 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf02.hostedemail.com (Postfix) with ESMTP id B47C88000B for ; Sun, 22 Dec 2024 10:22:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dQjQvKuB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734862959; a=rsa-sha256; cv=none; b=F/SjjQC5bCMIm7xRWMZes6IGgrdWivJ/mbp0okMD3wbwNrUgMeRqD4cKQd//BLvOzJDg4D ny59Si/Byen9rmSBvOpI866rR56CZhVrevKwHrwXU04sdcYR9AXDolCNm81rR2XWXpvLaP 856Ad+zZgWHM6GOV/540WEy1SrBu+qo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dQjQvKuB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of guoweikang.kernel@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=guoweikang.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734862959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ONVNbxYIwyadSLDvwLNaPGVW+13KFD/yyNlBVYXNzc=; b=8liyMlTYdfriIPMq3M7ycg7fqW5aMBnyaAIRjX/aWhoJdHfsiz2TBI31es6LmSxqqZjuHz qAHKuoxnLV+zjBIewm3rZ0szfmavGM5RNtB+sYrtT4w+QAqpV8qzK9+XZrMJH6d2ij0dd1 xoITZuSPStW2vRYKG2gnpi0p+OKVehk= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-6ef81222be7so29026017b3.3 for ; Sun, 22 Dec 2024 02:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734862993; x=1735467793; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/ONVNbxYIwyadSLDvwLNaPGVW+13KFD/yyNlBVYXNzc=; b=dQjQvKuBH4Bwyx31WBcy5GXMMoT5aDCVtDk8FYrk6jLsV1kMMpKpAZ76wGXqHjqLIG V6/LNRoEZYmkPwlldgE0/wZxbiO8FKknlXVFe93cwdGKBI6ktJkUW5kO5VjXSMh/XiLE Cwk13M77DFuUD/XXjMipkq+7ZXx74m4Ypu1Fl+Z6PinjfK2PS6Bg3iAjAyqNjEsii6E9 pW2p7VUod5gLYCs0SX/gebuSrZZTz2kNlKKq8EZe9sG+zhWpva/W6NjKxVwnWby/r43E 7MA0goI9iUFHwR60K5v7zDmDZ80IWU8glDdIeV/9gWNldkYZxdfJGhspnKqCVj3fznd5 dR+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734862993; x=1735467793; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/ONVNbxYIwyadSLDvwLNaPGVW+13KFD/yyNlBVYXNzc=; b=mNn2ilLHafsQ910+pdkD36giftUFHQfgx62+Kr6rdqi68PkmjYU6AHwq7jl6+dY2fa fD830nmmT+fsot66DGOLvflkRX2zrSKotLl6T88nX7byQLIC90o940Ud/J96tWYjDYND u8JgguLNH89EMnZ95lxs4VE5ZOqgSXiYkzDwejwpTtZG9+cpUFk4wTjhzaHEB9256DZG nGdtkGq5ERp2bxj1oRlHl/C4wQcVoJ0OliH3YQYnx7PvWNpHH3YlNPf+kFDW9UG0s2nf Ma2r0YlEg0jbV0lC5vV1QJPNOdo7FOIJwJsP4DbFkE6jaq48Xlc2nlXsP0/jOiBjrtPm UKAA== X-Forwarded-Encrypted: i=1; AJvYcCUoR1Zp8wkyTMaGdJK64I5+42fhcSbxw+OvtdGeM3wgxPANdIaGnkt39qkZi89G2dR//Z3dau2ycQ==@kvack.org X-Gm-Message-State: AOJu0Yxk/d5xGS9KOPTcKnfZl9bU7YsjqBmvBKO0KAlfA+qrn0nG7L6t B4Z/EO+wc88EAPp73FQV+PpaExqrGOJhP3Bd+8b4LIRGaOCCXK8DWKyFQL4hzJUEgUcts3riU92 0q1ljzNePRLfo6+A6cKHqqUayxdA= X-Gm-Gg: ASbGnctlkK0XBUvKvVeIh6CB3GQiT+qrVkeqUo/I1LLZAKYKjURamZxMji+3T8T5PsC sgqhK/3j4cCc82Wdva6binZr3/8h4+AQVBvapPDQ= X-Google-Smtp-Source: AGHT+IHX0mjmsoNFu7Nk/P1ylkLtsHAmn22nfKbaHPnh1Btm1p2RULi24EAOG9MYK2JmawFo9lS/pEKQIPK2LOk3TLc= X-Received: by 2002:a05:690c:360c:b0:6f2:9704:405c with SMTP id 00721157ae682-6f3f8125edfmr74773997b3.15.1734862992817; Sun, 22 Dec 2024 02:23:12 -0800 (PST) MIME-Version: 1.0 References: <20241222054331.2705948-1-guoweikang.kernel@gmail.com> In-Reply-To: From: Weikang Guo Date: Sun, 22 Dec 2024 18:23:02 +0800 Message-ID: Subject: Re: [PATCH v6] mm/memblock: Add memblock_alloc_or_panic interface To: Mike Rapoport Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B47C88000B X-Stat-Signature: hokcpqoofoyzopp5c4wfkrxt5r6n19ma X-Rspam-User: X-HE-Tag: 1734862923-33055 X-HE-Meta: U2FsdGVkX1/kF6YwNtT4VFz4nzZAdx8mn3ID38I/jmNlB0tDiw2FYaSXjaVyqKshzfokZfwgepsoRNWNVzm2jFPGsZB10tDriCsi0TFXKAByprL5hprWwFKgcg9sYT1xlmYyWH4kKKYH5SYgwPeptJxx7FFUpJfnlG9DPpWcldBKkMjbrY3Figz0DjaQtDKczwl3ZsuG6t3Kggd/WH4f9wWBB7mT9ISg1Xet3jyU/apbwKv1Uif9OL/V2JWJpwhsv+HnwJBBEZOPLSTgajqiYDh/Hi5gzMBX1yQrRcJL1nKS0Lj2imMLUohBbm0rgkUAy8rTBUk0r9+lEjyTLt4+dVlkSIEyZMhq67hAqfPc40TYZcuC8UMl6Y83+fSr7nNATI4hSvPE3ztPc8EE0k3IzCKJkYmMt/uq1GzDemItHNetiggKnZ1gp3ebaDZ8RHokYftdIxklnzIJLslnhft00tnwULh1xu7XtPmGZfTQ51Wi8BvQVkfBAs4Xdkz5yjXOEuISXft8RtFhBC93kpu6quZ8OGVfYToG7wlxDOWXmM+bS934MTpew6zudc6h/J1GHiGhxsAI8QNuefBYSP9EcjGimuN2B7TwauxUtEdPE/uYNyeqAihVfcEIB7lnU6Hl1MvUqIVf10EGutTWLfDi1sgEcOkZvwb9D21BITUexcLwLsQlAGl1GtUe8nLORcP/upTs4X4WAG7UGVia9V/jAVstE3Y5oEmSfT6XOA5sR54b+u4z5B226pQrzaqWA0xrQ2cXo1EJ5nrUR4d9XhE7rqkftIKuiS6Jz3PmnpvM66oDhK2qF6vc6Un9Gaey/Ag4UWoVS/v0eqlzNcj23qeHancyz2KuG+uwBJvuProj+l39Cq3j7Oh2hY/H3Sn02LPSPv1On/Agut4jII4cfdr2f7xCYY0NU+dUVrctiJXPPhqc8d3FZaJa16YmchYxzrzkR9IcfTi4MODNnRgYZoG 3gLcl4nl tiHazMhsIzxA+pEutktRhd+d59JKTGxtnRQdd83n0MwIpnRPZ2zH5xySOtSVPV6ziLQy2XP/gfjma9iOBd03FgBJPa24+UXP9wNEQS/IaFnklwQCduk0sSJJJw2KS/BlcW9mQVeEeKu6GCfmNThX7bwF3SUq4ZtOrBYuDuk4MuBIIR4SIbjv9c44/fz6lHKksCn9n06YFv4aKqC96tex90VWlgUMmKgKdw2mke+B6pFFtWMmF5uFwRaCrgplJ5EGW8CE+rLpBn0K8Sp2GKdW1qEc7TkCBUtvUSA97LVbH7vcAglIPudLL3o2la0VJfv7W8sidATBXqQvUmKebohU5ldS6DqaMCpIfGElmCPCok4ZPebaWRaMbiRyfHDNSEd5S7mc4uH0tfxxEXHs90d3spHmh9fEiUJMUhXUHuKVJye/YTXHWvypfQyMFUjqJLgOTGFWhBB5oV6kKjsB+f7Z+8fPxPHpBO/OT/YkOscIbXF22wyA9Y4B7T7BN04Vcu4Y5vBMIATOrkZRe4J0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mike Rapoport wrote on Sunday, 22 December 2024 18:06 > > On Sun, Dec 22, 2024 at 01:43:31PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immediate > > panic is required. To simplify this behavior and reduce repetitive checks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavior. > > > > Signed-off-by: Guo Weikang > > --- > > ... > > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > > index 673d5cae7c81..73af7ca3fa1c 100644 > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > @@ -417,6 +417,12 @@ static __always_inline void *memblock_alloc(phys_addr_t size, phys_addr_t align) > > MEMBLOCK_ALLOC_ACCESSIBLE, NUMA_NO_NODE); > > } > > > > +void *__memblock_alloc_or_panic(phys_addr_t size, phys_addr_t align, > > + const char *func); > > Please align this line with the first parameter to the function. > Other than that > > Acked-by: Mike Rapoport (Microsoft) > Got it! Thanks for the feedback! > > + > > +#define memblock_alloc_or_panic(size, align) \ > > + __memblock_alloc_or_panic(size, align, __func__) > > + > > static inline void *memblock_alloc_raw(phys_addr_t size, > > phys_addr_t align) > > { > > > -- > Sincerely yours, > Mike. Best regards. Guo