From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C1DC54EAA for ; Mon, 30 Jan 2023 18:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5B96B0073; Mon, 30 Jan 2023 13:02:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25E876B0074; Mon, 30 Jan 2023 13:02:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9A56B0078; Mon, 30 Jan 2023 13:02:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EF8376B0073 for ; Mon, 30 Jan 2023 13:02:23 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C15DB160154 for ; Mon, 30 Jan 2023 18:02:23 +0000 (UTC) X-FDA: 80412234966.11.EFD0A86 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf03.hostedemail.com (Postfix) with ESMTP id 023A620027 for ; Mon, 30 Jan 2023 18:02:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QjPHN5B6; spf=pass (imf03.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675101742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2e4q4vLnV4kvKyozPY83n3uJMaYkgSTzaraxFCK6VlE=; b=LPpMq4SqIaogz1gJKVI/Bumc6FaiaYCLBwObo9L9tI3tNZ1UBYA9KPx83Rse2VsFC0pCqf YDXS5GHFVtlDTq7dMJaOrTapDfgSO/OlQlJwdD7HEQQUyx3GdeY/oWiVGgCoHjibmPNcsl rvo5gEXIWdiWhs3FVqt7D3WrNEojbqc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QjPHN5B6; spf=pass (imf03.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675101742; a=rsa-sha256; cv=none; b=12juK6BTINuPRE0ljxuXCXCn5bgZEKNAVyLSEYFIfLhJ7Y2Hw/zMI7gaPi8U84iHnVANx7 qMbqJ6BmLL8PZoQujAKMrN4Ublegy/Z90YC9Cz3CIvSNxZ0RNbBLUXYyMpKCcip2m190ZF Wy7XnKnWjeGNPN+OBLDA/YddDPQLn5o= Received: by mail-ej1-f48.google.com with SMTP id ml19so10654983ejb.0 for ; Mon, 30 Jan 2023 10:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2e4q4vLnV4kvKyozPY83n3uJMaYkgSTzaraxFCK6VlE=; b=QjPHN5B6CALVYF8eJzNIPsG0g1pzceiE2hsCvWmpJNAGD1vrWbJvCZeCcjQ6eADy7X +rHhPzs8YzfZY27hQrxxOVws+NeMmpQzs2dZvJyF9ePDcY6pL5qFpcxv6Z3gjK7XJP8V cByRrvJBuUR2bPrhmi5d/WnmANG7Y6jQK9ldIaDSqBxh3ID4IGOHEOX0TaogXKy8B68f YdGt9CF227lvD+bRgHbXuA/ANtLnfNmLv2C8td08GoyJe+3J4zL8gQFKZUR4Wjx07grD jmy6zNmOrRAYNi0zk7CarTBn76RGSVuzRP3TFEnE334v1V1ZIQxbXypKDzhXSbc1rITc v3Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2e4q4vLnV4kvKyozPY83n3uJMaYkgSTzaraxFCK6VlE=; b=1s3+CfQTnI+welXNviWartWlpQwJZa1xFGHLbyryhwitdpCaLytTPU38nWgrG12b5P JODYy8JQ2BZe1+/eQDnWn0HZ/H3ltk+vIKiSMUTOfVHM0z674kFwiIJ7PEZgD5ZQec+k voJhEsm/haJUew4WVw4dKMO//1Gqy4oP8CGrOeVpLD5hikJibKuOeT6JZIcCiR1jfZ0i 7IZUB2nQi3XnSIHNpJ8eEHY04L2vSUs7EendDvJRJlDy+YUJKf4gXEMxbEKwoa4tjnYO YmFcF22N4RjSleQgHnGPEbnstdkmWtXNkOQAppLs9VbfFhfmAeS+BxQCpG5WadL7xeam QdgA== X-Gm-Message-State: AFqh2kq8RJ+vcrD7wApgmYIpXZqFb9JM/uMA+2WOXSN2ySMBHOPSoqCL ZSKCNEvjCy4SkJ1h09P8n+1szaqztybxPXPX9iM= X-Google-Smtp-Source: AMrXdXt2v8RXnqr0n63brJW64DYfr9lJj0iX+IQ07lAj+juWDoh3rFhuQaZ3DIDSg0TjGFzZmicnL1ZkcXc8EtRtQFI= X-Received: by 2002:a17:906:7754:b0:86f:2cc2:7028 with SMTP id o20-20020a170906775400b0086f2cc27028mr7689625ejn.133.1675101740519; Mon, 30 Jan 2023 10:02:20 -0800 (PST) MIME-Version: 1.0 References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-13-hch@lst.de> In-Reply-To: <20230130092157.1759539-13-hch@lst.de> From: Ilya Dryomov Date: Mon, 30 Jan 2023 19:02:08 +0100 Message-ID: Subject: Re: [PATCH 12/23] ceph: use bvec_set_page to initialize a bvec To: Christoph Hellwig Cc: Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 023A620027 X-Stat-Signature: ws6zfja7cprpyn6edikk4srrzkzp7a8y X-Rspam-User: X-HE-Tag: 1675101741-101274 X-HE-Meta: U2FsdGVkX18FYkiZ0nhSGS/LBY4ac3dxwVN12NL72Ml5dc/Dl7PqKONqGad6/MrGdpL3GEV1vfuSoMALLIgEnlZT0IbybU3v7KIgFMSkm7gmUdE5VYgW4Wk5PEd0S84xdl1a1WObArtX7xuLXZQKdT1NXMA2SZM+TS1c6EX8Y6AsQDwbnfkaAJsZd8aGIczZTK2pPhmItLKZyxzTK55CYNNKjEn8bmMIcZ4d+W65kQwgRhAsYQN4jD93wkfacdvwPDPUguljJ0vsKzyMtmuQR/MtlrG3TWCYhpmeVhOFO8LsatKNmceVLl9bVtMsEOFsnNY7Sy0lmpuyaf5ATUM1qo2lksnN7NSENkM8GMPt3zgYH5R8whKTdEVwdMz1Xi9tt4XoNOZQajXPIGrSEzo9mv+ZvAbBjr1hHV0XtavhROsSrLDDjKmyg96Ojg4Oc+6v1DIlcniXmOUfDBBDrIKr/I8lqtkJsbnXkbcgUzzJ7FsbtFcD5R3P+oEQppS95cgZ7ZH0fwz0T3WgUmEX0kfrJUuLdfkBMu+fkON2GcvMDjP49ymbdKOPYDMs/sBai5sjJVfylJ8YSvpHJZlKNRADSlhyAVCbX8gRwXzNKNmvDi/OEx11Svyvrci/dKAMD7Jocb8buNaBBXao/Oz0AR+NJY2uQBTtgvEzXEZ5K7XEVYDz1HGo7m2x375i1X4yrSCw3T3ytiE98SE6ExXgrpDVD/CYDMpDMk7qB5G0EBaNEnt3nWUgNWBb6XGYwjT/TcWlPWSruXIv5G934xOda+MyMEPMX0p9YhKnb9caP0oIFxCT00uB+gTqtl5wbXJZyGqDC2Oab24UsnGCxsB7xg1Txzpzlx9qIOzsAbVFdHxJAL/jb9YiW9nfY1sit015mui9jYrMOtvsz2JYssPQQObQUcBjKehUuGgsvXZJau2/JAZPp4QiwPgKGjTdAVtUjCfpLl2s21sfXl+Shfo++JF V2Y88dZ1 +Ee+bV0aoPtmBgziA+5u4H2NZ7/odEKJdnQ8nYYaA+vOoCGmRmIdlP2wVqElbhtCz7Svz16FtY0svd5pem4tpuA0yvS8AEYijD4AR+aUUvBAHyaNEQuEbfdgLwMgpVGisbDplybkLWYgA2ukDoQ9lECgsUJlb58yqX8Se74rQJaGZXjkeZoXfNuI+es5ZekLB/mZv5cEE5oOCSqHZZAZ+U9GPJ2JC0xRPdMGJctOSyUfoFKQ8YWnLuZc5EoHObRZryrcdz/mu12GlH5ejyOUwrnMlDYcIxHYNgS4mg/8Y6MWGdOMtDHCOJkNS6V2D8AkDt3WSA6Bry4V0Y+5Cp/9eHtISPQGE/GJ+9wzlC47P00tQDYDKk961rj70Q7aT/MSmxUPv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 10:22 AM Christoph Hellwig wrote: > > Use the bvec_set_page helper to initialize a bvec. > > Signed-off-by: Christoph Hellwig > --- > fs/ceph/file.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index 764598e1efd91f..6419dce7c57987 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -103,11 +103,11 @@ static ssize_t __iter_get_bvecs(struct iov_iter *iter, size_t maxsize, > size += bytes; > > for ( ; bytes; idx++, bvec_idx++) { > - struct bio_vec bv = { > - .bv_page = pages[idx], > - .bv_len = min_t(int, bytes, PAGE_SIZE - start), > - .bv_offset = start, > - }; > + struct bio_vec bv; > + > + bvec_set_page(&bv, pages[idx], Hi Christoph, There is trailing whitespace on this line which git complains about and it made me take a second look. I think bvec_set_page() allows to make this more compact: for ( ; bytes; idx++, bvec_idx++) { int len = min_t(int, bytes, PAGE_SIZE - start); bvec_set_page(&bvecs[bvec_idx], pages[idx], len, start); bytes -= len; start = 0; } Thanks, Ilya