From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50330C54EAA for ; Mon, 30 Jan 2023 18:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB9106B0071; Mon, 30 Jan 2023 13:35:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D68086B0075; Mon, 30 Jan 2023 13:35:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2F2B6B0080; Mon, 30 Jan 2023 13:35:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B7C696B0071 for ; Mon, 30 Jan 2023 13:35:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 81D6FC0A88 for ; Mon, 30 Jan 2023 18:35:32 +0000 (UTC) X-FDA: 80412318504.26.53DA09D Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf26.hostedemail.com (Postfix) with ESMTP id A7035140016 for ; Mon, 30 Jan 2023 18:35:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TdmKB3xU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675103730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9FE8Tg/ETfLF2znBVGSneSNpDHtD4K+4dzhis/koiic=; b=Mc49g2N2BC0ZoqeMfgP5dA5E7xs+LM/vMx2P5cpq13U6U6bLYJ7TrlZY29Un+PggQ6xqdI GlFOThmZBnCDpX0ZE5oJ5v5fuDjZWoYwZUwzT8z06SdBMaDY9mCtnCiZHqhM+NzR1UByqq wV+hhLiwDxgNF7As7I/N/zURMKMZLPs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TdmKB3xU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675103730; a=rsa-sha256; cv=none; b=VZlZ4nDukHmLsyQ/Po3884uGyMgmwD0NJPrhz0Ip8iP3ZXwtNl6zTdOa84FgGQyI7NvYPc 4EFuFMRI3RrQeFlZRAKM2fXgrmc91NatJvn6EGBxczDhkqRtOYE8FlA2KqLTsOZ6eSkE4R bjI71wkHVv163PwPt5cpQXhLe/R3A60= Received: by mail-ej1-f41.google.com with SMTP id p26so23274581ejx.13 for ; Mon, 30 Jan 2023 10:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9FE8Tg/ETfLF2znBVGSneSNpDHtD4K+4dzhis/koiic=; b=TdmKB3xUWwABi5gYQNKjBDn+QIkfyNCfLMKldrUBcWh0xLgeMjLs3Qub+GOKGwMozm FUbJ1XZpC2jhGxFhyyhzN118RA97F6oSOXm3m1/Wk+FMjfUWolHE100s5kNNs+L38530 uOMnspdpGVscA37fmr5QPdeoxhIyThNBJdmwhiF6nQnureuktWkd6Kjmwi65jygf0nHZ rIy2rkDK2Db/9GyNHpy3U5BFUA5hqu2EF0t9o15V7jSS6IE6idX4bXNtQazLjHQ6mKVg 66TdcLQr33MVchRcfI9E3P1LjAwRTNx+NjLiDce4tI2AmTdZIRtd42lzwZYv312KXNeQ C0ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9FE8Tg/ETfLF2znBVGSneSNpDHtD4K+4dzhis/koiic=; b=DMbA67LqtQQWvVzhmWcmj9/qFgYq7BbLmTTdpzfRxpOqHxIkGKnJhyCDF+gKFmJ+RC PvMCKOGmLlyeC+2B9WJABU8FTGqGoiVxzKtLxhozWxMgO+DIYCAEoML96m2I9tVcSySi ri9XK4RuGyT0rg/a46QTQ0oc6x352pg68TQKZjgQQ4cJdgnsz+kvJsQmPbFKM4zZcvu5 lyKVU/UMfcAlQ1mZDnWftnKUdeqz3jKxeuvcCnm6geoMVE6ua82sRL8koXYrQkhHR8jQ yBzxSigrANEicwe4Wes3p8ewcLsFyfNBQp8TEOAveZRfAY3wPFiwtMPFfMCDIwrSaJ9b ddrg== X-Gm-Message-State: AFqh2koWTaF2OuEGwhbnmc8nhsJJcjkgDW5TThcyaZZD+bApeFgS+JQB dPyAxj3OlBMoO5RuB/BoIf39mI+Gb22mnHarYvY= X-Google-Smtp-Source: AMrXdXvnrppwjWc2GYoaSQvqFwNiTQID4l0gmI8rLvQT5AS+GqW5c9yL3gsxiJUvTOWQUcAgkpnAGLzZ827Cy2iv9XQ= X-Received: by 2002:a17:906:3658:b0:872:68a:a17e with SMTP id r24-20020a170906365800b00872068aa17emr7442256ejb.159.1675103729082; Mon, 30 Jan 2023 10:35:29 -0800 (PST) MIME-Version: 1.0 References: <20230130092157.1759539-2-hch@lst.de> <20230130092157.1759539-1-hch@lst.de> <3347557.1675074816@warthog.procyon.org.uk> <20230130103619.GA11874@lst.de> In-Reply-To: <20230130103619.GA11874@lst.de> From: Ilya Dryomov Date: Mon, 30 Jan 2023 19:35:17 +0100 Message-ID: Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper To: Christoph Hellwig Cc: David Howells , Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A7035140016 X-Stat-Signature: itq15uc49xt5ajkruse3ad4gr6y1k31p X-HE-Tag: 1675103730-566239 X-HE-Meta: U2FsdGVkX18OC8bE8SK84u+ILru4IsbhUNy7gdEQMgaNd6w3CsLGsJlE/60PVRhZ68kx+faeiPxoP+IsLC7cmV2W2Rf+hXyvFDMH+koCKuhn0zptT1N1dxhMZUZ8ea5D8rsz58lFpNwe/6C9yV+jHV72NRil7v9h71QXMLsva+Yd8OjngGtMSWNHcDXUL+Zcj/0VZYXmwXJf6J+raB+fcDbfXdf8hZiA9NzvmZpiJTRvWe/50YffOsE4l8BGJ4NkCH6zJ4rMeKjf6A/FsYqSvzqJjQ17h2AZJpWlo6aQ3FtPfjqmp7FfoRakdW4YM6InIN6zdeDznLK690GMnjwzBd7UJ0kWdJKpD3q1qApJ3dWx20papl9ByfsVNaS1pIb8YLH6qDh9dilZUKH8lPi2cQRNzMgLl9QchVidYJ3f1jzds4J5GtcdfS7aWklKRNmpRc7vRe8KM8lkcrrpgVSsNx9e5B7tS3mjdrVWJEBQpCgfVmlRGxR5OkZRE/xFeBjayJLbcV9X9O/42ghsMATfQBgWbut+Mni81RuIctDw9LH/CgaEAt1wMuEBl1rCDNRKJ17ylxfuobpX9tjrAb5yiOvCckKk3DjL3Kb9Hfi6u0PZ/5WMAmKEdbhVFc2jB8cHnNSQwNzSAWNwiyIgGrlh4jDg7FxWZU9VO+H9IqKf0A2esratAr9LH/o45SkATgNBHywVuZi+INR3DCJHKxiYVP31Oo4andX+ZkCCWVEhhuQrX+/ngo3IpgYaJTZKsj8YruOTMNKeBUb7+X0OHDTpVWMRWWN15wGUHzMT6Xu5/RsTaMWf7Qp4n2XsAAAIMkRBDOv/pCYw+w2RXbsFgVT0+aDViTuBZaEssWXrmtdKjM25BvE3XvtqS+cx0N2Kem1VP454lpv7QDcA671l8WGh20siriPw7lG/0yU2C1oD6/CWttK3ybtr5MjGn/ng6aoUuPNfpZZ8mRe8prtrSLX Ypkv1ggJ qZcWD1Wq9Sm2RbOmB5d8Z78SzFfvekmQgLVg/ehZ0Qlu5HZdl0bw4s3QqGqaxQ3ZzZSpBjwEI5KzGx50ddjn8oKatc0dHXaDUkV7Ja3ximmkfs+m+P6N8Nfo/tXEPX2PlMxVHf0C/MStW32X7+gCAUs9QdlClRYMeP8LUDEPu1p/F3V9tWpggjilbbxk7PRRU7nOlxW3DWnLljcVzD9I4S2aSnqE5k/9y2aKAWS0Z5UB2Ji0iMaL+sFZdQSOUUcsZXpObbnxk27OO2ym1QSwsfy1c7bNcDzlT99pP0lbTgicbgrbrgeqKZU0+uTpQD/XZcRlRQr3+OR1imGmr3CkYBoVmg1ch+OvwVixVB+eglgeNpjMkclZGbSNUq9z6s6zCMpvfWRwdoarBd3omhQoi1themZOpZPdKe/28 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 11:36 AM Christoph Hellwig wrote: > > On Mon, Jan 30, 2023 at 10:33:36AM +0000, David Howells wrote: > > Christoph Hellwig wrote: > > > > > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page, > > > + unsigned int len, unsigned int offset) > > > > Could you swap len and offset around? It reads better offset first. You move > > offset into the page and then do something with len bytes. > > This matches bio_add_page and the order inside bio_vec itself. willy > wanted to switch it around for bio_add_folio but Jens didn't like it, > so I'll stick to the current convention in this area as well. This also matches sg_set_page() so sticking to the current convention is definitely a good idea! Thanks, Ilya