From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D9FC54EAA for ; Mon, 30 Jan 2023 17:48:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 356B06B0078; Mon, 30 Jan 2023 12:48:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 307816B007B; Mon, 30 Jan 2023 12:48:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A7036B007D; Mon, 30 Jan 2023 12:48:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0A4F76B0078 for ; Mon, 30 Jan 2023 12:48:00 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BEDC21C62E3 for ; Mon, 30 Jan 2023 17:47:59 +0000 (UTC) X-FDA: 80412198678.14.490A16E Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf09.hostedemail.com (Postfix) with ESMTP id E5D68140003 for ; Mon, 30 Jan 2023 17:47:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CpIi7U8m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675100878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M+UsnDYEEEOfyUbH/lXJAyb1YrNHDU89XvWY7p8gIqU=; b=MycuyZXEAUQ4WYz8IJn8n+zEpr2R9JyOGvfBCrUsLtAr8GcVdEbRtUtV4hiuTOsbNwyMJE URVm8NvSknSJYyAwhdKLRGeXl5QMr+3gwFvI5QRz6Mpz9Bm2DWjigDWBE5+5EFuNLT8bwK BEN68eewHowv3W0avxoCEF0oVbHZcPg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CpIi7U8m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675100878; a=rsa-sha256; cv=none; b=qqHh/hp4PwfrjNJsm9kPdicMmy7eFI3Q42pXVMNDDa7NhiULr+Y/A/R2sgPcZrPO7f6Z0Q nanhnVK4XCNJFrWi/Bb8TtlQflPtckDoiUC5mH213r8iPk4/hmoPu80N1tBW9smeEQ9dH3 sa2gtiGetwcDJqjo9Zl2VP/GszRCljQ= Received: by mail-ej1-f43.google.com with SMTP id p26so22869570ejx.13 for ; Mon, 30 Jan 2023 09:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M+UsnDYEEEOfyUbH/lXJAyb1YrNHDU89XvWY7p8gIqU=; b=CpIi7U8meqUvpwwHiSGd1IdVplT9N/wEXPlMlTsFFXyhK4irJaVCltXVoisRD4OtsJ Rp+GETx2zPi+LRHBbG7TedN9tCa2d44rv6ERS9LZ714bjXED6oA4tXrKaQgaZefoLEBT FmxpGFZB4292Hf7PShZjUN1dUJCt8d/dMntxKh5EE3vQ2/1IMSkKRPUher8dCYs0V1yG b8LfOHrulCQRh/AAOTrO0gUY89a5W9PLGsq/+xfSMRtf5+itz58cVqKOZLq6B2OfqfRh /PZRDDptgKbJtfY7tCnEgNDOmTGJa40XfEUjVp6cWOKwTJy7dVnFZRZFdHwf9raQ0FKA U+XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M+UsnDYEEEOfyUbH/lXJAyb1YrNHDU89XvWY7p8gIqU=; b=P2uDeETjrHCx8y/PrAYFjwWGAIxucfcOd798GoJ4c3Ru72ql4wImrwvDAXGVEMJBGp y7wbWbv7qLchM6wY3oC+5MkLy0AcNzSLBogfa3T0Ewe7eHqUrzOaelBopmlfXuAzlCEk J28b6logsLclJFYWYWGuXfdPTOjeWICyQqNWbOPl6NtxHvgdlvfnYWGQvBtJ2gP8IGPr inqES9EWTS4387fOVjTLK0F7M89W9b7bcfaUNrHgAeQTwrm+Ij5PZOCOjkPS5bVaC8rD mvBoU6tz+JXfRPLE5OWn++1QvDJipCheDvnyB3K06coYUOCohN5NeV4kKedBwXX1qK4N 9FUg== X-Gm-Message-State: AFqh2kqMyaWAsvRSPiBH0jqPc5LMdzFHipzQQBxwdMy4KJRIoCdj1TF7 DRiGxl+/1ZrbkQntc5TH36QGQUwOC/rJ45UsS3g= X-Google-Smtp-Source: AMrXdXuRX3iGxgJVTohVZn9PzXrmwlAnwYJ6yU/LKWcFrxKFgKe4FiyCZtPmYi+BznmfdmjECdu7m6UwdR7AVtAfqLc= X-Received: by 2002:a17:906:3658:b0:872:68a:a17e with SMTP id r24-20020a170906365800b00872068aa17emr7392236ejb.159.1675100876297; Mon, 30 Jan 2023 09:47:56 -0800 (PST) MIME-Version: 1.0 References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-9-hch@lst.de> In-Reply-To: <20230130092157.1759539-9-hch@lst.de> From: Ilya Dryomov Date: Mon, 30 Jan 2023 18:47:44 +0100 Message-ID: Subject: Re: [PATCH 08/23] rbd: use bvec_set_page to initialize the copy up bvec To: Christoph Hellwig Cc: Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E5D68140003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: qrhtbmjemkdgfz1q86dftxqq6mjbg6ms X-HE-Tag: 1675100877-59946 X-HE-Meta: U2FsdGVkX1+Qm3jtoFcAuRtqotACjvFh1cp0MoMRHs9Yx/a1mB5DZw85OMczLNeajxoVBxgl+ou7wo0YjdGAbsZfTgbkflWFQHF3gdSj/XGQkNdkDnLmYg4x1OISe8B72u8BV3vBupunl3YtCQ04faVzXviSwBHvKFBuo3A/iDKLybLcWo0fIE1Qhc0ssWg4kv45ghSy0a2stzBSYnDff8zpttVXfbDoY5awKOKe3HOP6wO1Y22z74Y/2VVZiJX28tFcQChnAv9JOXKAajq0rIshMDFntb/x3KFVZ45IMNdfI+Akw6B8GD3kjqlzEqz/W2OJnZzlgYbfNqRpUPSNknmsCNDuM1m0iHnp4WxlOIr8J9XFP15IgypVkivVnLxkg+sxT+9YQl/FNMGWbuN2otoDBClCbvsSTlGumnGG9mMmcKomPyDUZ+qUR8SY24hf4EWd5gE4E5xGJI6AixB1GVnQQqcziih8SoV8f/wfdK0eE+yFM6prkuSuOw1guvfXU3Om6EXC3f7m+/b6Lw6kNdOOptbY/7qUiFo73Rbk8TzPuriQIfyqspDm2FIY3C8Vhls5q94JWCe437E5YqVyIdf15vbjOw0EdIyIeP4hntYMltyc6FyQUPXtvHr8ewYK6e0YOZ6IT7116q8erqz3gokY9hOSHCNMEpQFkZPhZv2lEj6tMMAZwmojnxo2Le2tGPFq4C1ptdf0VCVcnvdG6R84NkHSq6UZZehvoanXp9iELmAXRMQyJ9O9jMIsdyfh/JQjQvidGxLjvglFTm6p9rXIv4vdt6F8TNCKfO/U+M5nCMwrTlWp4jq4B9ZCfc/U1OtiBkcDPy5XCbBpBfV5tBBJ1MHnfVL3nqoyCZdts09QA+SrnKxGc+yabTuxjKhjmr3hlnEoMuETjpwle0/tLRlRWJ3vXvKzjyXUjfVuwK/NM0p66TcgbyeoSzwYGgckjEbB7ptdjPPgstLv55a T/RSZZVu i3PtD9cjGGU7xoo1oyTRCcDTg1Bg+PEK91H0MglvzHrG/s1bgtNoTdp7MYYBpWxcHm++J/uW9zGqvlzjslSqstV7FrnBa8S2yWbTnGGVSV+vbkcTzEJztdttPAoq1r6+knhGhRpVF0fIglnRm36bJWlurPeLXv7TpDyizFm9rv1IxaFn1ahpDpRu56tcyRA2W06R2UDghdB00df9/RDVsI0BuaB2pfejJEdHgOWN0ENWv3KqNY4+AGwmyN/kUAR3/wSaSyXVPZlyO6oeyoHs30gItCMjrP+VP1Txq3aZvxBGCAn23yKKjknBwmc0EjI0wNcyf2YE1hfFsJpnpfeQrxCwpCyuSXCpLU0MkSZSWBUYJDROXe2KjZmhq3zJzXgJpXMqJMJ19GVpc+yf1dvl8xxTy3YKZQ/39MgQocZ3aMVeaWR2Gwi1Ve4W4hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 10:22 AM Christoph Hellwig wrote: > > Use the bvec_set_page helper to initialize the copy up bvec. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 04453f4a319cb4..1faca7e07a4d52 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -3068,13 +3068,12 @@ static int setup_copyup_bvecs(struct rbd_obj_request *obj_req, u64 obj_overlap) > > for (i = 0; i < obj_req->copyup_bvec_count; i++) { > unsigned int len = min(obj_overlap, (u64)PAGE_SIZE); > + struct page *page = alloc_page(GFP_NOIO); > > - obj_req->copyup_bvecs[i].bv_page = alloc_page(GFP_NOIO); > - if (!obj_req->copyup_bvecs[i].bv_page) > + if (!page) > return -ENOMEM; > > - obj_req->copyup_bvecs[i].bv_offset = 0; > - obj_req->copyup_bvecs[i].bv_len = len; > + bvec_set_page(&obj_req->copyup_bvecs[i], page, len, 0); > obj_overlap -= len; > } > > -- > 2.39.0 > Reviewed-by: Ilya Dryomov Thanks, Ilya