From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A960EB64D7 for ; Mon, 26 Jun 2023 15:52:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B538D0002; Mon, 26 Jun 2023 11:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84A348D0001; Mon, 26 Jun 2023 11:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 712ED8D0002; Mon, 26 Jun 2023 11:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 620618D0001 for ; Mon, 26 Jun 2023 11:52:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2EA92404F1 for ; Mon, 26 Jun 2023 15:52:50 +0000 (UTC) X-FDA: 80945342100.10.A35C8FE Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 03A07140021 for ; Mon, 26 Jun 2023 15:52:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=UvHZ1p09; spf=pass (imf26.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687794768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o89Xl8sumR+a/JQGWKqb/MvKGfCSwc6E741ND5ks+BU=; b=aqvpElBXjith5R+sTHUNaCuviZ56GgPvwOcsxyIrP5eYQjHLiAcxG4crbO1R+/CfsLc+8F tAbo6LxaAmWa8P1ANKsbCCsWi86jYe5uD0lkU/OoJejSPX+nMxRsF8aU8SCliJVfLmabVU TlFmDZiizvxkDoR7G2sSeaSQtbw2iDQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687794768; a=rsa-sha256; cv=none; b=FGLMrP6HAj02CTG6O196MVNPesI0zScPqrLzPYOe3V0jC7Sa9Sh3AiJkUIi0mDr94IVu04 LRxb/+9KpLjmlkdhDL+FareB0fym42DG4zrAqsuQ5Wh1QFaHONDLQCYCyLfDD2H4ERAAR9 +FgD+JcYsOrJ3wuFzzGZyxPZp43sWHI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=UvHZ1p09; spf=pass (imf26.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-988a076a7d3so519279966b.3 for ; Mon, 26 Jun 2023 08:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687794766; x=1690386766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o89Xl8sumR+a/JQGWKqb/MvKGfCSwc6E741ND5ks+BU=; b=UvHZ1p093j9l8Bo4IqKhWyxuMi83Z9LqBZk6+ZbEfd52QkuOS5jCFKgbi5TLH7G87w TMk9esoBHsBIueS7mc+2HystrO5BPvRUmAcFzjXoziOg4eDJXi7ZHkFJRCi6kDWjlpYl buM5YSJpTfmZqgPKFrWVYnm7d4pYLIFEcq5IXSnzlEs8PsNgo8Z5F2OgWBiMHrubucik PrgbDIWro9z9lmKS2nC/wnbJxpA7ABI//Aw78sBdzbp8XRLy4IK0jS+STAkGhVcQCrtj kbbDaGu+sH1ZNYesQIzTBydurRb/ZAvcf+jIvHHLu0lIv8ELog0H/YpGTEu7O9oF9y8c +iEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687794766; x=1690386766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o89Xl8sumR+a/JQGWKqb/MvKGfCSwc6E741ND5ks+BU=; b=FGBT0njY+SJ4ScyN45U2pKmd5sp/HdzrcQJm3IbEpS7XDPr5eKpEG5wqnz3uxfLBK6 k5PkFSDe4FWYDrayWKpyYTO1VkUoPmLFj0vvEIEcBmd1s1kpXU5iJ2sPA992L+XXcjon TXMVPlB2EXvNwX2OEFuM0axO3kwmLRSWE6UVlATFV8C0ROnsMPD2GRYqdpadTG+xtZZG 6X9JySt1qocHCMNeIX2zasnKdXmOfA8kAsVRyTD7NMN/cB0pTDO+zAE7so6ZR5dcJm+5 P5rN1R9k8B3CRnd2kxFTMwxKKNfNf270d3v0jY7NWDxGcl51CeKPFLtcc9RC0M5F0RM2 BL8Q== X-Gm-Message-State: AC+VfDxJbUAAwGS0A9LYqlSwYFMiR5yIO+Y1WH3tNwQYsj0qKCVTSGD+ YhECtueALHkj6aQbJzXJspOgM3+r/jeRthH9g5g= X-Google-Smtp-Source: ACHHUZ7XnDeycUp4pUe7j3Q88b0Gw1/C0bViMqRuArbnTr1VYfSU+hD7wX1I92kAeekeUSg17sTL5jLyYREWZH0nCno= X-Received: by 2002:a17:907:97cf:b0:991:e961:a5f4 with SMTP id js15-20020a17090797cf00b00991e961a5f4mr1282227ejc.20.1687794766223; Mon, 26 Jun 2023 08:52:46 -0700 (PDT) MIME-Version: 1.0 References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> <3070680.1687792331@warthog.procyon.org.uk> In-Reply-To: <3070680.1687792331@warthog.procyon.org.uk> From: Ilya Dryomov Date: Mon, 26 Jun 2023 17:52:34 +0200 Message-ID: Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage To: David Howells Cc: netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 03A07140021 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fhy9y74pqzw5fzk6yh6oae5zsfjskfgj X-HE-Tag: 1687794767-728521 X-HE-Meta: U2FsdGVkX1+TgoeQKCKQ+PuV7cgm7emekZqBKn0NGrUeUdl+AhR69GbI0HodjfaawC045e/IS5y0MwgSdlgqnEi1Kz1qHqrUvfBr6XGy5KJrMiNYy+t4v+h4cepuqMF+voXdqDvn+tDCPJg82qSJ8f9oSaKHrn9aOrE53OR6k7arAvq7JXCQal3GkTOLowUbMWqUtrBY+rI9m/XDf7BCsA7uiy1QOKjPXXJJfFRdjUPmIaT+Vki8HinuSZJcYzURbx+7zcJhPYaJ+ZJwsENYd+RpWWacfIDeZjxVMBXKP2qTsj+RPSZqR68QPHx3Jbn+JLZn/E9TpqhNLSa+5fALHSRcy3gw5qSljqT5Zn9oPSbDbHO4MNzSl0vc2FoN6fyPvr9np6kCrNH5FUOAxwPuylT5Ydu5zzWmP54tZ3OsQD+4D0P39GjLu7WO5/QXDN/ddbkaRgotjmDqSNVV9+syWxpb7SDZCLvm/vFlmnFx6RL4nHvTmyf208+A5TEW2hpH9/F6OdP11mC+ANoY6zybI6rocFCRmR+pqnGZukKJLbJN21fdipH5vopYLIpnuy8QmbLz5k5J9XqPQvHjnP/4ZFYW/n0jkFVwND4pL101tjc7zo/WMfYdkUj74HWklwLJq0Ex9upoDPQAlRP0lIUtfoL842ZRADm+WfXRREGbmEuoCQXHJIMKu+nOOIO1zVuKlimnud3ITXFJl5oGNHux9/uO9Kt3Qct5iLquNCdA5mkaHDBIhV6lR+82SfcUUwyBrgJrUilTrDVhD2XPjsxv4p6OLCyT6253LLNv34QSNaEKKz/FKUgYAOxamkHyyd+Jqadt8aRHYYPAxd/9PErjEE4pLb0PpHauh1isTGcqv5jd+zLV4c3KhWxWX/OiIWGewRfvVrRCuIFFiRJ7jNrxHfpHxBqw2s9747rdCpI6DdGyrJEsiEDwAf5xxLIqez0i8OFvlOQ9SQzd0MGkYWy RgLYuDmu GwGOmSDGA8ufaM+hYmrrnhbk9f3+TzHbF4lFG5EcwIITJpAGPtzNFONVsBweVvbMPRTfOhsYmQk4IUrkQ36hTY4nkvKJ5P+WsNphQkmnp1MrYBLfZqWIIzL3n8oznTn67X/uufcYJgZvuNNAarp7cntsPZc6LhAkoOVEK1shzXm6SH+Mg97zPJIT/jlq5Y7N0qFbhjMjs7LP1zg2KSSbhaUhUqNR5K4NNC9qwuVqUvL2avFlqF3VHNDB5jwMP2J9zhlyEoQD1Ojzn5Cj3lorSPPepOK7zUPuvPn9r4m13oCSseGCp4CFCtrDkC44V76vIY17KWREeeja++WEh9z9HA7AGaqGoEAM5zfCV11TIqC1Dq1ewo33aBk93nL0Pqz5/1R7UPJ0xjsq7ItBpqgv2VUQY7+ok8l+Lq2Q+iH3p/r0yhlyav0gGMhpufdduoCSUBiTJdVsV6LCnksNYRKuB1R/I4mC+AifXuxNMvfZBFyFqxbf6LMDJvDWmnGhvSpBQgzp8W5BLNktijFk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 5:12=E2=80=AFPM David Howells = wrote: > > Ilya Dryomov wrote: > > > > - int flags =3D MSG_DONTWAIT | MSG_NOSIGNAL | more; > > Btw, why are you setting MSG_DONTWAIT? If you're in the middle of > transmitting a message on a TCP socket, surely you can't just switch to > transmitting a different message on the same socket without doing some so= rt of > reframing? We don't want to hog kworker threads. You are correct that we can't switch to transmitting a different message on the same socket but Ceph is massively parallel and there can be dozens or even hundreds of other sockets to work on. Thanks, Ilya