From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B9AEB64DC for ; Mon, 26 Jun 2023 15:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D68B8D0002; Mon, 26 Jun 2023 11:41:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 060428D0001; Mon, 26 Jun 2023 11:41:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E42A48D0002; Mon, 26 Jun 2023 11:41:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D68008D0001 for ; Mon, 26 Jun 2023 11:41:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5E02EA05F1 for ; Mon, 26 Jun 2023 15:41:19 +0000 (UTC) X-FDA: 80945313078.28.2B706EF Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 5BC984001F for ; Mon, 26 Jun 2023 15:41:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZC4tdxEL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of idryomov@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687794077; a=rsa-sha256; cv=none; b=3EFL85fC0ylkCUW0aFmqYGmS0qPF3+GENDlDFtf7We+nKkZ4JOp68NvOUCkxY6lOwcDHcR 2q5E/nfp5COOB9x/mMqS/m5PTBlYfA+KSdsyOBOnF4r2Y0z/KLPxkaDqZelwO1qMPkK7J6 UkimO82Z9l0Al49N0HnGn7UG+1yZWys= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZC4tdxEL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of idryomov@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687794077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pfYjtj1R9OBqs+dVmgnQu3/n0GQzqWIXlWSAYyCQgfE=; b=jYw2bnkfMmM3jz1rc/yoQddGBBnA7A/3DTbqv8ga8jiaSVQ3xpFvbkynRoCLokGXtiDTWO TKTA01Cl8h1sh0fHifgiKqzxfMlSkOsiwiyyOrunksgQMy+CoEtbfVyW/g0lSRRakVRGgz jOr3FBqz+vLpS5egrmHD3zePIWQGITM= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b6a152a933so17932811fa.1 for ; Mon, 26 Jun 2023 08:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687794075; x=1690386075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pfYjtj1R9OBqs+dVmgnQu3/n0GQzqWIXlWSAYyCQgfE=; b=ZC4tdxELBaEzsmkyrCDXSO4zrWdOHRW66r1aH4EZlhpnkAAIXHH6JHFNZgMHV97kLH WOuPG/Z/LMu4Jx40e2mXYXuNlsp8pGN7Mr9cjtCijXBsWURhkgTn1yMVbUCXv+mAsvTj EDc3zwgKi0AfwDX8md+tia3QCxgpDyVEQ39x/fixcn/aqfps8qdjVfFPbBy7fpqpx87m tFfrzz+Gomg3ypUedSrjtmiK3UCI5V2/KEs+Udwqmgj9lHEV33Qbs5PxXO5iP3ETt8vn 4ns2G4yK0bQpMAkRLSgB/LKumhHwl80LtXN9zFUf3Nxj5ZY3O+Bp5C1NWf1RYm7HaWVr 6KTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687794075; x=1690386075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pfYjtj1R9OBqs+dVmgnQu3/n0GQzqWIXlWSAYyCQgfE=; b=U3mkRgO8Hqyrh6I6XgADs7batPIu+zknEzucN361nAxU2Zsg7zdnPbQF05sZ6wxSUx E0trtmgRGfr2By6GfLVkOgrQrld+bNOXaLB4H1D3fMFtQ0T9CDEOAwXxd65fcXloi7Ub p52JitNKpP/kTWJ73ik8U2J+bL60mSJvbQYCwnebR/YiagWv17wqdG2dQwY7wQpfvNnF +mJgPJrgMYuf0Q4QoOYMCpJJXQ6yY2dBo0ealJuxSWdaZBCNnXI+Qqi8LVW3IeIngj9A QoHRBl1CG1NUsNp+JuXzIbeZ0EDExX+4AOqM81BDDyvNL7pWfVRuICCmw/CzLvH+ygL9 5WIw== X-Gm-Message-State: AC+VfDzCff3kyYxxo8KIJsOmisuaBjecYZlxaWjjsxLUGqrW0fv4qlZC hr0FcqIsgKIXmVl8gt8VqkdzZwo42PZW74ChUEg= X-Google-Smtp-Source: ACHHUZ7VE+8iZfotd1r+SiAoEv3NvBloeBmppqXFsMvjW04FYaybsoeMhBTGyEWcgQXFE0Lrufy5XWjXJ5HBl9IL5ik= X-Received: by 2002:a05:651c:207:b0:2b4:7d01:f174 with SMTP id y7-20020a05651c020700b002b47d01f174mr15122288ljn.13.1687794075146; Mon, 26 Jun 2023 08:41:15 -0700 (PDT) MIME-Version: 1.0 References: <20230623225513.2732256-1-dhowells@redhat.com> <20230623225513.2732256-4-dhowells@redhat.com> <3068221.1687788027@warthog.procyon.org.uk> In-Reply-To: <3068221.1687788027@warthog.procyon.org.uk> From: Ilya Dryomov Date: Mon, 26 Jun 2023 17:41:03 +0200 Message-ID: Subject: Re: [PATCH net-next v5 03/16] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage To: David Howells Cc: netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5BC984001F X-Stat-Signature: 6bngfxof93n34gfe544qc6axduwoo4hh X-HE-Tag: 1687794077-621248 X-HE-Meta: U2FsdGVkX1/2BaSiXBsgmsx2RqsnDYc0JdkSk3DD8M9/PqvJEsEBdMn/7vL4EZdALODLKkTBzCwjdu3PRAaorwfftODEc7sTu00hFLGnEWd+8tEW7Q6lmnun6gdCl7HoEteM+5QRCqvwqrdPP8ah+z7NUHMFDNYv8eZKYsGihDQIumDsfErYGOWAdsBlWHp3JTlABw7+XDx7bNsfEYq60MXzEneNGMSUCQe2RKOlNrMiYMTED5FZc/D7HLIQo6zdc+HPeSpF9IgIo564QmXMrP5HLO9mwgpVoi9l6OjECrf26aWwYEPOiCB8Yfxo0g+pxQUbLOwj3ukU+8J/HMsGxOYnMWMT6N+WMry9QmFenMXGg7MgZmQx51e16aXbEyFPSPIaJB+0CTqQEJtWnHqb2MFNmdL5hV2/KJ2KBV5yL/DMGPGsUJyXJPX6+aK9IZ45M+gZwTxWjKYhoWSUx0CXYgc7rDxMjh8i+vi+4T7Vnvo0l9X8efE2rh+kQSudakyhrv3CKs531IV0ZDqFMIOHg22E+zL64yTwIEVc73JqnmTKIb51+7JE6zSETo7gUEdAbGAk+xjrwsfYA6Xo7UvEmcQaLl4CuSxTkpzFkRduH2GkQTTbTmOmAtK4TmpGXg7WdWKfZlIKqiHsQfJIpQJDJYmpiJ4Dv2sKRE/RW+UnKdmAr939zgt/7CoT8HyDc3qW4uUd8d1FnRzOQi9R+58i6ogSwRo4zqGmzx8cfMJwdT0ri7FsX6UhP0hKH/Z6ngTVwAN0j2OceZJu26geKWMxPvFI0iR+nKDXvYtV7d9dZL3OWpTzHtwmnVPAcN/yg4mbYmnK3yO0wlc7j1MIepwXLzvWmSW0YOndt0lVPDR3OX8cdaKF94CSDdgMF3RuQjzGn7AMH0tf5+7oN8+56MHYP/iONuRzITCd94gwNIKknOBOfJz+wG/PJeTMotjKdtIvYMbuAAFexSkaOBFnZJ8 byjTGOYx rQIDqg3N9oXCXigqkWC1zDH3YLUfzVB4LHXV17bv8sM1MesEweuXbqdYFDYpd+TOZY5WACPTNW9/4PxXNL6m6GmwnlLzZRlwnfd0MZ/94w51tWF8qOc0V3GLGCqHZQ50664D0c2d6jtvTF1J96Wng78JZpXiSJTtPzq3KftEx401EKygqRJeMe+pZwRdoGppLPJO65QbOFIOMNIOLrZoyt74HwCevjy+M+4wdiq+pZiCGZmnHdQtkqpkuFlRrCqtDK1Vi/kVA6hO5Ualbd7oQ19gIZu+mOhWHuqZ30OcaFhtIG+4xnoxy+Bv9MNi+9p8Y3nJvmxLXYpT1jr575LDIbtSK15Fsk18dDzNA9F/T+LUDuGCBYSpkp2DZ1QCsBTcygko+HhttHeZd9xFZ5UBRD4JlXVq+w+XvJCuXvod466pniYGBAhl9+DhnJSmqqRc1CDEB4Zwa9d8HUxci8FnTAJ4jDM/d6IZMG8bwNT1tWCj7HZE/kqE7bRKJItcolkCZUa2lyVkjXEzT7AM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 4:00=E2=80=AFPM David Howells = wrote: > > Ilya Dryomov wrote: > > > Same here... I would suggest that you keep ceph_tcp_sendpage() functio= n > > and make only minimal modifications to avoid regressions. > > This is now committed to net-next. This needs to be dropped from linux-next because both this and especially the other (net/ceph/messenger_v2.c) patch introduce regressions. > I can bring ceph_tcp_sendpage() back into > existence or fix it in place for now if you have a preference. I already mentioned that I would prefer if ceph_tcp_sendpage() was brought back into existence. > > Note that I'm working on patches to rework the libceph transmission path = so > that it isn't dealing with transmitting a single page at a time, but it's= not > ready yet. That is a worthwhile improvement now that sock_sendmsg() can take advantage of multiple pages! It would be pretty invasive though so I think ceph_tcp_sendpage() is better to remain in place until then. Thanks, Ilya