From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD2BC64EC6 for ; Fri, 3 Feb 2023 17:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 581EE6B0074; Fri, 3 Feb 2023 12:14:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5328C6B0078; Fri, 3 Feb 2023 12:14:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA616B007B; Fri, 3 Feb 2023 12:14:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30FFA6B0074 for ; Fri, 3 Feb 2023 12:14:39 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 821F4A02C3 for ; Fri, 3 Feb 2023 17:14:37 +0000 (UTC) X-FDA: 80426629794.28.C109FD4 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf24.hostedemail.com (Postfix) with ESMTP id C1FD4180008 for ; Fri, 3 Feb 2023 17:14:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fb0zwCwC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675444474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=piXirJB1ocWVRzhs3blzzKk9+m92CHpoGy9Z2k+SCeM=; b=bfMormnwJDoK32pzAjmmdMosehlH8PfdltYnTyEoM6dT5/y6Ao6Y3umnOOxXC6nI3jAmWZ TxNs5hCsvtGRBqZXW+dge32FneSuIbz7Pbex89AEHHlgmdYQeintp/5GCDq0UPSvsB0rqj nMqPc7C1SCORubefLqMyhYIoOh3hJdg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fb0zwCwC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of idryomov@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=idryomov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675444474; a=rsa-sha256; cv=none; b=Gneh0w2Wevvm4S6aW9qQGmpK0+qGAq9ho/Mo41CroTN4rUVaKnOLJZZsEVLybIqZ0hLEKL 598NNQMVXst4vLs2pb6ayB9euNgpmmwRlArvUscWFVFbNAn1xY+3Ulf707km1Kp4aigQu+ /sTKTo9bgf5kHnThbEITa472wuvULJQ= Received: by mail-ej1-f41.google.com with SMTP id qw12so17242803ejc.2 for ; Fri, 03 Feb 2023 09:14:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=piXirJB1ocWVRzhs3blzzKk9+m92CHpoGy9Z2k+SCeM=; b=Fb0zwCwCJOeiTQEIlhQwff7G7k9ElObO1R+33i0wPXCrqwIBrpEt840BslhPeWvhej RNm1AhkBApvOqVaG8WlS647E04HIjv8QXHbrx4efowZpI0TaabZ8LMgSoh/aq8KjxxRH ymR8pWmWjw/LsMUWJ9rofMDzzzyZxS3bG6pr5yuXBaSNOMLnBMDA9JK7UsqZLm4fTbdz 3JONOsnKCVpep3uis1ESPNXO4PXE5PboF2NqB2yAqmji5Wmfqm6IMWogBRXHCGUo+evy 5FIXmxmK0Q+tgY6yH5xQu0jB1ogx5Xoz2NijnyXZiUzSOhVkO+fo8Fi/9WHvdy2fnh/f yg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=piXirJB1ocWVRzhs3blzzKk9+m92CHpoGy9Z2k+SCeM=; b=p5PCGiygKU+OM7a1BNCla1uSAacKFjjvM9QdYhFv1tXP8InRNfhPL8CNQbtox5liLh Wf34Hd+s3DeL5liQHf/hBFoXCg838cTnMaDpJIt1BpQVgp2vTZxzZuige6oHi40CNmHT a3J8cCwb7E5Oj1W2PgVfzC9mIt9i6qLgo3hbI9UFZ5BmdgMq5eEvZXLVvOp4BblSmDqH rGc5kGjhuPlhCI5nF7UeJpINhN+tUQYdvJxBHc5yJBV/SNZ9XP3jq/QQoD/GW17J+rkX 80V6cqrEgjcCc0uYWd3xd8Mau8+H4oTMlP0taGA4kPyqsHYGaWYbO+4WKYtfkuo9ZN2B ckeA== X-Gm-Message-State: AO0yUKUxaQHvtMwyKdb6nGfwFJfolrHGv7uORCOfHO7U0YbuNXhMXG6o QXIQmwmSXzRYe4FyssaTH1i6M9/32ln4ZEq6OZ4= X-Google-Smtp-Source: AK7set/+j+io9+OTuTc3zxO0OENdkhbzE8/JIAWcegXUIkecBeeVYLPG3d1104QBp1VROkgVOtVScA3k2o3zdZ2WZFo= X-Received: by 2002:a17:907:9917:b0:878:5f93:e797 with SMTP id ka23-20020a170907991700b008785f93e797mr2680768ejc.4.1675444473257; Fri, 03 Feb 2023 09:14:33 -0800 (PST) MIME-Version: 1.0 References: <20230203150634.3199647-1-hch@lst.de> <20230203150634.3199647-13-hch@lst.de> In-Reply-To: <20230203150634.3199647-13-hch@lst.de> From: Ilya Dryomov Date: Fri, 3 Feb 2023 18:14:21 +0100 Message-ID: Subject: Re: [PATCH 12/23] ceph: use bvec_set_page to initialize a bvec To: Christoph Hellwig Cc: Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C1FD4180008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9ojtindgyb9wqd6kzdethttgie589rxd X-HE-Tag: 1675444474-731886 X-HE-Meta: U2FsdGVkX1+rsaQ+tFMMupOjYr+WJQj4N/7IHszSDj4TyqExzXrwYZTcJ5fjw8mEz/q3wJyR4+PP5m26o4HU++HqXeoEsZYGCiTrTtfJc5KlZfd5W4gZvpfyxUSvOU4qzfZO749fnGztKXk8MlOD25P/1Ey/9YE8eZ3fCqW6T6wqmB3nwgAJKvOWGCn1TozqK54Af0ex7rDMXAFc1ypMziNJhd7qZKElXmaBE1PrXNeXC8nDAQDKcoM12/ntVwWSzLl/QVp5FU4wKhW/Ua4cAL+mgyfPVyE6ZNksBagLDxUwCgyvYVQlnDOpvqtJz69JqXQQXlcQSZlevoQZP6dGrDoPeqUvioW3ocfHWM0ZSj7By4Iz+VkJ5agUElcgorjtRzmXrDb9nLKXP5rrpU/C0BVk6RLzKQcv014vATnkYvmMV9UahyLTCqc+XakH3itrNVZsRTi3s3QK/BLe5L7ZjYlJVXEXex+UNVNbQAdfBO6XR+t8J5HnWw8GsX4iMGYQJLg9WNByZTmKU5LqC5ypX+/WJdjBiB2Dv6dXKbNNUP7Lkr2GXvsXcVzOL5+QzONuGtjAFVfs73C1tOasMi64uDgTuRVo2NlseMLkm9IGy9P455XVhugySTjfdG/JYZAequxIR8rAzS6BZUyT9UQZlnxMcYEf9q5/2MO55CWVz4FLctQ7/CPdJd4tp9L6gFlrstbzEipI7H/ILvDPPu1EVmM7DguKRy6z/keyWAbahwrMXaajDeoNBcUppHlF9/U2TiVTt6sP2nBQtHr1SYejf2lwoPQSOM20eql8AIAmnXSH3bfYbJy4pPrgHGUZ7iAJ2bZCCe9vLyK6GOB0Rhntb7eWnvizh78naxJ23KXkCJsYE6/elsf5VVqvXFs450zdZ0eV6PcoXgjA3Sm5lbc4MKRedUfFE7W17RatKWYjggL0yBCNK4LRQCpumlygGwLO1H36FWb1P9zuj9n+95D CWNKaMB/ KcWdv32qwEf0gIXcLyqgTs1Umj1c6FbZx2Hr7dq4mueH51HoHVSu/SJxZON5juHATz8bYB7BmsnGeFKNnGCeh2u5+CDEXHQvYIBelKeVp/JJjkA2A0u5GBOms3l/1iClNWttZcfNNkVnOCFZOLnlvjNO0jj7lmeTs32LVo+CKoAcGRLmq/aAwA3RrDGRd7VMPXRUOEkkaAIutJlB4DjF5QyWlqZFxkXwR8+H/m/cHXreMRW5U7j8H8gKIjMdntvKOYu9HjP0xHjJeOBT3GXNgaRdnFRY1xCmQfmveKw5WVUB8jvseEq6hnwo/BdWOBrEXNAKgmnFHSxc79Ir3bZTl4QLtxvkZaTsguAfi5tkEqZXZX4xVjHeh+q5Pq7if1kxIWNba2QXjcYSQ1ouZ3R/R2oThPhaeBWREdH6qzMEWGLqJZSQVTLEO6idAeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 3, 2023 at 4:07 PM Christoph Hellwig wrote: > > Use the bvec_set_page helper to initialize a bvec. > > Signed-off-by: Christoph Hellwig > --- > fs/ceph/file.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index 764598e1efd91f..90b2aa7963bf29 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -103,14 +103,10 @@ static ssize_t __iter_get_bvecs(struct iov_iter *iter, size_t maxsize, > size += bytes; > > for ( ; bytes; idx++, bvec_idx++) { > - struct bio_vec bv = { > - .bv_page = pages[idx], > - .bv_len = min_t(int, bytes, PAGE_SIZE - start), > - .bv_offset = start, > - }; > - > - bvecs[bvec_idx] = bv; > - bytes -= bv.bv_len; > + int len = min_t(int, bytes, PAGE_SIZE - start); > + > + bvec_set_page(&bvecs[bvec_idx], pages[idx], len, start); > + bytes -= len; > start = 0; > } > } > -- > 2.39.0 > Reviewed-by: Ilya Dryomov Thanks, Ilya