From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 778C1C25B6C for ; Tue, 24 Oct 2023 12:04:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB30F6B0249; Tue, 24 Oct 2023 08:04:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D626B6B024A; Tue, 24 Oct 2023 08:04:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03B16B024B; Tue, 24 Oct 2023 08:04:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE5C26B0249 for ; Tue, 24 Oct 2023 08:04:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 77557A0648 for ; Tue, 24 Oct 2023 12:04:20 +0000 (UTC) X-FDA: 81380222280.09.BC6244D Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by imf15.hostedemail.com (Postfix) with ESMTP id 78E7CA0007 for ; Tue, 24 Oct 2023 12:04:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=awnb03Ig; spf=pass (imf15.hostedemail.com: domain of idryomov@gmail.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698149058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OdqDVowVm4vnNj3OSVQUt5P0tkzU8HQzVTEFsc76Es8=; b=DnkIu2A0pYQRk8mcrUYpvlSG+c2UYHHXkX3sS6IUKX1E13JQOITc27s5jBM5Vm+Mq9LxpS Y0dMQ21Wp8juz5oys5hm3ci90zzSLIuiZqX/Do+SHNnLttSBiCvaYOX/e2dAo+zy9x7dxX U8y18FWnBXoRuHJQk2Ui+hXrlmEfrsQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=awnb03Ig; spf=pass (imf15.hostedemail.com: domain of idryomov@gmail.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=idryomov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698149058; a=rsa-sha256; cv=none; b=xMU3vKSRVUzEcFoQ8wGPKVcqjAZKA55+rUueEnDuez7/Rsr0yfJ2jYwKMY3GVrg6E4lViB F5gS9hlVYBXPCcm1GvbiY9Vdg42QElb3AzKhel7i80zwgBZRL0SIPOUWN9iIKHj5KYjmkR S4l0UcD38/1YV4+R/iqKtz4RGPG/XEg= Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6ce2eaf7c2bso2903928a34.0 for ; Tue, 24 Oct 2023 05:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698149057; x=1698753857; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OdqDVowVm4vnNj3OSVQUt5P0tkzU8HQzVTEFsc76Es8=; b=awnb03IggWE/g7tig2rOqJCby49Ah4qaF3ju64tvlbZAHvBcohLwA7gzCq3IuubqaY 1sX2nTI3D/kj66kLRFfrffN3w+aODoPkGk7YSNYSktJqgqll9n6WnWiaOfrswSfAGtVP 00aKCRL1yzjZdNbpHYTzTsIdkNrTDVJh585DutxiEornzerdOFOXaWL7ZGlwqflLoMhu MdpptIxEmL9QVFcgqMPPerbw4alkJCWgHMiXYMcU30m92jlBxDVi8/60icuPfuYEEAiv SyllYNEZXpMqGI7ctF6bQl+b6Oz76vPXYS4P7xEiO7VPMTIU2PsFWvJKkbzHWHXpuhlV KqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698149057; x=1698753857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OdqDVowVm4vnNj3OSVQUt5P0tkzU8HQzVTEFsc76Es8=; b=OyXlLUj4olGkPCs1ZKr7TLZdSQtRZKcn0HK0Qu+xl8A8Fe+4DFyC5aqjoxpoPEDTcl X4txrvXzmsXPDnJf4XOJOCisoIhrlosx/0rtl18uCQgU0o3DpRM1Ao59N7PCH6qHBkwX NFMuH6+mNOusdFI8hBX3pDgoIRygdKCjy18Ss3GqbTNtqs1n1aKse5o8sfP40tEIlrYf nM/XJ7se31GL/5WEtpdEiUjENukefeF/5+AQxCC1D7zB4nGIsE3jGhBrbkwtUk4/2c+X YhvrVTC9ZLDo9YhCgIi7S2TfwHP7JHJ5i+GyarZdCiUdr5j+xrxCbdGOVW7jbZvqXLgn 8TJw== X-Gm-Message-State: AOJu0YznnPrD+Z4aaJs9Z32pEEEHxm1JJhfrpB646O5qPbyUPgttatgY 5S0Uc/L1uG6khzd6wVYOVh7suRYqIMc5zEfg2HI= X-Google-Smtp-Source: AGHT+IFXPmDa5xX/+B+xeenmgIN8wGat9sOFdAubKbu6QP2OEmcmhRBnTYWwZZzddG7MkH4oJNzU+ZRiDM3f8udM0Po= X-Received: by 2002:a05:6808:2189:b0:3a4:225d:8135 with SMTP id be9-20020a056808218900b003a4225d8135mr15175785oib.31.1698149057531; Tue, 24 Oct 2023 05:04:17 -0700 (PDT) MIME-Version: 1.0 References: <20231024064416.897956-1-hch@lst.de> <20231024064416.897956-3-hch@lst.de> In-Reply-To: <20231024064416.897956-3-hch@lst.de> From: Ilya Dryomov Date: Tue, 24 Oct 2023 14:04:05 +0200 Message-ID: Subject: Re: [PATCH 2/3] block: update the stable_writes flag in bdev_add To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 78E7CA0007 X-Rspam-User: X-Stat-Signature: xb37tbtaxnjcnwq75oga8c8ije9eqzur X-Rspamd-Server: rspam01 X-HE-Tag: 1698149058-616108 X-HE-Meta: U2FsdGVkX18vQN9iwI+zxeXflnMqZptEdzL7xAO5s60+BNhtkmFhZoImQ1ZP4B40haki+h9hGvpBnSwrecONij69oIN/gxbNNEzG/NriBsxqbIkNGCGsnzNKyLSpKLV7hI5NWwli2A3KSH3BF0F/gwnPOa8pl/uAo6ICfbR7kuiV942gakwkwCBy0RkREZ6yDxoC1omzP880vozjQ1VIPNUczg21GcGCkL+50cVCWEYkqwndWc7rk/tuoDseB1G30kEemAv6nqyglkDsAn3r/e0je17wimgPVfCZGfOU758dbTMz7qPVituWfrmkzv4WKsx/oQB9ik83w8oJTNfxteqTQm0pHohwPD8IMk07N8eE55CxUqKz1UVx/dl7o7yJ06Eb6pkmJMN4raX8ASDVRf+/07MqItG5A0lgtXaftbBnnX+fc7mNAiwgUID7aczeavUP1g8I6NWaZPcSps6T7/Rdx8NEVRhaI+FThPr4RUNKcdJBZhif1/8dPw530peA9bQ3CJJBQ02W0S25p05sintnoIdd4aZhsRosqD+5Pu0Mdmb4AUkAwWUGfrBESdTfHHnQqAGLGzBeRsdYo5Zpa/fIdq005vVx98kiK51FXzhOmtJlH6Z8ye0Z10GsCe4YVlLUYeD2EtpxtnPRkzOnVfXaW47HVVf3L9gqHZwJXmveXa4S/8wh6thkEpXhh1rR7cFL2TI6TtQnFOKw6Uoy8MaZvYAaSMhFLHSfMFRo7uChYpHhFz/vbbHrsYwQNod/yqmSFhUGqQDthNWcqxfP6eql1VZm09N7nX4D+bYy/IRNymP4gSK+XA/hjHC2mNCMkRKgEd7iNkLRFLSK3j1/lpdSf1PapDtBKVtN6ist0f6mCKmtAlxuJF/xOUrHKWWCXqEBp/OM9DbFYKZm1B41PX7aBaQJFZw6EqyGW+QqcBaGwvsvaWGe4Bzfc2B8m+Uyw7SemyGRNQAnzphbEgI mgcaEtQ1 ya2Cwl7/bh70Pn6xfI6kW36j8Z6HMXYHO1etzpRzLCI9jsb1KzpTkLJ7sSr/j/QwYdy//bOq6ha9MlcLQgMZvNf7WuWjADLzPC0hfUxUIP9u4pdCoLTV/obDDk9oyPAl1HYtUKJF8WKPqgr7PBW2SL/O4wR8SAn0Q8LTSNBLS07ljqBQJbQNlC5v5w0LqpYsmX3QZF1kyibhxVzPwOHKpeB6UiQUdspTmB9K78XyvNZKpmKY7n9hG134p4M2LXBO/H1Rltn97KkZhRy1oqlUJWHcxzCPDLac19RBnqR1fIt92/imdctXf/y3Iohzr1eagQgfdYboiU3s6fFP0QB5Ar0HHoqAOMAWgaFuRlqennoX0fMAlk5PFWUSC18YbfxjGqcS5dKWVrDzhge25Pq3ZEpAplmzfvjJ7SRE2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 8:44=E2=80=AFAM Christoph Hellwig wrot= e: > > Propagate the per-queue stable_write flags into each bdev inode in bdev_a= dd. > This makes sure devices that require stable writes have it set for I/O > on the block device node as well. > > Note that this doesn't cover the case of a flag changing on a live device > yet. We should handle that as well, but I plan to cover it as part of a > more general rework of how changing runtime paramters on block devices > works. > > Fixes: 1cb039f3dc16 ("bdi: replace BDI_CAP_STABLE_WRITES with a queue and= a sb flag") > Reported-by: Ilya Dryomov > Signed-off-by: Christoph Hellwig > --- > block/bdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/bdev.c b/block/bdev.c > index f3b13aa1b7d428..04dba25b0019eb 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -425,6 +425,8 @@ void bdev_set_nr_sectors(struct block_device *bdev, s= ector_t sectors) > > void bdev_add(struct block_device *bdev, dev_t dev) > { > + if (bdev_stable_writes(bdev)) > + mapping_set_stable_writes(bdev->bd_inode->i_mapping); > bdev->bd_dev =3D dev; > bdev->bd_inode->i_rdev =3D dev; > bdev->bd_inode->i_ino =3D dev; > -- > 2.39.2 > Tested with RBD which behaves like a DIF/DIX device (i.e. requires stable pages): Tested-by: Ilya Dryomov Thanks, Ilya