From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9AEC3A59F for ; Fri, 30 Aug 2019 01:24:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7687920828 for ; Fri, 30 Aug 2019 01:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=omnibond-com.20150623.gappssmtp.com header.i=@omnibond-com.20150623.gappssmtp.com header.b="rsF3TnYv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7687920828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=omnibond.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 071446B0008; Thu, 29 Aug 2019 21:24:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0229B6B000C; Thu, 29 Aug 2019 21:24:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2BD46B000D; Thu, 29 Aug 2019 21:24:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id BFF356B0008 for ; Thu, 29 Aug 2019 21:24:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3E725180AD7C1 for ; Fri, 30 Aug 2019 01:24:51 +0000 (UTC) X-FDA: 75877349982.19.chess98_2a52491227432 X-HE-Tag: chess98_2a52491227432 X-Filterd-Recvd-Size: 7373 Received: from mail-yw1-f68.google.com (mail-yw1-f68.google.com [209.85.161.68]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Aug 2019 01:24:50 +0000 (UTC) Received: by mail-yw1-f68.google.com with SMTP id m11so1848156ywh.3 for ; Thu, 29 Aug 2019 18:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4TfZVE6zvYYuoOuB/Rxqa+Mlm3vtxZPY12krCFPSTtI=; b=rsF3TnYvnJjkhMrqd8jgi2b1fWfnS720m/snkWNYBAl3jogwp2mEsqA8h0meBBMFCG mupgLKrOXopsTT3mx+lDcAZLHUPbfCw/vXrZaEIvlfIiq4H0dj/IKCul0NWP4fpGLsu4 48Lini1zfDu9D/EL0CeWiI8kZAXrgg08x+hcJWXhpsmSN701z4+zSsQ5V2A/N+PZ/ko+ cAveXQxi5GTfOnxm/M0L2QMcpa0QpEp0UoezlsX6vklrx1noOLsykTvVpPGdg1yASetm NGCTD4uF7gFM2G4DP0Fj0jWpPyOxMpJF0KkXFU1tGtaTorkpzYDBwzJA49OyfPjy95xt U/rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4TfZVE6zvYYuoOuB/Rxqa+Mlm3vtxZPY12krCFPSTtI=; b=cn8/gnj7lZsN/BqnhBD9q8K3PwEzIsz3hCcTaUoFCwoaRKOs3Coa4+oJmpL/DwNj3w grV9YKK44jeApSQuaD/Zp0hbys0GFyyyvaJwyri5u6qwsnYVmtPoVAsy6MQzlHpmHc4L xVWbHqCW6RPoDoW5SaLTI9YfqQITRaORCWT2Ot5UmFptIhUyZkmVvIK5IyMvtl5PMkrl aBxhR/64sv9oDPtoxe6GQYSQAH6tIQNOdomLsWci9AJpTRkvMg4aulzbcImT4lq4x+6O v62zg+NhtAE1ijgV6RvZHElAEx+j8nIkR+ut65DKeKC3vyKjMXUSgAovaZzjpM/KLBc3 Rbgw== X-Gm-Message-State: APjAAAWlP0vQycaoVbm/6PZ77BbyDZErTQ9oi0oXdckpKNUerF+e978p Upozw2Z8iNnfonGJRKXLFMhRtYKNqvqrerF20a5rmw== X-Google-Smtp-Source: APXvYqwS/gBw6GYqWJhwCNBmHR6+W2ONQRTVjMY8ZXLyRIgVZbf1blJaiiDec2a/U/ArNO35ME5xZuocZ9cXu0GpPKQ= X-Received: by 2002:a0d:d596:: with SMTP id x144mr9018446ywd.69.1567128290041; Thu, 29 Aug 2019 18:24:50 -0700 (PDT) MIME-Version: 1.0 References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> In-Reply-To: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> From: Mike Marshall Date: Thu, 29 Aug 2019 21:24:38 -0400 Message-ID: Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr To: Mark Salyzyn Cc: Christoph Hellwig , LKML , kernel-team@android.com, Jan Kara , Stephen Smalley , linux-security-module@vger.kernel.org, stable@vger.kernel.org, Jonathan Corbet , Gao Xiang , Chao Yu , Greg Kroah-Hartman , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , David Howells , Chris Mason , Josef Bacik , David Sterba , Jeff Layton , Sage Weil , Ilya Dryomov , Steve French , Tyler Hicks , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , David Woodhouse , Richard Weinberger , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Martin Brandenburg , Alexander Viro , Phillip Lougher , Artem Bityutskiy , Adrian Hunter , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Hugh Dickins , "David S. Miller" , Serge Hallyn , James Morris , Mimi Zohar , Paul Moore , Eric Paris , Casey Schaufler , "J. Bruce Fields" , Eric Biggers , Benjamin Coddington , Andrew Morton , Mathieu Malaterre , Vyacheslav Dubeyko , Bharath Vedartham , Jann Horn , Dave Chinner , Allison Henderson , Brian Foster , Eric Sandeen , linux-doc@vger.kernel.org, linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, V9FS Developers , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, ecryptfs@vger.kernel.org, Ext4 Developers List , "Linux F2FS DEV, Mailing List" , linux-fsdevel , cluster-devel@redhat.com, linux-mtd , jfs-discussion@lists.sourceforge.net, Linux NFS Mailing List , ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-mm , netdev@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I added this patch series on top of Linux 5.3-rc6 and ran xfstests on orangefs with no regressions. Acked-by: Mike Marshall -Mike On Wed, Aug 28, 2019 at 10:40 AM Mark Salyzyn wrote: > > On 8/28/19 7:24 AM, Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: > >> Replace arguments for get and set xattr methods, and __vfs_getxattr > >> and __vfs_setaxtr functions with a reference to the following now > >> common argument structure: > > Yikes. That looks like a mess. Why can't we pass a kernel-only > > flag in the existing flags field for =E2=82=8B>set and add a flags fiel= d > > to ->get? Passing methods by structure always tends to be a mess. > > This was a response to GregKH@ criticism, an earlier patch set just > added a flag as you stated to get method, until complaints of an > excessively long argument list and fragility to add or change more > arguments. > > So many ways have been tried to skin this cat ... the risk was taken to > please some, and we now have hundreds of stakeholders, when the first > patch set was less than a dozen. A recipe for failure? > > -- Mark >