From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BA6C001E0 for ; Wed, 9 Aug 2023 18:38:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6A26B0071; Wed, 9 Aug 2023 14:38:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35EE16B0074; Wed, 9 Aug 2023 14:38:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B13B8E0001; Wed, 9 Aug 2023 14:38:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05DF76B0071 for ; Wed, 9 Aug 2023 14:38:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C7CB080F5E for ; Wed, 9 Aug 2023 18:38:20 +0000 (UTC) X-FDA: 81105426360.29.C110B4E Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf08.hostedemail.com (Postfix) with ESMTP id C9ADF160018 for ; Wed, 9 Aug 2023 18:38:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=omnibond-com.20221208.gappssmtp.com header.s=20221208 header.b=BfdYdGla; dmarc=none; spf=pass (imf08.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=hubcap@omnibond.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691606298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9EcmI8Rpl1R+tuyjPLJAOGmabIt197aKHT+nbD52Q1I=; b=qP7NPsrBpZ8NQuDqZDxOVT589ysn/b6WGA+CCdOuNFZsOMJMtemSWYcOJ3TJNkFqVrIHr8 mlMM3iSI2yreycaJ2xZtBTbmYXoUkm5vUIElEpc/zcBGIsGR5O6pKzhpc7kW7nZc7J2nm5 EJ+aKlGR8bm1vOv84jcnOD56KKeCngQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=omnibond-com.20221208.gappssmtp.com header.s=20221208 header.b=BfdYdGla; dmarc=none; spf=pass (imf08.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=hubcap@omnibond.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691606298; a=rsa-sha256; cv=none; b=3t/72BGzoF3SM4P3frHs4CLE0JshWk55jtZN+TZVZAw3K0p7Q4JpH2jPSWqcJEm1pgT6Ox kulv7+pp983l7dNtNlQCdzDEYEjZSIIhWJb6acgr5z8J2ipE6MIDTqrIA7sZzpn34P0a27 roIFZ1V3GnaV/U2HXU+Suu1yinO4QHU= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-40ffa784eaeso336461cf.0 for ; Wed, 09 Aug 2023 11:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20221208.gappssmtp.com; s=20221208; t=1691606298; x=1692211098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9EcmI8Rpl1R+tuyjPLJAOGmabIt197aKHT+nbD52Q1I=; b=BfdYdGlaV7wDLoLR9yjOQKYaMVK5G+sZo2gR8ietMzxK6/hhzrKBhXntyWFMe+Yo8W pXAEKi27jKY+o1GSIwlWHKByFh7VJx8vdxyzXfnpCla9dyz3P+vZbtPjJCJ8F75v4t++ cENDUCMzciHiNczMnx810YrXJp7LJHfpO0BqiOVkILP4ZM1XP/NHiA5CqbEHPLNAnApb 4blc5R+dkjgksSq2+K5JK9IBlHetg1olYAUJU7H7u688LciEb+01exSGkI+DT+Of4VXY kkHfq0UcUl8GdzevovO/osm+1AaLFSn4iK2zXa30egAa3a76m/vMuRq9Hke6KAEMMcTX y7cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691606298; x=1692211098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9EcmI8Rpl1R+tuyjPLJAOGmabIt197aKHT+nbD52Q1I=; b=MYQlVglg1kHrRT0gBWSYkF/ecCIve3Dugq8xK3/TQF/qeduOrxaXqyj92aedVtpjOQ LtdxC+pSbUNDU3EyGxDFu6w0gNkIq5NztQLZ41F8dAkNO8cEltDcEGspubelNs4n9hth nw9oWEPVGD7NGlORoGEpkQaurkr54RpWjMeRO83o29x53f7gVndW7ywis/aWgUn55C9N 8OSZSGg56IIu+gCI+CGpNt13hbl/9NT0xCWYeJBPOn3vjtUcgNprRG8+b45dIvcWjVHC 7Al6ACDMEH5weTvFQ6nfJxjasUzDZ4fuwAEZhugQOW0QKYp+fwDhmsuwxKtzWsaDQVd9 Xd3Q== X-Gm-Message-State: AOJu0YwLWL6rtmovyfJDEEwAoK33x38Qq0J4DCjfwm8ERFdDE7ZfQ523 gHlHYfEpQinRLKr8Y+E/vFCfXb3AZySSOvO30DQYXA== X-Google-Smtp-Source: AGHT+IH2sTR1ARtIFCpkS6vqthNwZFelmGu0RmLRp1wcx6mBBfZ3SQAFevZE8DnhGTo57OILWEQYl9skWtT3uKB51ZE= X-Received: by 2002:ac8:4e47:0:b0:3f9:c207:3123 with SMTP id e7-20020ac84e47000000b003f9c2073123mr166690qtw.45.1691606297822; Wed, 09 Aug 2023 11:38:17 -0700 (PDT) MIME-Version: 1.0 References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-8-d1dec143a704@kernel.org> <20230809-segeln-pflaumen-460b81bd2d3a@brauner> In-Reply-To: <20230809-segeln-pflaumen-460b81bd2d3a@brauner> From: Mike Marshall Date: Wed, 9 Aug 2023 14:38:07 -0400 Message-ID: Subject: Re: [PATCH v7 08/13] fs: drop the timespec64 argument from update_time To: Christian Brauner Cc: Jeff Layton , Alexander Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C9ADF160018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jdrcqwrzx3ff4ocqzbehkotbioaeupt8 X-HE-Tag: 1691606298-151306 X-HE-Meta: U2FsdGVkX19pNsnwrbiQGtcFTZionb5mgPh5te7VQfZeL4/sBwClYiDZsOmliA0iTJrrpz+EMhMtRAi6E5ocuFr3ZLaWApvRBcKan1+hhHZS48J5BHuitwR/o544WZ7iTf9VJTx6sdxrx78PME8squitDAn21rILnU/rfd78t7dCCuFYbguzJuZ/EZlYaqs0bgLSIGvpYH2C0g3928bD4TCHdp75pOo+Rm7ESfIUeX5wwpsCFlXJwkbmtsU6jer0Ygjd0/PELpE4cI3PU1LymB3fDw6GVCodtGD1VboCkv0ioD03nCKOfCvwnYmqVFvsfQ3J7iiZMWRLkTNrts6quFUv6a0WSFNUI8qkXrFBhshCJBqKsPRQsFcqZdF5B25xngLuN5fJVvvT/a2IfxckhRbIbmWiAhiVBrRXW6urp9y7Hi68GA66mTL1Fm5GGv9kKla3Vp6ajMfMa+5WnKepd9BrrWJRrsIhpaQhC5PYU8FRsflP6NFT/9WfF5QMLDCVKCfxVw36uQOU7g9IcEev7Q3I5W1nLHcg6cGblTuu7tVUb0hu4WBmx6t18WXtuR5jP620GAH5FTxMaHl4BHzatFMmtLNiGbvT8WGkDKXujfdIhjD17RzLvA8cmuBgLovD/CXnX/fvsFdEYCsoQjEx6HJ8eIO8/40Eiq1749qmL5JzgGfH9cmHWu1musysdPInAGAs5bp3qX19QU5iJF+3CBlpOqlylaIlxLAb7uujPogk4/+5I13W6CxpiDAQzgAD8d0348pYO7CLv6duIVefNCUIEasuJRp4J2FKg5rUSUv/NtR6hdCAkqgl4VR9m0yvoQZz9tNmAo0OUebHQo/t3/v9Ok9/Ol0tgnqCAu0h0SDNuNzvjYlzg+lJZxSnAMC4aa5o+IfBCJn0sTwZwPE4Y9Ow2uqfZXMfwd2H7u3cHd6/qtPAHgpyY5rgT1DnjSD30f7Slj0Y4Q7mfk9H2UZ Vph5yLnj /BpEbx5/Z1eSA/WPfhnS9SSr7YiaPd8s1iJbpcSa/7au6IHb4oVxO095V6nlME6MUNqfYt8QuwYwN/VSkK63ul6CvzOofRa2l+iAg8djwFg4nOpcr1aY3Zyk+ZnopDWUvePVLAp1v1p7fyESTUZlWQzWdQIMTHwJT2W21wkPS4thti7BmkyaEHTh0VahogaV0l7A6wI1VuEDBym2bRPqA97TARRYQOcAXJOxKoGM+HwINciM/Za/fUCUQR0EURtYSgHWBubGnYgxGbkq3sZN/lpnPoYQl2zXIVcC/uNkiX+CoOo/YkU2j07ztkL5JTGTLPE1x3gBxqVGN0iFdx3hEXV6H0Fibdie4T+ERECkjpgEvw7lncZ0pFbzHS0dm+dkYXvKY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I've been following this patch on fsdevel... is there a remote I could fetch with a branch that has this in it? -Mike On Wed, Aug 9, 2023 at 8:32=E2=80=AFAM Christian Brauner wrote: > > On Mon, Aug 07, 2023 at 03:38:39PM -0400, Jeff Layton wrote: > > Now that all of the update_time operations are prepared for it, we can > > drop the timespec64 argument from the update_time operation. Do that an= d > > remove it from some associated functions like inode_update_time and > > inode_needs_update_time. > > > > Signed-off-by: Jeff Layton > > --- > > fs/bad_inode.c | 3 +-- > > fs/btrfs/inode.c | 3 +-- > > fs/btrfs/volumes.c | 4 +--- > > fs/fat/fat.h | 3 +-- > > fs/fat/misc.c | 2 +- > > fs/gfs2/inode.c | 3 +-- > > fs/inode.c | 30 +++++++++++++----------------- > > fs/overlayfs/inode.c | 2 +- > > fs/overlayfs/overlayfs.h | 2 +- > > fs/ubifs/file.c | 3 +-- > > fs/ubifs/ubifs.h | 2 +- > > fs/xfs/xfs_iops.c | 1 - > > include/linux/fs.h | 4 ++-- > > This was missing the conversion of fs/orangefs orangefs_update_time() > causing the build to fail. So at some point kbuild will yell here. > Fwiw, I've fixed that up in-tree.