From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF402C6FD1D for ; Thu, 23 Mar 2023 14:30:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64E36B0072; Thu, 23 Mar 2023 10:30:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEE226B0074; Thu, 23 Mar 2023 10:30:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98E036B0075; Thu, 23 Mar 2023 10:30:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 82EBC6B0072 for ; Thu, 23 Mar 2023 10:30:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1DA23AB300 for ; Thu, 23 Mar 2023 14:30:49 +0000 (UTC) X-FDA: 80600399418.09.1CCBEDA Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf06.hostedemail.com (Postfix) with ESMTP id 213E8180031 for ; Thu, 23 Mar 2023 14:30:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=omnibond-com.20210112.gappssmtp.com header.s=20210112 header.b=uga6xPbl; dmarc=none; spf=pass (imf06.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=hubcap@omnibond.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679581847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DW5cWuSORuMPl9h4M/OMu4zN6Ab689Cgd2Jmn907uzA=; b=31tFa88MGNfiUc8sp5sPWwXo3nS0UGMQLAl2gLlbCClgkHoUyVBrp/5vWYdJSldYWPZERr sgYodVzt1VJAHaoBE6XdyFmV9vXlJ71r/jmdPYuy5w/vdBn0hvC9ZZhapygM35yYZa8vfu W0pCtZ55lgyuefNYAwXlA3Dk0bybB5A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=omnibond-com.20210112.gappssmtp.com header.s=20210112 header.b=uga6xPbl; dmarc=none; spf=pass (imf06.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.219.51 as permitted sender) smtp.mailfrom=hubcap@omnibond.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679581847; a=rsa-sha256; cv=none; b=mTbV5gP0BzTwYN7RBkj4/hOELjgz7iuvyf3R5k2NOnsDyTiid20QGmRP7HXlcBYr9OC3B9 yxUQD7HA6yVXQE7sLdVF1D9okeymgpmxC0Kit2c4ZRd5iOREl7COjAjZ/JIhSG4OqizbsZ /ZRkwZxLo3Oo+3gcEhaEy2U8VI9Z+Hw= Received: by mail-qv1-f51.google.com with SMTP id cu4so14208358qvb.3 for ; Thu, 23 Mar 2023 07:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20210112.gappssmtp.com; s=20210112; t=1679581846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DW5cWuSORuMPl9h4M/OMu4zN6Ab689Cgd2Jmn907uzA=; b=uga6xPblyjNwQ0nys0O9OMOnWPlxzoqUx0tub1g4jl3Ds7H0qu2WTey6xF5KYLxKjC SCNdX/4AXYIE5IhDdtecko+9IOBtUIc3U2CM4hPqaHHiSjJXBWP+o6JLCwKslIKRmAED TXE8V7Fa5Vj5MdO1Sgso1Toii0RePFj640IY5JVqwEa1uZwDrQZ5LDzFX93GFGZY9IjQ hb8Z808MK7gqHrpq+J6Wxii0pqN6Kedc0VTbCmzHxDcz5RluBsBf5YY47foQKVJ8WL5w Hhs7tyAu+HDhks/IkXKF2t4EX3GViwlbB8pSikG3+R69thN52bWR4mIjSGgorkjzAiC0 GC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679581846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DW5cWuSORuMPl9h4M/OMu4zN6Ab689Cgd2Jmn907uzA=; b=cvQn7/DjJmVt/yWL7Tn1oGqQ+7WuFbc15WQxuoHiX+ElOhZ4L8vn9Ns2Rw7pCXJb9J ID5iOdNAfFWqvrsXiUr7MWu8SxYmfxerXR8DykcSPMAUN8DRLeCjP8THxAw604S3MSAe HJhkSGJVzGXX43SzfZ8AkYjeO25yGZpZv9e18CJpjhinv93AmQ55EaZPnwpWiuseJvHW x6x2Htbs7HYQ9GIdgsX0BTZLwNVjryHkUQAJYxbZXhOS1vAwCb8PniY18THakVqmobmJ jMSho7FJd9q46f7hkpLvdeiX+Sr5QaPCDTCYwZUiXr8ZHmkxThcn7d1gLeyw8Hy8nQGd EeUw== X-Gm-Message-State: AO0yUKXAp7AjXzfvRf+KCibuwlrkAPss1g98CqMzHBhrPzauhjLBW26M A5dDlXEZh1OqYDI5hMfDM9ef5dfagtB8ZDAo7pjKkA== X-Google-Smtp-Source: AK7set/trVllkfcEi+yg3oqpS8DY+A/uEckTTWNRYDqUdJd5erFFIJB2DTR1p2z4pS/Mo+VlMX55/q/gvrdpE0I/XKA= X-Received: by 2002:a05:6214:8c7:b0:537:7476:41f7 with SMTP id da7-20020a05621408c700b00537747641f7mr1552535qvb.3.1679581846154; Thu, 23 Mar 2023 07:30:46 -0700 (PDT) MIME-Version: 1.0 References: <20230322135013.197076-1-p.raghav@samsung.com> In-Reply-To: <20230322135013.197076-1-p.raghav@samsung.com> From: Mike Marshall Date: Thu, 23 Mar 2023 10:30:35 -0400 Message-ID: Subject: Re: [RFC v2 0/5] remove page_endio() To: Pankaj Raghav Cc: senozhatsky@chromium.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, willy@infradead.org, brauner@kernel.org, akpm@linux-foundation.org, minchan@kernel.org, martin@omnibond.com, mcgrof@kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 213E8180031 X-Stat-Signature: 9ewh7981hjrd5s1ht58jcfrhm1kjaih7 X-HE-Tag: 1679581846-471458 X-HE-Meta: U2FsdGVkX18YuCIPAX8ZRo2Z2k66098IsvUMldPF4DnBrBewYamz0X+sW8zTGrnsg73y/WdEFkPMmAirppbRkNQbuBRtDG8Q1OsLOFDxrkgx1tqL8sELTsN29VD6PVLWQHvhOwm3HUpj8OOCGlJc9IrLQ+JNRJt37PvKe/P+5O2SMP96VJi0IMYYXghJCK5m8UYgBduse0nxfd+dCLgx1X3bfDtj5Gn7K68ryegc+n93D7NTBYiRyT7tup2HuJykwu1xPX5DCM2QjPpT2Pvf//B/QhpaF3LEQw2KgJ+B8Iyy5rT0oxvAe3qc6pJOt2QtG2rE4050apMzAZ8N9L1iejRsatpKX6eknXs8lAgEKnV9QQJx5wPcstjTBVvXJW3kyt/TU4qlNNjwFEjN947pfAEwy49DKO2hTvXhkxUxZEUszzehi8f17uWFrl4lbJMmP3dbEY2d0vIeylV3znIp2DrVxGt/9zAJRWnUZ/vKyoEkJAbmZn6X7njy8retcVZkd6QW1cYloEwsNw5ML+h/VE404hDv5ZmNkDWRMcHldNFw3Hh+bLHapyunoSFzJaxk9JMrKQVmzzKDfF0QdbqGRyslKokslfmjm2hy9Nti5MjXF0b5xDPV1VUjTvXVGQx5OEa/FjHM/MZ/kpCPt/I2N3lQOJkCXpqnFThBYKbAJJXBkCyNlFdIT5P4HBp9njhb+i2Jr4/TpzpYl0rth4hpq4j/Yx+sPnlOU5K40zpnvmPzsS/rAyOR0yE+w2n4AHLVkM7EwH2NkCUj9hbUKvNTkRfDQBNX3pqtn/hRewJCw9KsGJnjHRFIHNIDn4igYj95MhJ6E/nOA00s8RxqoUBqOqqqiBLN45uf6soNeQaSGsOaczuqTGVXgwfr9zraFPIHnvmb7c7zr4EOY8hB0ofItTD9fMJl5E9hwBrm9p0d4JdIYG4xFdpcZPzRd5/3ipfJMob2N7oBHFyDfKxJo4i C4PKQaMq klESaFDqEbV6ZQDHorrfSDiBR0QtsqRUjLFe29KMcYK9JhWMmKk05MfFBUHDo/DP2NOBhf4WB8YggukWrj7nHjwCQDmLsaLIX5Q/E+525slJmMbLHohq16V+gg4XMXtzuHlygRF+HbNrmIR6qZ/CjfUHd0iSVPZGq4CRoaSDu07qS9Es9rUBtAsIe2Cqe8XLtqESQjQ4YmyE5himunSP7fgem6E8NEX3derdCmenVOvz/PEJUmV3q2fPG/69yR4Yxm3KPdMKXl9hXSiYDvdOMQ7taaK5mx1HGv7vJcNgO3XhZk3InGWibWJuhjtOJzLvif3y335jsLObhcwWzKCJOoWxz60yREGHCmGxQalVSRcmAX0cCmQDdUTTYbmFrZQjEF8/NODqlk1lazDFTY1AE91mfFC08KKxCCI3xeoTqskES5zh5abmwMKTqino7pIHhcp7L9X7RwX3r9qqIwETN41Pg+vrvwjicFzUY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I have tested this patch on orangefs on top of 6.3.0-rc3, no regressions. It is very easy to build a single host orangefs test system on a vm. There are instructions in orangefs.rst, and also I'd be glad to help make them better... -Mike On Wed, Mar 22, 2023 at 9:50=E2=80=AFAM Pankaj Raghav wrote: > > It was decided to remove the page_endio() as per the previous RFC > discussion[1] of this series and move that functionality into the caller > itself. One of the side benefit of doing that is the callers have been > modified to directly work on folios as page_endio() already worked on > folios. > > mpage changes were tested with a simple boot testing. zram and orangefs i= s > only build tested. No functional changes were introduced as a part of > this AFAIK. > > Open questions: > - Willy pointed out that the calls to folio_set_error() and > folio_clear_uptodate() are not needed anymore in the read path when an > error happens[2]. I still don't understand 100% why they aren't needed > anymore as I see those functions are still called in iomap. It will be > good to put that rationale as a part of the commit message. > > [1] https://lore.kernel.org/linux-mm/ZBHcl8Pz2ULb4RGD@infradead.org/ > [2] https://lore.kernel.org/linux-mm/ZBSH6Uq6IIXON%2Frh@casper.infradead.= org/ > > Pankaj Raghav (5): > zram: remove zram_page_end_io function > orangefs: use folios in orangefs_readahead > mpage: split bi_end_io callback for reads and writes > mpage: use folios in bio end_io handler > filemap: remove page_endio() > > drivers/block/zram/zram_drv.c | 13 +---------- > fs/mpage.c | 44 ++++++++++++++++++++++++++++------- > fs/orangefs/inode.c | 9 +++---- > include/linux/pagemap.h | 2 -- > mm/filemap.c | 30 ------------------------ > 5 files changed, 42 insertions(+), 56 deletions(-) > > -- > 2.34.1 >