From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB05C77B61 for ; Wed, 29 Mar 2023 19:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC67D6B0072; Wed, 29 Mar 2023 15:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E76C16B0074; Wed, 29 Mar 2023 15:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3E0E6B0075; Wed, 29 Mar 2023 15:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C19F86B0072 for ; Wed, 29 Mar 2023 15:10:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 75005140E3F for ; Wed, 29 Mar 2023 19:10:18 +0000 (UTC) X-FDA: 80622876516.17.538CCCB Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 8A45B8001E for ; Wed, 29 Mar 2023 19:10:15 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=omnibond-com.20210112.gappssmtp.com header.s=20210112 header.b=ebtARkhW; spf=pass (imf02.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=hubcap@omnibond.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680117015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pvuwFXbgUAZbOJPeg//uwBjMCt7EFsCpzym2Ulfy8+Y=; b=AWlTDByWk4Cz3tsj26MpBegbrLSkYrJw9aeKEnVchpLSoJ+ntP4698BLyKdbsKaRbSPhTy +RP6V08FaDKr7p14TMx3rDwRMFXne8wcEgUX5e+38hJKBTktsXeL5Sd6NwgWFIj3VNLdu4 05m+u/rfZi1mf2kT6B1hI4hsQOv56W4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=omnibond-com.20210112.gappssmtp.com header.s=20210112 header.b=ebtARkhW; spf=pass (imf02.hostedemail.com: domain of hubcap@omnibond.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=hubcap@omnibond.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680117015; a=rsa-sha256; cv=none; b=rcpXKCNNCCkALvYi1qssBoe/PpVo2TCNHQqIsMGVnxrkYjX1zCpnGp9uPVTNedoV7VJeRA PxXILqW0RK8C3//5vagWvYjXtiRvzdYDZMe304/tIR9Phf1w28pcZX90v0KU0BD442XYVu YCh1xMKe2GMEWAc7RdVZDR/V5AXFD+Q= Received: by mail-qk1-f173.google.com with SMTP id u15so5089602qkk.4 for ; Wed, 29 Mar 2023 12:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20210112.gappssmtp.com; s=20210112; t=1680117014; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pvuwFXbgUAZbOJPeg//uwBjMCt7EFsCpzym2Ulfy8+Y=; b=ebtARkhWyJHfb4xtYmoYLGrX90kc/jqbKsnTc1bFtUGbeXJTTtNSjWPR/37szx/txC HSK5H/HTOxvPW/DiblqMtvOIpwMd8KJMsw1Yrs44z/1hzgwbP/BeOHDbFz5apnBTrbpL 9xMWAlkZ1hlrdu7JYlxAnGZu2sdiaP5L9M6tuvAqST9HmN+Xo8ZbZPu1cbZH2fDDxMMp RNR0rco3qMLpRaOrC4bpW4AixtA46YIItjBLMPwTA2K4hehu6SOF4jHGMGoJSREa9atw /D43mJK5uSjS3KTSTM7H4HFaxALEIBTlBWYpk56E7grKxlsje3B5HOWznCjKAZqya0AN Wgrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680117014; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pvuwFXbgUAZbOJPeg//uwBjMCt7EFsCpzym2Ulfy8+Y=; b=Qxjohrk0y/M3t+ta3lMJW+s2SeqbFK+JZAs8rtGhjo6yGjgyj5uwOEAHsIhX5684C4 ESlLcJwYkDtm2+dsV+mXfHaiwVmgP6y/RjgtvOy+ppzqZ3d/64LIl0giKiknJYbWLkR3 pbrloQu18Y8zreTf5IwGSI5H1tOS+ZuR7/T2mZ2Cpjl4O5XbQeGL7hARjBzZ8s7R+CuH srMenLdZdG4Kj83WYDlT/oVxy7P6Ox2/NbKeYpz+wAfhOenAIBP5mX+VVqHsDO8kz+fa cdm0J1lScjDenYpsKRdyuR+3kesQ314Dr7XYCJenBaNI9Vd44Q2Rtc/YUlp1SRuqcqnb +6SA== X-Gm-Message-State: AO0yUKU9hsLMt/8k2OHUj2h+gSFItNOsHOy/MZCDsb/rxqUiPl1x8Rlx 9OHt1SRgz0cfoVUDinajAh0XLizAzKrtKvvsjFx5iA== X-Google-Smtp-Source: AK7set/Yb2wuao9kPPFNja0Rt/lA/InUM3qkLAM9YZSn3q+PyxYrIVFQqkC65KODw3TvQ6tAHSedKs/4ZupBKHOYc20= X-Received: by 2002:a05:620a:4154:b0:745:32ab:4d2a with SMTP id k20-20020a05620a415400b0074532ab4d2amr4017411qko.14.1680117014615; Wed, 29 Mar 2023 12:10:14 -0700 (PDT) MIME-Version: 1.0 References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-3-p.raghav@samsung.com> <970b8475-a52e-9adc-65cf-5a95220bd35b@samsung.com> In-Reply-To: <970b8475-a52e-9adc-65cf-5a95220bd35b@samsung.com> From: Mike Marshall Date: Wed, 29 Mar 2023 15:10:03 -0400 Message-ID: Subject: Re: [PATCH 2/5] orangefs: use folios in orangefs_readahead To: Pankaj Raghav Cc: Matthew Wilcox , martin@omnibond.com, axboe@kernel.dk, minchan@kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: pgcrs3jqmkzm3af56j9y1ib1zfrh85b4 X-Rspamd-Queue-Id: 8A45B8001E X-HE-Tag: 1680117015-396364 X-HE-Meta: U2FsdGVkX1+cALlMwBNEAvHQ9kfRry+Le2VHCLQT6Zx6TuuXNa5e3meBNfRvGuRojbZLbSJTqg/icc/swrtNIPzihbbNvFfavLMkSI4X62XzHAt3Otc+rDBOiB3xwD/axaUIHpZR+SYsCen6pTsC6HxsanMd+jMFymiws2v1aJeLHVXU/krKi05g+8jTNVOW3xCZ8yaA+pwAL87UqXrV+Z+lWzdFQP/0UkFD8AG6qGnqhIvj8I6cictn58r7irnOYNZszi2mSgOaTBe4x1XgOCiJFpSn8wegpOZ8c2BwURHeCqdfEfUbddu9F+PF6oWR8qnX+HYX1IUV5+3ib++nWH5YTqs/obJxjt054Df5Gp9Wv9mqdMFRUJRYyxrrIkH0mR2lZaNkgccdnerSKybQ5Bxwgf1KhHfmkiDN1/3AZOVmDPoceqeXtzJwKdasK+LGJaCZghXmbtIL/bDqDDco0juDNC03Y/hf7lXiIhSVL6Uliv4D3QwsWsMpUBdY4pFrJ806I7Zw5EEuFn8egTt90PnqfM4Bu1a9szltUUWHD9HhrfI6AEK35OLh5Ek1qtqtQKCcMWs4EnyptiVLPiV+n5LehylDKi9E3n0FDA9crKES9KyceU2/h/tLJeAKPr8QeL1KgbKH734XZRE+faNMOIwVTVEk2xj6x58CRexsRZy8K9gJYUxOOkxaEYJ2s7O7D5s4DG0ljuh18JHbVGllITa3UxfNgzFvpXKbPsF/J8TlVn7aIp+cwpChVV0zrkcqJQxIFwBLbjIp51snOFfkCBWccuuhUFI0C68nB7QRqVcUX7wX9eegvxQfICFcp3VmRoBaAQsRdw1drIrYBq91obPHMZicKtlXSX6DHBLiztKMJ7bwOTvcA+PWiI6pG9V6BCg3eq87S0zk3I5jBcoLKb2S8fWxRpcv3ZULHMlyxf+8wiyOiT3d7G9DPSk6g8fSaXqAuSgGjYuNgY2Lmx1 wadiR2/J 67TR98IhKMHcHIgbQZHQuynbCV0e6STwd+Svc46YEcrw38QaU4iCq6xie7b0BiAaRVmqKGA6nr/zzh2wLANY3G8NCnb8bz3Ci8EM/KK98wFopG2TwQANRnOLbi8/rhWm43wVry45+xrbjdAnq+QUfJHWxmXM+JWE4ZVzcLeweAaw7pIfmHT68BIxJSi6uttgUovJrZTP95HDfPvW4kWrRbjqIhEd1u8upxBcQYDG7wzk4ycg780QAM0OVG46611gGxzPzljbWZbHPppfMbv8UQk8chIQOR5JLOXun/UGgwLuUfixEb8a/VatIQ8vsm77J1CJOdkmgGAnaTGnnj1FxHXN8SArQBT8YKQg+TKDYIvEV1NSfvmT9OPb9Lwq1W6orDAeL71EQY2eWHpinZIfJpUmI/Dwdz0JNcUSLZlD1mM62rIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I thought telling you that I tested it was good :-) ... Please do put a tested-by me in there... -Mike On Tue, Mar 28, 2023 at 12:02=E2=80=AFPM Pankaj Raghav wrote: > > On 2023-03-28 17:21, Matthew Wilcox wrote: > > On Tue, Mar 28, 2023 at 01:27:13PM +0200, Pankaj Raghav wrote: > >> Convert orangefs_readahead() from using struct page to struct folio. > >> This conversion removes the call to page_endio() which is soon to be > >> removed, and simplifies the final page handling. > >> > >> The page error flags is not required to be set in the error case as > >> orangefs doesn't depend on them. > >> > >> Signed-off-by: Pankaj Raghav > > > > Reviewed-by: Matthew Wilcox (Oracle) > > > > Shouldn't Mike's tested-by be in here? > > I mentioned that he tested in my cover letter as I didn't receive a Teste= d-by > tag from him.