From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AA3C433E1 for ; Fri, 21 Aug 2020 03:15:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 536F420758 for ; Fri, 21 Aug 2020 03:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N1mku6Tb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 536F420758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC5CD8D0033; Thu, 20 Aug 2020 23:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9ED48D002F; Thu, 20 Aug 2020 23:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB3178D0033; Thu, 20 Aug 2020 23:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id B49808D002F for ; Thu, 20 Aug 2020 23:15:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 784FA180AD817 for ; Fri, 21 Aug 2020 03:15:54 +0000 (UTC) X-FDA: 77173111428.09.bell35_121833f27035 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 52EAE180AD811 for ; Fri, 21 Aug 2020 03:15:54 +0000 (UTC) X-HE-Tag: bell35_121833f27035 X-Filterd-Recvd-Size: 5561 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 03:15:53 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id w14so307773ljj.4 for ; Thu, 20 Aug 2020 20:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xpBteEoROr4Nic9SvTstVZLq2r5fSw67RnMJ2WPoDGY=; b=N1mku6Tbb2LRLgaAzlWXEihoq6ZMPeUfr6yLOnq3j9QkuwOKkeEdcKlcsq31FCE2ok ZjpCG3BZdE3d7YHbFoZV7LGTOQmsh1zo4rAwpauwqlrBRq171qumpQnTsfC4mYca+/cP MXqacYTjXjfzTLxB3Obxzd3hAOkLhyQGc0fVmjZM8se1Kk4bn6Ba7K/ws4/cDauuQ8y2 A9A53UeqoQdYYF1C5hO2XP4aY9KUmIOqx/6MJeDZe+6NP+bd06qIe5/rD3g0w9lIm/8P qrhK5neIVvEHExXLnLtvWhTgNGDabQhGMojM5YLc5RHUQ2yDR7x/NnVKyapuQwUytg6N vEeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xpBteEoROr4Nic9SvTstVZLq2r5fSw67RnMJ2WPoDGY=; b=l1yD1PdUl/Q26xlEYwloBTS/c9uL6j1BJ99XhKlj+b7M+2dJpGYrELD6JxEETWgvUg 9EbFhSwk8pLOQCnxVuuzbbK2Ig7X4fYwyNPDlfMRqtK4nn9Xs2kB+AMOwW/zg7ro4l89 rb0k+SfX9g1Z1b+jD+8E8vgl8L6MKSzaPnE/xXZQMwukG1KMfnXAuVtxGsqtRolSmChM WIEIf2pnCO080GBVF0PgxdiFtrfyUhJByPZRDXNIuTWMp6bVzS5G5qmhjmIu7twEbH6f e/AExL61IQBNrdnb5u+Y9F2+2jTpzYJZOZCJprxzD3CIRKWHf0N4vbUKaFvLq3koZ3bb TDUg== X-Gm-Message-State: AOAM532z6rBY0dgkQs9Jgnrx3pRyqVeC+nkqbgbULS8Wnv7yOKlVz4n0 cxhP1EhHUG8/TpWSM+44TC/gUGzG0MRbN/3NR0ap/w== X-Google-Smtp-Source: ABdhPJw7fdZRHgGvTPAg3CU3Y4/D0dW53Q/L4Z+k5raZJoeFUvKpyEVwZwlUGZQi7L57Yuta+RL4TLGQy/Y2Glt21Es= X-Received: by 2002:a2e:b892:: with SMTP id r18mr429615ljp.249.1597979752633; Thu, 20 Aug 2020 20:15:52 -0700 (PDT) MIME-Version: 1.0 References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200820160014.GF4546@redhat.com> <202008201414.9E7F4F9D0C@keescook> In-Reply-To: <202008201414.9E7F4F9D0C@keescook> From: Sumit Semwal Date: Fri, 21 Aug 2020 08:45:36 +0530 Message-ID: Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory To: Kees Cook Cc: Oleg Nesterov , Andrew Morton , linux-mm@kvack.org, LKML , Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Michal Hocko , Colin Cross , Alexey Gladkov , Matthew Wilcox , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Mel Gorman , Robin Holt , Shaohua Li , Johannes Weiner , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 52EAE180AD811 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Kees, On Fri, 21 Aug 2020 at 02:45, Kees Cook wrote: > > On Thu, Aug 20, 2020 at 06:00:14PM +0200, Oleg Nesterov wrote: > > On 08/19, Sumit Semwal wrote: > > > > > > --- a/include/linux/mm.h > > > +++ b/include/linux/mm.h > > > @@ -2484,7 +2484,7 @@ static inline int vma_adjust(struct vm_area_struct *vma, unsigned long start, > > > extern struct vm_area_struct *vma_merge(struct mm_struct *, > > > struct vm_area_struct *prev, unsigned long addr, unsigned long end, > > > unsigned long vm_flags, struct anon_vma *, struct file *, pgoff_t, > > > - struct mempolicy *, struct vm_userfaultfd_ctx); > > > + struct mempolicy *, struct vm_userfaultfd_ctx, const char __user *); > > > > It seems that you forgot to update the callers in fs/userfaultfd.c ? > > (I recommend including "make allmodconfig && make" in your test workflow.) Yes, indeed :| - that was stupid of me! > > -- > Kees Cook Best, Sumit.