From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E338C433E1 for ; Wed, 19 Aug 2020 17:48:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3DD1A2067C for ; Wed, 19 Aug 2020 17:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r6xr0KJU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DD1A2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C226B8D0038; Wed, 19 Aug 2020 13:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAA7C8D0002; Wed, 19 Aug 2020 13:48:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7DC28D0038; Wed, 19 Aug 2020 13:48:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 8EC578D0002 for ; Wed, 19 Aug 2020 13:48:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5AB4512E8 for ; Wed, 19 Aug 2020 17:48:33 +0000 (UTC) X-FDA: 77168052906.23.net92_130385827029 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 336A837606 for ; Wed, 19 Aug 2020 17:48:33 +0000 (UTC) X-HE-Tag: net92_130385827029 X-Filterd-Recvd-Size: 6113 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 17:48:32 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id i19so12508686lfj.8 for ; Wed, 19 Aug 2020 10:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jrgv1imIMPSBsshdKTzp1a5Mj8pU660cD6tExwCNbuI=; b=r6xr0KJUdTtyu+Ci+TEPoBWP5HySsQYRRBjXEAoMngzKepy9fzzc9zILUsNhc8FkTh 0M909uIVjsM5d1TkBGz/AwWMOsYP8S2bXE9BDioTz5xnDI+9gzKD9eIWCkIE5uqu2RQR vN7CtUtc4eTjfnosrQVzyHayYyzoErpRbAYPi3dghetYtfMDdLIca2SYVo5pzYa1s+Hd ElSKTFMtevLUey21R8yVNZSipzDBL5JVSXjBv3KIHOnb+gY1LmAt8aRDSVlgkSh2kBVz 90LUKkfw9riSvIMmld5r09dkQy2cf+oTPSg+1ZQ0+FymBjciRv86/+xhji7kiY/E/EU6 +k2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jrgv1imIMPSBsshdKTzp1a5Mj8pU660cD6tExwCNbuI=; b=NZH27GJ7QpG9Z4u0iTtKqhjOWENNnt5H4u/j+Jg4pSE0IGCcyvyWGVPAbkSsgHa9HW RZRjpAzwB3BYAFdwUzX0lAYLU9eAsu5734E8jGsAuzWB7RHZUvqf7SlL0iNLb+YdxICE EqT3++8RNai8WYABMh2GdiEWZZTZ0RMvTZ6gxg1p1e5i1jU6HV/EcypBXTHdkPdK0wS4 gcWHxTxiwuz4fILEBmfhudKe4ngCYvZ57E5xceLRrqV+ftKAsKBTe/ZwdMlG/TZCk1tn 6alULn6dq/MlN+Q2ynBP7Al772V5Mq6/n9Zxi8e64lwV++6f45V5NWH0zPzB1Ub/1cU8 Id6A== X-Gm-Message-State: AOAM530yChOF6sSzElHIyrYbBck+1LnqbGwFXlPztCIfxnQ0E9yitwW4 D/eVjNpSELrU3CoetKLGlXtUXqehUuDvc8y6LtuBpQ== X-Google-Smtp-Source: ABdhPJya7nYDJBKj+e4fnaq4uXzX3+5kl66sqg8CM7gfVHwZ0A+vZ2ERWjMlIeYR615E/tsDPG46oUm0tCAbAApj2/E= X-Received: by 2002:ac2:5b46:: with SMTP id i6mr12555186lfp.135.1597859311072; Wed, 19 Aug 2020 10:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200819150251.GD17456@casper.infradead.org> In-Reply-To: <20200819150251.GD17456@casper.infradead.org> From: Sumit Semwal Date: Wed, 19 Aug 2020 23:18:19 +0530 Message-ID: Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, LKML , Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Kees Cook , Michal Hocko , Colin Cross , Alexey Gladkov , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Thomas Hellstrom , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , Oleg Nesterov , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Rik van Riel , Mel Gorman , Tang Chen , Robin Holt , Shaohua Li , Sasha Levin , Johannes Weiner , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 336A837606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matt, Thanks for the review! On Wed, 19 Aug 2020 at 20:33, Matthew Wilcox wrote: > > On Wed, Aug 19, 2020 at 07:46:50PM +0530, Sumit Semwal wrote: > > +++ b/include/linux/mm_types.h > > @@ -336,10 +336,18 @@ struct vm_area_struct { > > /* > > * For areas with an address space and backing store, > > * linkage into the address_space->i_mmap interval tree. > > + * > > + * For private anonymous mappings, a pointer to a null terminated string > > + * in the user process containing the name given to the vma, or NULL > > + * if unnamed. > > */ > > - struct { > > - struct rb_node rb; > > - unsigned long rb_subtree_last; > > + > > + union { > > + struct { > > + struct rb_node rb; > > + unsigned long rb_subtree_last; > > + } interval; > > + const char __user *anon_name; > > } shared; > > You can significantly reduce the size of this patch by doing this instead: > > union { > struct { > struct rb_node rb; > unsigned long rb_subtree_last; > } shared; > const char __user *anon_name; > }; > Thanks, will update in the next version. Best, Sumit.