From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2EFC433DF for ; Fri, 21 Aug 2020 03:14:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07C8620855 for ; Fri, 21 Aug 2020 03:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o1xXkIL0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07C8620855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70E5D8D0033; Thu, 20 Aug 2020 23:14:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF3B8D002F; Thu, 20 Aug 2020 23:14:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ADD48D0033; Thu, 20 Aug 2020 23:14:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 457DE8D002F for ; Thu, 20 Aug 2020 23:14:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F0B7F181AEF07 for ; Fri, 21 Aug 2020 03:14:20 +0000 (UTC) X-FDA: 77173107480.06.bone18_0f0a74e27035 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C73C910044BA0 for ; Fri, 21 Aug 2020 03:14:20 +0000 (UTC) X-HE-Tag: bone18_0f0a74e27035 X-Filterd-Recvd-Size: 5633 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 03:14:20 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id m22so303265ljj.5 for ; Thu, 20 Aug 2020 20:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0TpFqlMEavG1lTaWcU11dlhoor5CR/pFrtrWlOh5AbI=; b=o1xXkIL0wMajM0ELU7vhzSUOCAr3mBALhT9Bdqq4CYS25WTCGYNZ6L8gDNcPrpuxDw OC4K2dBTt7gcyyQ6/quRLtwm2YXkGJseSV9DoCh7/JZ/lmw5dYpxeqVyG2779wAi8UKU /KA9XW/v330/4hq31dgscvmxbF37WteHOQDHOkzJsESKzrXvc+LPJtGiP5M1fCTH7n8p IUfAIsnmk1IwRS9jBLDtxXTzPFy3gzeU5ysIFWDJNwSE6L0VE59YR/h4zN79hm3b7G4p HHkCGQwK9Prbv0dTh6SLhdMo3ribs6WS1UCyn6zo+ibav24SvFOOkg0cb9bID/hKyFar CFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0TpFqlMEavG1lTaWcU11dlhoor5CR/pFrtrWlOh5AbI=; b=GVhdCDiOHCT/Lkj+hLPBDdi8xvuSEedQfLYPMNFMXsBUZ/nwgsR4uYj1xW7kaxIISR fHnlfRKQVwi+cNiTk8RjakWGd6sfdrZjOgSEGu/k+K8Tpb1DDnP5WvP2WmSQ8cbr6iet 14L85mvs5H1jLLbrO3rwIRBAFL6zmlxg17N1/HFX0Ij4AAbwzVa+SjA5B2KN09UhcJYI xUhoTeh8Z9KNKni2ZCBpl0jkcSttOXWyKPXpzWhBnm3AJpZNBnhwqwRYt50xZSWGpQCT nAiBZF0xzyilaEV29NCLzFHw0eUEl940dqeLr81V1D984QexF6Qq5e5TkqBK0A7kcjNw jaKA== X-Gm-Message-State: AOAM531VfzjOUQH13E8wYHWyR2ml2YGZnPzJ8QEi3rN+JRsSSuHpcPr3 I0qRGT7IN7S+vAOD+wS48LQnnl07PevZy9+/zXgCUw== X-Google-Smtp-Source: ABdhPJzg6RWWRWvyI7lb3+tG88ALQ6tvuqUkfTNb3he3oKM4sNdYEfSkjq20nT0fU1uCDNkcWDhmpZo4YNw+bxwH8BE= X-Received: by 2002:a2e:a555:: with SMTP id e21mr511789ljn.304.1597979658554; Thu, 20 Aug 2020 20:14:18 -0700 (PDT) MIME-Version: 1.0 References: <20200819141650.7462-1-sumit.semwal@linaro.org> <20200819141650.7462-3-sumit.semwal@linaro.org> <20200820160014.GF4546@redhat.com> In-Reply-To: <20200820160014.GF4546@redhat.com> From: Sumit Semwal Date: Fri, 21 Aug 2020 08:44:04 +0530 Message-ID: Subject: Re: [PATCH v5 2/2] mm: add a field to store names for private anonymous memory To: Oleg Nesterov Cc: Andrew Morton , linux-mm@kvack.org, LKML , Alexey Dobriyan , Jonathan Corbet , Mauro Carvalho Chehab , Kees Cook , Michal Hocko , Colin Cross , Alexey Gladkov , Matthew Wilcox , Jason Gunthorpe , "Kirill A . Shutemov" , Michel Lespinasse , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Song Liu , Huang Ying , Vlastimil Babka , Yang Shi , chenqiwu , Mathieu Desnoyers , John Hubbard , Thomas Hellstrom , Mike Christie , Bart Van Assche , Amit Pundir , Thomas Gleixner , Christian Brauner , Daniel Jordan , Adrian Reber , Nicolas Viennot , Al Viro , Thomas Cedeno , linux-fsdevel@vger.kernel.org, Pekka Enberg , Dave Hansen , Peter Zijlstra , Ingo Molnar , "Eric W. Biederman" , Jan Glauber , John Stultz , Rob Landley , Cyrill Gorcunov , "Serge E. Hallyn" , David Rientjes , Hugh Dickins , Rik van Riel , Mel Gorman , Tang Chen , Robin Holt , Shaohua Li , Sasha Levin , Johannes Weiner , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C73C910044BA0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Oleg, Thanks for the review. On Thu, 20 Aug 2020 at 21:30, Oleg Nesterov wrote: > > On 08/19, Sumit Semwal wrote: > > > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2484,7 +2484,7 @@ static inline int vma_adjust(struct vm_area_struct *vma, unsigned long start, > > extern struct vm_area_struct *vma_merge(struct mm_struct *, > > struct vm_area_struct *prev, unsigned long addr, unsigned long end, > > unsigned long vm_flags, struct anon_vma *, struct file *, pgoff_t, > > - struct mempolicy *, struct vm_userfaultfd_ctx); > > + struct mempolicy *, struct vm_userfaultfd_ctx, const char __user *); > > It seems that you forgot to update the callers in fs/userfaultfd.c ? Yes, I did :( - and it didn't get caught with the config I was testing it with. Apologies about that, I will update in the upcoming version. > > Oleg. > Best, Sumit.