linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Brian Johannesmeyer <bjohannesmeyer@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org,
	 Raphael Isemann <teemperor@gmail.com>,
	Cristiano Giuffrida <giuffrida@cs.vu.nl>,
	Herbert Bos <h.j.bos@vu.nl>,
	 Greg KH <gregkh@linuxfoundation.org>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [RFC v2 1/2] dmapool: Move pool metadata into non-DMA memory
Date: Thu, 21 Nov 2024 10:48:17 -0700	[thread overview]
Message-ID: <CAOZ5it1H_bac-W7vptu5pAi=O6KhRWPCwLP8NgjD55+AyBvfwQ@mail.gmail.com> (raw)
In-Reply-To: <Zz6_CFj-MiMk73Tm@infradead.org>

On Wed, Nov 20, 2024 at 10:03 PM Christoph Hellwig <hch@infradead.org> wrote:
> Indeed.  You'd probably need to split the linkage of the pages into
> a list of those that have free blocks and those that don't as a minimum.
>
> Can you share your current version?

Sure, I can share the current version, though fair warning---it’s
still quite messy.

FWIW, I wonder if the bitmap approach might be more suitable as a
separate RFC. AFAICT, the primary issue with the currently submitted
patches is their runtime overhead. I’ve proposed a way to address this
in my recent response to [RFC v2 0/2]. Unfortunately, as I noted,
improving the memory overhead without worsening the runtime
performance is challenging---for example, removing the `next_block`
pointers would require iterating over all pages to find a free
`block`, which significantly impacts the runtime.

That said, how would you prefer I share my bitmap approach? Should I
submit it as a separate patch series or provide the patch directly in
this thread?

Thanks,

Brian Johannesmeyer


  reply	other threads:[~2024-11-21 17:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 20:55 [RFC v2 0/2] dmapool: Mitigate device-controllable mem. corruption Brian Johannesmeyer
2024-11-19 20:55 ` [RFC v2 1/2] dmapool: Move pool metadata into non-DMA memory Brian Johannesmeyer
2024-11-20  9:37   ` Christoph Hellwig
2024-11-20 23:46     ` Brian Johannesmeyer
2024-11-21  5:03       ` Christoph Hellwig
2024-11-21 17:48         ` Brian Johannesmeyer [this message]
2024-11-19 20:55 ` [RFC v2 2/2] dmapool: Use pool_find_block() in pool_block_err() Brian Johannesmeyer
2024-11-19 22:14 ` [RFC v2 0/2] dmapool: Mitigate device-controllable mem. corruption Greg KH
2024-11-19 22:22   ` Brian Johannesmeyer
2024-11-20  9:29 ` Christoph Hellwig
2024-11-20 15:56   ` Keith Busch
2024-11-20 18:51   ` Keith Busch
2024-11-20 21:58     ` Brian Johannesmeyer
2024-11-21  3:37       ` Keith Busch
2024-11-21 17:31         ` Brian Johannesmeyer
2024-11-21 18:06           ` Keith Busch
2024-11-21 19:07             ` Brian Johannesmeyer
2024-11-22 19:19               ` Brian Johannesmeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOZ5it1H_bac-W7vptu5pAi=O6KhRWPCwLP8NgjD55+AyBvfwQ@mail.gmail.com' \
    --to=bjohannesmeyer@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=giuffrida@cs.vu.nl \
    --cc=gregkh@linuxfoundation.org \
    --cc=h.j.bos@vu.nl \
    --cc=hch@infradead.org \
    --cc=kbusch@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=teemperor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox