From: vichy <vichy.kuo@gmail.com>
To: linux-mm@kvack.org
Subject: [PATCH 1/1] mm: allocate order 0 page from pcb before zone_watermark_ok
Date: Wed, 29 Jun 2016 22:44:19 +0800 [thread overview]
Message-ID: <CAOVJa8EPGfWwLtAY8YNOzBqG99J7xL0dMrRmvXs0d8GaXJF9Xw@mail.gmail.com> (raw)
hi all:
In normal case, the allocation of any order page started after
zone_watermark_ok. But if so far pcp->count of this zone is not 0,
why don't we just let order-0-page allocation before zone_watermark_ok.
That mean the order-0-page will be successfully allocated even
free_pages is beneath zone->watermark.
For above idea, I made below patch for your reference.
Signed-off-by: pierre kuo <vichy.kuo@gmail.com>
---
mm/page_alloc.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index c1069ef..406655f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2622,6 +2622,14 @@ static void reset_alloc_batches(struct zone
*preferred_zone)
} while (zone++ != preferred_zone);
}
+static struct page *
+__get_hot_cold_page(bool cold, struct list_head *list)
+{
+ if (cold)
+ return list_last_entry(list, struct page, lru);
+ else
+ return list_first_entry(list, struct page, lru);
+}
/*
* get_page_from_freelist goes through the zonelist trying to allocate
* a page.
@@ -2695,6 +2703,24 @@ zonelist_scan:
if (ac->spread_dirty_pages && !zone_dirty_ok(zone))
continue;
+ if (likely(order == 0)) {
+ struct per_cpu_pages *pcp;
+ struct list_head *list;
+ unsigned long flags;
+ bool cold = ((gfp_mask & __GFP_COLD) != 0);
+
+ local_irq_save(flags);
+ pcp = &this_cpu_ptr(zone->pageset)->pcp;
+ list = &pcp->lists[ac->migratetype];
+ if (!list_empty(list)) {
+ page = __get_hot_cold_page(cold, list);
+ list_del(&page->lru);
+ pcp->count--;
+ }
+ local_irq_restore(flags);
+ if (page)
+ goto get_page_order0;
+ }
mark = zone->watermark[alloc_flags & ALLOC_WMARK_MASK];
if (!zone_watermark_ok(zone, order, mark,
ac->classzone_idx, alloc_flags)) {
@@ -2730,6 +2756,7 @@ zonelist_scan:
try_this_zone:
page = buffered_rmqueue(ac->preferred_zone, zone, order,
gfp_mask, alloc_flags, ac->migratetype);
+get_page_order0:
if (page) {
if (prep_new_page(page, order, gfp_mask, alloc_flags))
goto try_this_zone;
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-06-29 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:44 vichy [this message]
2016-06-30 12:35 ` Michal Hocko
2016-07-05 1:39 ` pierre kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOVJa8EPGfWwLtAY8YNOzBqG99J7xL0dMrRmvXs0d8GaXJF9Xw@mail.gmail.com \
--to=vichy.kuo@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox