From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78A5C54E60 for ; Thu, 14 Mar 2024 17:48:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76B17800D3; Thu, 14 Mar 2024 13:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719DE800B4; Thu, 14 Mar 2024 13:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E41A800D3; Thu, 14 Mar 2024 13:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4B833800B4 for ; Thu, 14 Mar 2024 13:48:03 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C9318801ED for ; Thu, 14 Mar 2024 17:48:01 +0000 (UTC) X-FDA: 81896377962.19.736C2E5 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf11.hostedemail.com (Postfix) with ESMTP id 12B0340006 for ; Thu, 14 Mar 2024 17:47:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=seiWReKO; spf=pass (imf11.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710438480; a=rsa-sha256; cv=none; b=4HAXhhO7mnkKQRQQ9qN3/HS3zqEbs2PHk2b/jiESBYbiJLVtdg0pj3YKK3Yf7GnAm0J2P6 VJGdOXxjunQeRp6uo8Qy5QB67OB5PUbfwpbfSJLyRAW5VnD624grM25wGW4IUWTR+mRp6S 3SOt72h2wPmcJQdH8AZIllS35YPaf6w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=seiWReKO; spf=pass (imf11.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710438480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m+JV3A7zu6nIaIvNDYv5nSo/ckyKnBKjeigqrs00bqQ=; b=axIAmt/SRZgdVxYsrX/3/zZ9JuhR63UpCymOAOz0w8WJCJbd+fvB50lhmOM4F2QFZDWOoq fCZ9ufzRLjWjlzPXDcXnVDCwKMLxnNi+jlNjsT31XlY25fh9O99UNoTkku0gfLZecznHz+ nDBG/z/6ghb4Q01+qC5b+sbKIPT06r0= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-412f81fd561so6685e9.1 for ; Thu, 14 Mar 2024 10:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710438478; x=1711043278; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m+JV3A7zu6nIaIvNDYv5nSo/ckyKnBKjeigqrs00bqQ=; b=seiWReKO/blPBNHkbJGLLNlOSkseec7SdLhaFOxg17BC1HRCcTnupttpmGU2Elt7BQ 22TeySjObNe4Pn5qhj/Z1fzi82W/u146aCzGPNR+1hlGDbXhpA/R1ReFLr1LQZbEu85P 5gfHLEHKjy2A1zLZToieNiSKVgkP73pmBNkb/txPAuBfGEJ+T3p6q4p/PAVd/K1DBnW6 XrijzQRGjCudLOnrv9yQ/umFxxL+qmVzwJuwvqu9nPbHtSgBvyV+Ne6ZCzBsa6rv57q8 7/7jL7xXMXYOialyQSsTq1dgwawv2TDW4lqAh13TPMIekh3TqnTds9WiJZSxGtR48e/H 8VNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710438478; x=1711043278; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m+JV3A7zu6nIaIvNDYv5nSo/ckyKnBKjeigqrs00bqQ=; b=Nza5keuKnkgDueKyP7q6pOhHvP0mmh0LJkyqSVKXrDltuZJYAPZpFYwOAbARKrtxbe ic00XMQr6xAkD9SHNfr9q/zOsa1ycNtlu8+Fkm8jx51vczg8TJfTpArhcLPcyDQalPDA o7xJmWc4GNZelnbQkbQHxmyTdiXkIC6XA6eIhzz9HAbDoPs/1qJ9GygVk91byTk3fifu 9Lj4SU/Qsg45NJIjRaRyz9TzUTsxUZabIaVZ+JcVuh1xjhjHoe+8I5uDXjoTtxeWMrEc k8P+OuSlpQTcFHznJ/CITpD6WfNymgaRVrr2Tvpi2hzIrQCfrRP5mpC6C5v7YdIgVIZ8 x+Sw== X-Forwarded-Encrypted: i=1; AJvYcCXBqQQ4wHsWvgd8dBqfnv/sQ22w0FeKQGYWowR44P6PviSylzW23bOvgFwmySgiXWNgpDUEjmw58CITjccJspAjssw= X-Gm-Message-State: AOJu0YxmMve8Arul9G8YGtBbsqWA/ZhUaXzwzgFuv7RtbMGSPC77HDtl JQVQN4x7T+29fIzMLvyQVtH3MaEAK/z1sCpVjXM7bWbxv8u7i1y6vKBz0lRAiu4uvXDR9Eh9F+b T62BAy9kE0bstqJtIaqcFBbdyUQCLO7AV1A+u X-Google-Smtp-Source: AGHT+IFy6M2yyJA6TzxA06WYq5+dmaqNGCrUNNAyVyYq9H61p5PnHUB1XMymcdTXwvLETVxn8dg6XzlydAlcDssbeb0= X-Received: by 2002:a05:600c:1e03:b0:413:ef8f:751a with SMTP id ay3-20020a05600c1e0300b00413ef8f751amr219687wmb.2.1710438478385; Thu, 14 Mar 2024 10:47:58 -0700 (PDT) MIME-Version: 1.0 References: <20240314141516.31747-1-liuhailong@oppo.com> In-Reply-To: <20240314141516.31747-1-liuhailong@oppo.com> From: Yu Zhao Date: Thu, 14 Mar 2024 13:47:20 -0400 Message-ID: Subject: Re: [PATCH] Revert "mm: skip CMA pages when they are not available" To: liuhailong@oppo.com Cc: akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, surenb@google.com, zhaoyang.huang@unisoc.com, Charan Teja Kalla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 12B0340006 X-Stat-Signature: j5keo4cdc6b9hs9pxh3gj6shntsdhrbj X-Rspam-User: X-HE-Tag: 1710438479-793713 X-HE-Meta: U2FsdGVkX1/h40Gjb1M/hUCchRWdDpLwADhojv/JgdrWR631WIyLooUMBTIpcZgiQKxUlrxJtWtI0ThEvxWg5lCmi7UuM+btuVtWpUO+F/BhmIm65S55tUGQ62xC/2hv8gfHEz4EeMmi+ziTcOFgoI7MOAFt9qnQuw+1T+y+VZtRka6jn3ygWFRQptw81NyuWRZOQkOwyHeOcehOKicgZlhV+f9Hi6XN14sV0QQiMXy8RZMsLo33Pjze6aUCq+dd/bKefS0umNr8PzB5jDhWOYMIFatq4Ou/B/TCZMP1g+TRtXlFYU751jXgDkMImbtyhkMhm6uzYVrg+wu2RIWpMSNvGFJkjD4oLaCktRQJdQ6jUdagm/vNiyxgs6vSyaexhdnX/9KZCySRUcb0rxgvyi+5Afo1TDBk115VLpbubz6p1cB0SFzWoXPdBXtxWmbpFEaV4TRIvdtnx4xjbwK9Q9ZrnqvntxDB2IDRNSqB6rsOAmyPf1aoTiiTY3UnOXrc62j8CsgnpDof6JF1xP5AEV3xiZqrCDhVTsqNL7wET1d5XdkY/wupfBC9WDIad4ADECh4AIKQJIK7rQMcVk3pPtGbT6KAhM0UBfCo/01nSIbP6zid3ZIZyGzE1qorPB55RYiUQAazR4Ax0Wla4QuuIouHPeuvnhfDuL5I7wExgq48fAHwHtQvAli587lVzZxVLTQCAiaPnedHH00SIu08Zc5YvgmD/ZEbv0XamvAB+rbRJSdlsJmgiZpCgX8DFGoTb97mkYEOUSJtlWBL1tQjAo8mkth6BDmsSG2XvqFacJY8plOoRbDawusxIQfRWuMp13xVKJrQdFIezOefL2ATz1L42529baS/EAdyzqMx7lIlyI2ROGQiHsjKFMpC1X8rb4SRQtLNYxj2ODf8nTYi+EltrvDcJOlqsliRm+T0YoUBuZnMbJxtUL1FYF2QrwuUsO1LGA4nCOA4kTG6cpy BGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 14, 2024 at 10:15=E2=80=AFAM wrote: > > From: "Hailong.Liu" > > This reverts commit 5da226dbfce3a2f44978c2c7cf88166e69a6788b. > > patch may cause system not responding. if cma pages is large in lru_list > and system is in lowmemory, many tasks would enter direct reclaim and was= te > cpu time to isolate and return. Test this patch on android-5.15 device > and tasks call stack as below. > > Task name: UsbFfs-worker [affinity: 0xff] pid: 3374 cpu: 7 prio: 120 star= t: ffffff8897a35c80 > state: 0x0[R] exit_state: 0x0 stack base: 0xffffffc01eaa0000 > Last_enqueued_ts: 0.000000000 Last_sleep_ts: 0.000000000 > Stack: > [] __switch_to+0x180 > [] __schedule+0x4dc > [] preempt_schedule+0x5c > [] _raw_spin_unlock_irq+0x54 > [] shrink_inactive_list+0x1d0 > [] shrink_lruvec+0x1bc > [] shrink_node_memcgs+0x184 > [] shrink_node+0x2d0 > [] shrink_zones+0x14c > [] do_try_to_free_pages+0xe8 > [] try_to_free_pages+0x2e0 > [] __alloc_pages_direct_reclaim+0x84 > [] __alloc_pages_slowpath+0x4d0 > [] __alloc_pages_nodemask[jt]+0x124 > [] __vmalloc_area_node+0x188 > [] __vmalloc_node+0x148 > [] vmalloc+0x4c > [] ffs_epfile_io+0x258 > [] kretprobe_trampoline[jt]+0x0 > [] kretprobe_trampoline[jt]+0x0 > [] __io_submit_one+0x1c0 > [] io_submit_one+0x88 > [] __do_sys_io_submit+0x178 > [] __arm64_sys_io_submit+0x20 > [] el0_svc_common.llvm.9961749221945255377+0xd0 > [] do_el0_svc+0x28 > [] el0_svc+0x14 > [] el0_sync_handler+0x88 > [] el0_sync+0x1b8 > > Task name: kthreadd [affinity: 0xff] pid: 2 cpu: 7 prio: 120 start: fffff= f87808c0000 > state: 0x0[R] exit_state: 0x0 stack base: 0xffffffc008078000 > Last_enqueued_ts: 0.000000000 Last_sleep_ts: 0.000000000 > Stack: > [] __switch_to+0x180 > [] __schedule+0x4dc > [] preempt_schedule+0x5c > [] _raw_spin_unlock_irq+0x54 > [] shrink_inactive_list+0x2cc > [] shrink_lruvec+0x1bc > [] shrink_node_memcgs+0x184 > [] shrink_node+0x2d0 > [] shrink_zones+0x14c > [] do_try_to_free_pages+0xe8 > [] try_to_free_pages+0x2e0 > [] __alloc_pages_direct_reclaim+0x84 > [] __alloc_pages_slowpath+0x4d0 > [] __alloc_pages_nodemask[jt]+0x124 > [] __vmalloc_area_node+0x188 > [] __vmalloc_node_range+0x88 > [] scs_alloc+0x1b8 > [] scs_prepare+0x20 > [] dup_task_struct+0xd4 > [] copy_process+0x144 > [] kernel_clone+0xb4 > [] kernel_thread+0x5c > [] kthreadd+0x184 > > without this patch, the tasks will reclaim cma pages and wakeup > oom-killer or not spin on cpus. > > Signed-off-by: Hailong.Liu > --- > mm/vmscan.c | 22 +--------------------- > 1 file changed, 1 insertion(+), 21 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2fe4a11d63f4..197ddf62019f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2261,25 +2261,6 @@ static __always_inline void update_lru_sizes(struc= t lruvec *lruvec, > > } > > -#ifdef CONFIG_CMA > -/* > - * It is waste of effort to scan and reclaim CMA pages if it is not avai= lable > - * for current allocation context. Kswapd can not be enrolled as it can = not > - * distinguish this scenario by using sc->gfp_mask =3D GFP_KERNEL > - */ > -static bool skip_cma(struct folio *folio, struct scan_control *sc) > -{ > - return !current_is_kswapd() && > - gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABL= E && > - get_pageblock_migratetype(&folio->page) =3D=3D MI= GRATE_CMA; > -} > -#else > -static bool skip_cma(struct folio *folio, struct scan_control *sc) > -{ > - return false; > -} > -#endif > - NAK. +Charan Teja Kalla -- This can cause build errors when CONFIG_LRU_GEN=3Dy. If you plan to post a v2, please include a reproducer. Thanks. > /* > * Isolating page from the lruvec to fill in @dst list by nr_to_scan tim= es. > * > @@ -2326,8 +2307,7 @@ static unsigned long isolate_lru_folios(unsigned lo= ng nr_to_scan, > nr_pages =3D folio_nr_pages(folio); > total_scan +=3D nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx || > - skip_cma(folio, sc)) { > + if (folio_zonenum(folio) > sc->reclaim_idx) { > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > move_to =3D &folios_skipped; > goto move; > -- > 2.34.1 > >