From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 491FBC4332F for ; Tue, 22 Nov 2022 19:08:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B2F06B0071; Tue, 22 Nov 2022 14:08:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 963066B0073; Tue, 22 Nov 2022 14:08:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82AC58E0001; Tue, 22 Nov 2022 14:08:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F4376B0071 for ; Tue, 22 Nov 2022 14:08:45 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 478AB16074E for ; Tue, 22 Nov 2022 19:08:45 +0000 (UTC) X-FDA: 80162015010.03.30E8BE3 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by imf16.hostedemail.com (Postfix) with ESMTP id A358218000F for ; Tue, 22 Nov 2022 19:08:44 +0000 (UTC) Received: by mail-vs1-f47.google.com with SMTP id t5so15409214vsh.8 for ; Tue, 22 Nov 2022 11:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fKEisOcCxxrkfHjW9WxsM8SkyONoJunCQr/mSNvg18w=; b=mv1vO6EVJFQHmOOPSto15ifvc0zcEe34ioOnM5MyYbCpS7QbKucnzT6UaTsnTf5CxU tWRPFwXHVHphMm1FODx/9niRsHYLf71qs0kMmREw/jSZ6idKI06kHWAGrIxinqsXv0c7 6p23QtcPBpkHBgWP+kblIIB3gaaUln2L40fy6NnWeLTTK9iMYhP730afCEVnW5dP6rcg jKUKEeHB78cVPoapdl1gSBPnSH2y/w2z+T4lmWO2jzVbFI0goi6foKF+0O/2xAypEKek +P4aw8o6DBuP73QHlRXdpjMD9Un3Va0nJmSBL44jF6Z7qOHnZPtkhTH8oK0ZIfGrkNni OASQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fKEisOcCxxrkfHjW9WxsM8SkyONoJunCQr/mSNvg18w=; b=hcU28EjFelz4boejWGntoCFn5UD9fBFny1XHgcPPjjK25hFNrsSIjrj6lHt+H4z976 oA/AE36dDc+xjWdPOj5FuZAJRHKb8WAfwhfmWYeByw8LPl63hdW6Z1RIHluWQH2JbyrA QsFPTXNydBXZ7eCrI4HdhsI8T2hbwzZEmxt8gw2Xmy/pzg66IKprb8sJ7BSxyEOyAzqn MAWkwyzzmv3Oqrx9RBI/QE1TbtA3gXxC2Q05elonucpXwtpCATriTRpTFE5AfcZFw3HJ MyoHALtshBKTLeotxZsV97EkTnDTNWMbBntb55a/6rhnY3b9IHVFuvKNKTdtERKodHZH Filw== X-Gm-Message-State: ANoB5pnAoMNvXZq6seD2yT3M+y4X3JO/W91GW9Aws0i8KVELciMtMB/8 m1TSeWEQAEbXiPU8sf0FqyOHRHUZV4ywah4iipWlsg== X-Google-Smtp-Source: AA0mqf7s3ZLwIADGrmZbS5EhOy/cXfvuc6KPbinmWOjq5dzTh0s+Gs8Q8RUfUPw9LF8wsXqWnglSj8+M2Vn9ZD9H6iw= X-Received: by 2002:a67:fbd6:0:b0:3ac:38c7:1bdd with SMTP id o22-20020a67fbd6000000b003ac38c71bddmr4789726vsr.9.1669144123684; Tue, 22 Nov 2022 11:08:43 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Yu Zhao Date: Tue, 22 Nov 2022 12:08:07 -0700 Message-ID: Subject: Re: Low TCP throughput due to vmpressure with swap enabled To: Ivan Babrou Cc: Linux MM , Linux Kernel Network Developers , linux-kernel , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , cgroups@vger.kernel.org, kernel-team Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669144124; a=rsa-sha256; cv=none; b=vdb5+37HCtvq9BxfK81ZP6/4+xNTMAbVECKvzjilALA65rT34iVb7KURyP3+COlLZrtVWL 3LMmDQiaRhhrHyJM6x2wIovAqv2M2i43lLqxpLkbxIFmvZYCAflyGIQvxKcZcpi4SVTarr eFaez135iO2G4siTVwrEKh/UapPJbsk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mv1vO6EV; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669144124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fKEisOcCxxrkfHjW9WxsM8SkyONoJunCQr/mSNvg18w=; b=CEs/p7YzdhDgnjg11Ie+J7o05KJqD2Ge3qsiyMxGLr60fgc6afv/cyMZK7lX97XTvByxIa RvRn2R99m1fwILI7MoFS4wERoPpitQiJ/PC8FuRHJe7wMI5pUk1lw3Uw0HSPIIoTuUTdoQ pmxIJtT0BTfEys0lORbNGMBL/2NntcQ= X-Stat-Signature: kr3cqaqaiz45pzqfcxgcn3q8915sxujm X-Rspamd-Queue-Id: A358218000F X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mv1vO6EV; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1669144124-592813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 12:05 PM Ivan Babrou wrote: > > On Tue, Nov 22, 2022 at 10:59 AM Yu Zhao wrote: > > > > On Mon, Nov 21, 2022 at 5:53 PM Ivan Babrou wrote: > > > > > > Hello, > > > > > > We have observed a negative TCP throughput behavior from the following commit: > > > > > > * 8e8ae645249b mm: memcontrol: hook up vmpressure to socket pressure > > > > > > It landed back in 2016 in v4.5, so it's not exactly a new issue. > > > > > > The crux of the issue is that in some cases with swap present the > > > workload can be unfairly throttled in terms of TCP throughput. > > > > > > I am able to reproduce this issue in a VM locally on v6.1-rc6 with 8 > > > GiB of RAM with zram enabled. > > > > Hi Ivan, > > > > If it's not too much trouble, could you try again with the following? > > CONFIG_LRU_GEN=y > > CONFIG_LRU_GEN_ENABLED=y > > > > I haven't tried it myself. But I'll fix whatever doesn't work for you, > > since your team is on the top of my customer list :) > > We don't have it in production, since there we have 5.15 LTS (our > kernel team is testing v6.1). > > I do have it enabled in my VM running v6.1-rc6 where I was able to > replicate this, so it doesn't seem to help. Thanks. I'll look into this and get back to you.