From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A41C4332F for ; Thu, 20 Oct 2022 22:19:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6630E8E0002; Thu, 20 Oct 2022 18:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 613538E0001; Thu, 20 Oct 2022 18:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DBD08E0002; Thu, 20 Oct 2022 18:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3F2198E0001 for ; Thu, 20 Oct 2022 18:19:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1746E1A129C for ; Thu, 20 Oct 2022 22:19:15 +0000 (UTC) X-FDA: 80042744670.18.751E5B9 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by imf18.hostedemail.com (Postfix) with ESMTP id AFABF1C0025 for ; Thu, 20 Oct 2022 22:19:14 +0000 (UTC) Received: by mail-vk1-f172.google.com with SMTP id u204so519006vkb.13 for ; Thu, 20 Oct 2022 15:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yPAtFjxnM9QnPlCbiawpwzjKWBbf/HX4WSc2JVqLBOY=; b=O84ATMDl80Y3SemMzzwQ8EhGpuSf7ld5bfiznIEopm2rGgtJ2AVff2EKS4z/g8jvTY TJ6ZQhu7eyriq8P5/K15dRBQhTAfMSJ+7o7KzFVtV3sgCdVxWauKyzIl08agFdTedz3Y irvKUAJktENQYFrv8APfpioWxRUhrGliDoj9F2tT+0H0vZdE0rckcKhXI6YJ+8yloUVa jbt+raQSAqWX2CUGU2pPAs9icMIgJRQZShjYbgpAkxgPlg6IuxAwG9v16Yv417TJnEc3 blZ7tpFUJGB9fjfkFlBd1hLZK7WCCOHcxjHC08Br+8ru/MXjmXbf2gdYDMNyYI3aA5xx 4lxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yPAtFjxnM9QnPlCbiawpwzjKWBbf/HX4WSc2JVqLBOY=; b=ArC1WQUwruLCDClmaYqQs89V4wcuIfzPZw8keBL52x4uljsb/U0kLTOEwhbDX76Wa+ tJGrGkgDB9k7L4gY+BK1f6OyMMSACCAypUZCHd4CVDDyfsynIBGbpia0OMU6w3lKBiJd S6yghxB0clUrg+UtRsQzAwK1T8bLKsqMva2YesAigXSKHCjWk5IqfWzCsY6/D4sA2m2l AE17dMXC1P/YBW4kFwc8GjdKr6Azpy2rvjQnQ0uP4WE3bN5xrVojUHtYSTzxAOgcQxRR WKbOyFZVMytK5yP3Rzpwy4ZblV9sUF5pAxQKylTYQU35/JNjmQ0Ibt2toj+l9qQt1oev 5nKQ== X-Gm-Message-State: ACrzQf2p1Tw5vsnMduf0jZDHQTG2ZS7a4Gp7z4lXDI1gptTmLjh48NJp 3CZ4jaCuGjm7Vfj2MsSs8yD9i/vBRr+pnkxGjlHLhQ== X-Google-Smtp-Source: AMsMyM6xkQz9a/gQKoWalavcV/VMmLVHiTXvwYuHIgv3jfm/DBzxvgR9gq6NZaYBHO17UoOHWK1SA4j2k8/IhBKP3AQ= X-Received: by 2002:a1f:b453:0:b0:3ab:2c49:57df with SMTP id d80-20020a1fb453000000b003ab2c4957dfmr8495848vkf.29.1666304353774; Thu, 20 Oct 2022 15:19:13 -0700 (PDT) MIME-Version: 1.0 References: <1666289686-22798-1-git-send-email-ssengar@linux.microsoft.com> In-Reply-To: <1666289686-22798-1-git-send-email-ssengar@linux.microsoft.com> From: Yu Zhao Date: Thu, 20 Oct 2022 16:18:37 -0600 Message-ID: Subject: Re: [PATCH] mm/gup: fix gup_pud_range() for dax To: Saurabh Sengar Cc: ssengar@microsoft.com, akpm@linux-foundation.org, jack@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jostarks@microsoft.com, Matthew Wilcox , Dan Williams Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666304354; a=rsa-sha256; cv=none; b=wUSmqpQPG3A1A93HD3IcYIE4EnAU4G6t/8YVUs9RKz9NIfrDFL5Sd3acPUTDN04/9L+N98 ggckiti8xNyQUO5wcJMjaQT910Y2iIYADEGKxlkG+BVubraKzOi2Js8SKzTpd6w+5KbtZW 7Q2bRgVgQ5YZ97Jk/ftMFiZ+q2s/edY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O84ATMDl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666304354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yPAtFjxnM9QnPlCbiawpwzjKWBbf/HX4WSc2JVqLBOY=; b=pTgjfX8AZ/gEwxh+66NgdPPEcfFpiaATrUnmf5Z0yMyKkNbJm2dimEcnyoQkelKLFAFgZI h44IFxMVdY3XMyjHSBDKD82q/3/VJm7iXclg52KDcw5mAkGpoQoDCVvlCl4d0TYWdj5Pho M3H4a9pJrl1gE/0E01JyzxOCfQOnR4s= X-Stat-Signature: zziah7mtkhbc65g1nhheixi9h16t6q45 X-Rspamd-Queue-Id: AFABF1C0025 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O84ATMDl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspamd-Server: rspam11 X-HE-Tag: 1666304354-384847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 12:14 PM Saurabh Sengar wrote: > > From: John Starks > > For dax pud, pud_huge() returns true on x86. So the function works as long > as hugetlb is configured. However, dax doesn't depend on hugetlb. > Commit 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax") fixed > devmap-backed huge PMDs, but missed devmap-backed huge PUDs. Fix this as > well. > > Fixes: 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax") > Signed-off-by: John Starks > Signed-off-by: Saurabh Sengar > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 05068d3d2557..9e07aa54a4cd 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2687,7 +2687,7 @@ static int gup_pud_range(p4d_t *p4dp, p4d_t p4d, unsigned long addr, unsigned lo > next = pud_addr_end(addr, end); > if (unlikely(!pud_present(pud))) > return 0; > - if (unlikely(pud_huge(pud))) { > + if (unlikely(pud_huge(pud) || pud_devmap(pud))) { Perhaps s/pud_huge/pud_leaf/ ? > if (!gup_huge_pud(pud, pudp, addr, next, flags, > pages, nr)) > return 0; > -- > 2.25.1 >